diff mbox series

[OpenWrt-Devel] tools: Update endian definitions for Mac OSX

Message ID 20181218124903.10456-1-ldir@darbyshire-bryant.me.uk
State Accepted
Headers show
Series [OpenWrt-Devel] tools: Update endian definitions for Mac OSX | expand

Commit Message

Kevin 'ldir' Darbyshire-Bryant Dec. 18, 2018, 12:49 p.m. UTC 
- it appears (at least from OS X verison 10.10, Yosemite) that the
    big and little endian defintions have changed.

    the older

       #include <sys/_endian.h>
       #include <architecture/byte_order.h>

    reference yielded the following warning:

         #define __bswap_16(x)      NXSwapShort(x)
                                    ^
       /usr/include/architecture/byte_order.h:45:1: note: 'NXSwapShort' has been explicitly marked deprecated here

    For the new OS X editions, it seems that we need to refer to:

      #include <netinet/in.h>
      #include <libkern/OSByteOrder.h>

    and respectively use 'OSSwapInt16', 'OSSwapInt32', & 'OSSwapInt64', in
    place of 'NXSwapShort', 'NXSwapLong' & 'NXSwapLongLong'.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
---
 tools/include/endian.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/tools/include/endian.h b/tools/include/endian.h
index bba70abd83..e2ac755667 100644
--- a/tools/include/endian.h
+++ b/tools/include/endian.h
@@ -5,11 +5,11 @@ 
 #include <byteswap.h>
 #include_next <endian.h>
 #elif defined(__APPLE__)
-#include <machine/endian.h>
-#include <machine/byte_order.h>
-#define bswap_16(x) NXSwapShort(x)
-#define bswap_32(x) NXSwapInt(x)
-#define bswap_64(x) NXSwapLongLong(x)
+#include <netinet/in.h>
+#include <libkern/OSByteOrder.h>
+#define bswap_16(x) OSSwapInt16(x)
+#define bswap_32(x) OSSwapInt32(x)
+#define bswap_64(x) OSSwapInt64(x)
 #elif defined(__FreeBSD__)
 #include <sys/endian.h>
 #define bswap_16(x) bswap16(x)