diff mbox series

[OpenWrt-Devel,v5,1/2] Evaluate board names in alphabetical order

Message ID 20181206152536.38850-2-jonathan@navigue.com
State Changes Requested
Delegated to: John Crispin
Headers show
Series Allow sysupgrade restore on ER | expand

Commit Message

Jonathan Thibault Dec. 6, 2018, 3:25 p.m. UTC 
---
 target/linux/octeon/base-files/lib/upgrade/platform.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Paul Fertser Jan. 3, 2020, 12:55 p.m. UTC | #1 
Hi,

Somewhat related,

On Fri, Jan 03, 2020 at 01:34:43PM +0100, mail@adrianschmutzler.de wrote:
> I do not have the old e-mails for those changes, thus I cannot respond correctly.

One can do

wget http://lists.infradead.org/mailman/private/openwrt-devel.mbox/openwrt-devel.mbox?username=<youremail>\&password=<yourpassword>

to retrieve full mailing list archive in mailbox format and use
his/her favourite MUA to comfortably reply to any given mail.

Also, the patchwork shows Message ID clearly, so if your MUA allows
setting of In-Reply-To header you can do that even without using the
mailing list archive (I demonstrate this in this very mail, using Mutt
and :set edit_headers option).

> Still, both (very old) patches miss commit message and, more importantly, Signed-off, so I will mark them as "Changes Requested".
Petr Štetiar Jan. 3, 2020, 3:50 p.m. UTC | #2 
Paul Fertser <fercerpav@gmail.com> [2020-01-03 15:55:24]:

> wget http://lists.infradead.org/mailman/private/openwrt-devel.mbox/openwrt-devel.mbox?username=<youremail>\&password=<yourpassword>
> 
> to retrieve full mailing list archive in mailbox format and use
> his/her favourite MUA to comfortably reply to any given mail.

Thanks a lot for sharing, didn't know about it, very useful.

-- ynezz
diff mbox series

Patch

diff --git a/target/linux/octeon/base-files/lib/upgrade/platform.sh b/target/linux/octeon/base-files/lib/upgrade/platform.sh
index cd49c0da36..6d258dbb0f 100755
--- a/target/linux/octeon/base-files/lib/upgrade/platform.sh
+++ b/target/linux/octeon/base-files/lib/upgrade/platform.sh
@@ -62,12 +62,12 @@  platform_do_upgrade() {
 
 	[ -b "${rootfs}" ] || return 1
 	case "$board" in
-	erlite)
-		kernel=sda1
-		;;
 	er)
 		kernel=mmcblk0p1
 		;;
+	erlite)
+		kernel=sda1
+		;;
 	*)
 		return 1
 	esac
@@ -82,8 +82,8 @@  platform_check_image() {
 	local board=$(board_name)
 
 	case "$board" in
-	erlite | \
-	er)
+	er | \
+	erlite)
 		local tar_file="$1"
 		local kernel_length=`(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c) 2> /dev/null`
 		local rootfs_length=`(tar xf $tar_file sysupgrade-$board/root -O | wc -c) 2> /dev/null`