diff mbox series

[OpenWrt-Devel,RFC,06/27] kernel: Add kmod-phy-realtek

Message ID 20181127231449.29188-7-hauke@hauke-m.de
State RFC
Delegated to: Hauke Mehrtens
Headers show
Series Add support for kernel 4.19 | expand

Commit Message

Hauke Mehrtens Nov. 27, 2018, 11:14 p.m. UTC
The r8169 driver uses the phy lib with the realtek phy driver in kernel
4.19 instead of integrating the phy driver into the mac driver.
Add the new phy driver and add this missing dependency.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 package/kernel/linux/modules/netdevices.mk | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Comments

Yousong Zhou Nov. 28, 2018, 5:32 a.m. UTC | #1
On Wed, 28 Nov 2018 at 07:17, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>
> The r8169 driver uses the phy lib with the realtek phy driver in kernel
> 4.19 instead of integrating the phy driver into the mac driver.
> Add the new phy driver and add this missing dependency.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  package/kernel/linux/modules/netdevices.mk | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk
> index 2e89572731..474419983d 100644
> --- a/package/kernel/linux/modules/netdevices.mk
> +++ b/package/kernel/linux/modules/netdevices.mk
> @@ -180,6 +180,22 @@ endef
>  $(eval $(call KernelPackage,phy-broadcom))
>
>
> +define KernelPackage/phy-realtek
> +   SUBMENU:=$(NETWORK_DEVICES_MENU)
> +   TITLE:=Realtek Ethernet PHY driver
> +   KCONFIG:=CONFIG_REALTEK_PHY
> +   DEPENDS:=+kmod-libphy
> +   FILES:=$(LINUX_DIR)/drivers/net/phy/realtek.ko
> +   AUTOLOAD:=$(call AutoLoad,18,realtek,1)
> +endef
> +
> +define KernelPackage/phy-realtek/description
> +   Supports the Realtek 821x PHY.
> +endef
> +
> +$(eval $(call KernelPackage,phy-realtek))
> +
> +
>  define KernelPackage/swconfig
>    SUBMENU:=$(NETWORK_DEVICES_MENU)
>    TITLE:=switch configuration API
> @@ -466,7 +482,7 @@ $(eval $(call KernelPackage,8139cp))
>  define KernelPackage/r8169
>    SUBMENU:=$(NETWORK_DEVICES_MENU)
>    TITLE:=RealTek RTL-8169 PCI Gigabit Ethernet Adapter kernel support
> -  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware
> +  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware +LINUX_4_19:kmod-libphy +LINUX_4_19:kmod-phy-realtek

The selection of kmod-libphy should be eliminated here.  It's a direct
dependency of kmod-phy-realtek.

Regards,
                yousong
Hauke Mehrtens Nov. 29, 2018, 10:27 p.m. UTC | #2
On 11/28/18 6:32 AM, Yousong Zhou wrote:
> On Wed, 28 Nov 2018 at 07:17, Hauke Mehrtens <hauke@hauke-m.de> wrote:
>>
>> The r8169 driver uses the phy lib with the realtek phy driver in kernel
>> 4.19 instead of integrating the phy driver into the mac driver.
>> Add the new phy driver and add this missing dependency.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>>  package/kernel/linux/modules/netdevices.mk | 18 +++++++++++++++++-
>>  1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk
>> index 2e89572731..474419983d 100644
>> --- a/package/kernel/linux/modules/netdevices.mk
>> +++ b/package/kernel/linux/modules/netdevices.mk
>> @@ -180,6 +180,22 @@ endef
>>  $(eval $(call KernelPackage,phy-broadcom))
>>
>>
>> +define KernelPackage/phy-realtek
>> +   SUBMENU:=$(NETWORK_DEVICES_MENU)
>> +   TITLE:=Realtek Ethernet PHY driver
>> +   KCONFIG:=CONFIG_REALTEK_PHY
>> +   DEPENDS:=+kmod-libphy
>> +   FILES:=$(LINUX_DIR)/drivers/net/phy/realtek.ko
>> +   AUTOLOAD:=$(call AutoLoad,18,realtek,1)
>> +endef
>> +
>> +define KernelPackage/phy-realtek/description
>> +   Supports the Realtek 821x PHY.
>> +endef
>> +
>> +$(eval $(call KernelPackage,phy-realtek))
>> +
>> +
>>  define KernelPackage/swconfig
>>    SUBMENU:=$(NETWORK_DEVICES_MENU)
>>    TITLE:=switch configuration API
>> @@ -466,7 +482,7 @@ $(eval $(call KernelPackage,8139cp))
>>  define KernelPackage/r8169
>>    SUBMENU:=$(NETWORK_DEVICES_MENU)
>>    TITLE:=RealTek RTL-8169 PCI Gigabit Ethernet Adapter kernel support
>> -  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware
>> +  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware +LINUX_4_19:kmod-libphy +LINUX_4_19:kmod-phy-realtek
> 
> The selection of kmod-libphy should be eliminated here.  It's a direct
> dependency of kmod-phy-realtek.
Ok, I will change this.

Hauke
diff mbox series

Patch

diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk
index 2e89572731..474419983d 100644
--- a/package/kernel/linux/modules/netdevices.mk
+++ b/package/kernel/linux/modules/netdevices.mk
@@ -180,6 +180,22 @@  endef
 $(eval $(call KernelPackage,phy-broadcom))
 
 
+define KernelPackage/phy-realtek
+   SUBMENU:=$(NETWORK_DEVICES_MENU)
+   TITLE:=Realtek Ethernet PHY driver
+   KCONFIG:=CONFIG_REALTEK_PHY
+   DEPENDS:=+kmod-libphy
+   FILES:=$(LINUX_DIR)/drivers/net/phy/realtek.ko
+   AUTOLOAD:=$(call AutoLoad,18,realtek,1)
+endef
+
+define KernelPackage/phy-realtek/description
+   Supports the Realtek 821x PHY.
+endef
+
+$(eval $(call KernelPackage,phy-realtek))
+
+
 define KernelPackage/swconfig
   SUBMENU:=$(NETWORK_DEVICES_MENU)
   TITLE:=switch configuration API
@@ -466,7 +482,7 @@  $(eval $(call KernelPackage,8139cp))
 define KernelPackage/r8169
   SUBMENU:=$(NETWORK_DEVICES_MENU)
   TITLE:=RealTek RTL-8169 PCI Gigabit Ethernet Adapter kernel support
-  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware
+  DEPENDS:=@PCI_SUPPORT +kmod-mii +r8169-firmware +LINUX_4_19:kmod-libphy +LINUX_4_19:kmod-phy-realtek
   KCONFIG:=CONFIG_R8169 \
     CONFIG_R8169_NAPI=y \
     CONFIG_R8169_VLAN=n