From patchwork Sat Oct 27 22:15:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Santos X-Patchwork-Id: 989940 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=pobox.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W9tzY6Bj"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="ujKWGiz3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42jFb43fJJz9sC2 for ; Sun, 28 Oct 2018 09:16:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=wak70nv2ZXjKAf1oAjMwr0r5qn8r3T7DDQeFqOZwGzU=; b=W9tzY6BjYUmml2 89Lcxg1sruUpw7PGhMGj2NxNIePkF9UZE8ar4gzX0WwJtvPpKWS9M7L8rf4NYMIVlJdH3CCYswAR2 kr1cIpQcDM569yzpbQwQGI6EYAQMSB2fB5FuomwnTtzFME23/Fx4/lGhE66HF9DgvYD6V/HOA3+4d yqsLS1iHTHCx7aHcAqIWdwzFS9jBael9EKzneJW1Oe7yJTkMKfvhHgXzQEcTNy+57/V9swrfMnn+M KlMYPw3B6hBTfdukhjKDNZV+d2hDLThXFoxT0+cC7u1KbKlizjnaeHSUzrB0MEkJ9HnqCqMJWLnaJ FgKMNsq+mAYTcdA3rz5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gGWsp-00042s-Fn; Sat, 27 Oct 2018 22:16:39 +0000 Received: from pb-smtp2.pobox.com ([64.147.108.71]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gGWsm-00042A-FY for openwrt-devel@lists.openwrt.org; Sat, 27 Oct 2018 22:16:38 +0000 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id D36D610133B; Sat, 27 Oct 2018 18:16:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id; s=sasl; bh=MihmeQHm6OmYT+ye1mYWazyIaQk =; b=ujKWGiz3o31RyOb+sRyw4fDBeC32lLigQiFFkXDSjtaTlcvd8G11OVClKRR 7hHdfPjps5HOOyGQgBtTV9eTxc+azaPoGrjSIsgeZWCVAWYzvsuCwvCbqUYTCVy7 XNgYi9Y9qTQ16eMh5xRMsgkI2GsEZc1q7NoXx5K1IoPjiI0Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:date:message-id; q=dns; s=sasl; b=o8MlSgC2D8070+oynPCy2 EH3Ja3n6EhHOZa2EANofbsAEJIcW/OZSiVGMbeYUb9w/ufCROT1bGFncp7IPpKzE 0z3OD5GM1qfSz6N5PdlUWFf699d6YWfW+X0bUhhd6u77dQP/rgGjlxNjfR+DKgo4 QoVdaZ4RigmsEbwUSSHpMc= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id CBB64101339; Sat, 27 Oct 2018 18:16:20 -0400 (EDT) Received: from love.attlocal.net (unknown [76.215.41.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 1B134101338; Sat, 27 Oct 2018 18:16:20 -0400 (EDT) From: Daniel Santos To: openwrt-devel@lists.openwrt.org, Felix Fietkau Date: Sat, 27 Oct 2018 17:15:47 -0500 Message-Id: <20181027221547.25667-1-daniel.santos@pobox.com> X-Mailer: git-send-email 2.16.4 X-Pobox-Relay-ID: EE6E694E-DA35-11E8-B389-BFB3E64BB12D-06139138!pb-smtp2.pobox.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181027_151636_678332_E613FF3A X-CRM114-Status: GOOD ( 11.69 ) X-Spam-Score: -0.8 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.8 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [64.147.108.71 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [OpenWrt-Devel] [PATCH] kernel: revert evil EVIL module stripping patches X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Santos MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Don't ever EVER do this! It has taken me several hours to discover the underlying cause of my modules being mysteriously stripped, despite having made certain CONFIG_MODULE_STRIP was not enabled. This is a truely horrendous and dispicable way to strip modules. First of all, it is insideious and activates any time you aren't profiling. Second, it also brakes kmemleak. Never go behind the back of the programmer / admin / hacker and do things like this without their permission. In Free and Open Source Software, we do not force things to happen that the user has not elected to have done. If you really want excessive stripping for that extra 4k, then add a distinct option to remove all symbols. --- .../generic/hack-4.14/202-reduce_module_size.patch | 24 ---------------------- .../generic/hack-4.9/202-reduce_module_size.patch | 24 ---------------------- 2 files changed, 48 deletions(-) delete mode 100644 target/linux/generic/hack-4.14/202-reduce_module_size.patch delete mode 100644 target/linux/generic/hack-4.9/202-reduce_module_size.patch diff --git a/target/linux/generic/hack-4.14/202-reduce_module_size.patch b/target/linux/generic/hack-4.14/202-reduce_module_size.patch deleted file mode 100644 index 2cbb6add9a..0000000000 --- a/target/linux/generic/hack-4.14/202-reduce_module_size.patch +++ /dev/null @@ -1,24 +0,0 @@ -From fd66884da2f96d2a7ea73f58b1b86251b959a913 Mon Sep 17 00:00:00 2001 -From: Felix Fietkau -Date: Fri, 7 Jul 2017 16:56:19 +0200 -Subject: kernel: strip unnecessary symbol table information from kernel modules - -reduces default squashfs size on ar71xx by about 4k - -lede-commit: 058d331a39077f159ca8922f1f422a1346d6aa67 -Signed-off-by: Felix Fietkau ---- - Makefile | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - ---- a/Makefile -+++ b/Makefile -@@ -425,7 +425,7 @@ KBUILD_AFLAGS_KERNEL := - KBUILD_CFLAGS_KERNEL := - KBUILD_AFLAGS_MODULE := -DMODULE - KBUILD_CFLAGS_MODULE := -DMODULE --KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds -+KBUILD_LDFLAGS_MODULE = -T $(srctree)/scripts/module-common.lds $(if $(CONFIG_PROFILING),,-s) - GCC_PLUGINS_CFLAGS := - - export ARCH SRCARCH SUBARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD diff --git a/target/linux/generic/hack-4.9/202-reduce_module_size.patch b/target/linux/generic/hack-4.9/202-reduce_module_size.patch deleted file mode 100644 index f744b945fe..0000000000 --- a/target/linux/generic/hack-4.9/202-reduce_module_size.patch +++ /dev/null @@ -1,24 +0,0 @@ -From fd66884da2f96d2a7ea73f58b1b86251b959a913 Mon Sep 17 00:00:00 2001 -From: Felix Fietkau -Date: Fri, 7 Jul 2017 16:56:19 +0200 -Subject: kernel: strip unnecessary symbol table information from kernel modules - -reduces default squashfs size on ar71xx by about 4k - -lede-commit: 058d331a39077f159ca8922f1f422a1346d6aa67 -Signed-off-by: Felix Fietkau ---- - Makefile | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - ---- a/Makefile -+++ b/Makefile -@@ -403,7 +403,7 @@ KBUILD_AFLAGS_KERNEL := - KBUILD_CFLAGS_KERNEL := - KBUILD_AFLAGS_MODULE := -DMODULE - KBUILD_CFLAGS_MODULE := -DMODULE --KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds -+KBUILD_LDFLAGS_MODULE = -T $(srctree)/scripts/module-common.lds $(if $(CONFIG_PROFILING),,-s) - GCC_PLUGINS_CFLAGS := - - # Read KERNELRELEASE from include/config/kernel.release (if it exists)