| Message ID | 20180518083934.1436431-2-dwmw2@infradead.org |
|---|---|
| State | Superseded |
| Delegated to: | Kevin Darbyshire-Bryant |
| Headers | show |
| Series | [OpenWrt-Devel,1/2] hostapd: fix IEEE 802.11r (fast roaming) defaults | expand |
On Fri, 2018-05-18 at 09:39 +0100, David Woodhouse wrote: > With so many devices having dual 2.4GHz + 5GHz radios, this isn't a > particularly esoteric use case any more. Luci offers it by default too, > with no check for whether wpad is actually going to do it or not AFAICT. I was wrong about luci; it *does* check, but the launch script still puts the options in the wpad config file if they're in the uci config, even when luci wasn't displaying them. It's still a much more common thing than it used to be though, and relatively small: > On my test build the size increase is relatively modest: > text data bss dec hex filename > 425067 2704 356 428127 6885f wpad-mini > 452003 2684 372 455059 6f193 wpad-mini+11r > 717339 2796 588 720723 aff53 wpad-full > > Let's just enable it by default. I can get that down even further by turning on lto: 437615 2496 372 440483 6b8a3 wpad-mini-11r-lto
diff --git a/package/network/services/hostapd/files/hostapd-mini.config b/package/network/services/hostapd/files/hostapd-mini.config index 661983a94b..b15116fbbe 100644 --- a/package/network/services/hostapd/files/hostapd-mini.config +++ b/package/network/services/hostapd/files/hostapd-mini.config @@ -142,7 +142,7 @@ CONFIG_PEERKEY=y #CONFIG_IPV6=y # IEEE Std 802.11r-2008 (Fast BSS Transition) -#CONFIG_IEEE80211R=y +CONFIG_IEEE80211R=y # Use the hostapd's IEEE 802.11 authentication (ACL), but without # the IEEE 802.11 Management capability (e.g., FreeBSD/net80211)
With so many devices having dual 2.4GHz + 5GHz radios, this isn't a particularly esoteric use case any more. Luci offers it by default too, with no check for whether wpad is actually going to do it or not AFAICT. On my test build the size increase is relatively modest: text data bss dec hex filename 425067 2704 356 428127 6885f wpad-mini 452003 2684 372 455059 6f193 wpad-mini+11r 717339 2796 588 720723 aff53 wpad-full Let's just enable it by default. Signed-off-by: David Woodhouse <dwmw2@infradead.org> --- package/network/services/hostapd/files/hostapd-mini.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)