From patchwork Thu Feb 18 21:51:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Cieslakiewicz X-Patchwork-Id: 584955 X-Patchwork-Delegate: nbd@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 282A0140321 for ; Fri, 19 Feb 2016 08:53:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=wp.pl header.i=@wp.pl header.b=SLh161kN; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 23FA028C685; Thu, 18 Feb 2016 22:53:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 5299128C656 for ; Thu, 18 Feb 2016 22:52:43 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .wp. - helo: .mx3. - helo-domain: .mx3.) FROM/MX_MATCHES_NOT_HELO(DOMAIN)=1; rate: -5.5 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.10]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 18 Feb 2016 22:52:38 +0100 (CET) Received: (wp-smtpd smtp.wp.pl 14890 invoked from network); 18 Feb 2016 22:52:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1455832359; bh=lP4v9wuOoj9kMjPai9Xmca0GvXebK++/6dzapY/nzdA=; h=From:To:Cc:Subject; b=SLh161kNwYOYlFtUMQlhmoDFZBAQEC0h92eqAM4eRaYnKQSP3+KKRrub6OGZirh+j uQtkrmO0wtrRkkC/8h6l0Ro/npD10cUX4pu2J7xapVN8h07IMQIWDDfeTPJaOWdOAk UyZ9G2BR7VS6h9LuCryXNhaD18BEkikIE4EkStHw= Received: from 89-71-140-12.dynamic.chello.pl (HELO kosmio) (michal.cieslakiewicz@[89.71.140.12]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 18 Feb 2016 22:52:39 +0100 Date: Thu, 18 Feb 2016 22:51:35 +0100 From: Michal To: Hartmut Knaack Message-ID: <20160218225135.251bfc80@kosmio> In-Reply-To: <56AFEA0C.8050109@gmx.de> References: <56a01420c5aba5.36587961@wp.pl> <56A2C125.1090505@gmx.de> <20160127010415.7bcf7198@kosmio> <20160127014453.55bc5603@kosmio> <56AD06ED.6080502@gmx.de> <20160201230314.47610def@kosmio> <56AFEA0C.8050109@gmx.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-WP-MailID: 7381cc250d7df14629f6c520f7181bf2 X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [ofMk] Cc: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH v5 8/8] ar71xx: WNR2000v3: enable control of all LEDs and buttons X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" From: Michal Cieslakiewicz Subject: [PATCH v5 8/8] ar71xx: WNR2000v3: enable control of all LEDs and buttons This patch provides full GPIO support for WNR2000v3 (LEDs and buttons). It exposes all LEDs to operating system, including Ethernet ones. Signed-off-by: Michal Cieslakiewicz --- Changes: * no new functionality or fixes - only adjustments since new version of preceding patch in set ([PATCH v5 7/8] ar71xx: WNR2000v3: fix for random WLAN MAC) changed mach-wnr2000-v3.c source file target/linux/ar71xx/base-files/etc/board.d/01_leds | 14 +++ target/linux/ar71xx/base-files/etc/diag.sh | 1 + .../ar71xx/files/arch/mips/ath79/mach-wnr2000-v3.c | 138 +++++++++++++++++++-- 3 files changed, 143 insertions(+), 10 deletions(-) diff --git a/target/linux/ar71xx/base-files/etc/board.d/01_leds b/target/linux/ar71xx/base-files/etc/board.d/01_leds index 151eac2..7374422 100755 --- a/target/linux/ar71xx/base-files/etc/board.d/01_leds +++ b/target/linux/ar71xx/base-files/etc/board.d/01_leds @@ -676,6 +676,20 @@ wlae-ag300n) ucidef_set_led_netdev "wireless" "WIRELESS" "buffalo:green:wireless" "wlan0" ;; +wnr2000-v3) + ucidef_set_led_netdev "wan-amber" "WAN (amber)" "netgear:amber:wan" "eth0" + ucidef_set_led_default "wan-green" "WAN (green)" "netgear:green:wan" "0" + ucidef_set_led_netdev "wlan" "WLAN" "netgear:blue:wlan" "wlan0" + ucidef_set_led_switch "lan1green" "LAN1 (green)" "netgear:green:lan1" "switch0" "0x02" + ucidef_set_led_switch "lan2green" "LAN2 (green)" "netgear:green:lan2" "switch0" "0x04" + ucidef_set_led_switch "lan3green" "LAN3 (green)" "netgear:green:lan3" "switch0" "0x08" + ucidef_set_led_switch "lan4green" "LAN4 (green)" "netgear:green:lan4" "switch0" "0x10" + ucidef_set_led_default "lan1amber" "LAN1 (amber)" "netgear:amber:lan1" "0" + ucidef_set_led_default "lan2amber" "LAN2 (amber)" "netgear:amber:lan2" "0" + ucidef_set_led_default "lan3amber" "LAN3 (amber)" "netgear:amber:lan3" "0" + ucidef_set_led_default "lan4amber" "LAN4 (amber)" "netgear:amber:lan4" "0" + ;; + wnr2000-v4) ucidef_set_led_netdev "wan" "WAN" "netgear:green:wan" "eth0" ucidef_set_led_netdev "wlan" "WLAN" "netgear:blue:wlan" "wlan0" diff --git a/target/linux/ar71xx/base-files/etc/diag.sh b/target/linux/ar71xx/base-files/etc/diag.sh index c0e73ad..4ee40f7 100644 --- a/target/linux/ar71xx/base-files/etc/diag.sh +++ b/target/linux/ar71xx/base-files/etc/diag.sh @@ -368,6 +368,7 @@ get_status_led() { wndr3700v4 | \ wndr4300 | \ wnr2000 | \ + wnr2000-v3 |\ wnr2200 |\ wnr612-v2 |\ wnr1000-v2 |\ diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v3.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v3.c index 59d10a9..31eb079 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v3.c +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v3.c @@ -15,6 +15,7 @@ #include #include #include /* for max() macro */ +#include /* PLATFORM_DEVID_AUTO is defined here */ #include #include /* needed to disable switch LEDs */ @@ -27,11 +28,26 @@ #include "dev-m25p80.h" #include "machtypes.h" +/* WNR2000v3 - connected through AR7241 */ #define WNR2000V3_GPIO_LED_WAN_GREEN 0 #define WNR2000V3_GPIO_LED_LAN1_AMBER 1 -#define WNR2000V3_GPIO_LED_LAN4_AMBER 12 -#define WNR2000V3_GPIO_LED_PWR_GREEN 14 +#define WNR2000V3_GPIO_LED_LAN2_AMBER 6 +#define WNR2000V3_GPIO_LED_WPS_GREEN 7 +#define WNR2000V3_GPIO_LED_LAN3_AMBER 8 #define WNR2000V3_GPIO_BTN_WPS 11 +#define WNR2000V3_GPIO_LED_LAN4_AMBER 12 +#define WNR2000V3_GPIO_LED_LAN1_GREEN 13 +#define WNR2000V3_GPIO_LED_LAN2_GREEN 14 +#define WNR2000V3_GPIO_LED_LAN3_GREEN 15 +#define WNR2000V3_GPIO_LED_LAN4_GREEN 16 +#define WNR2000V3_GPIO_LED_WAN_AMBER 17 + +/* WNR2000v3 - connected through AR9287 */ +#define WNR2000V3_GPIO_WMAC_LED_WLAN_BLUE 1 +#define WNR2000V3_GPIO_WMAC_LED_TEST_AMBER 2 +#define WNR2000V3_GPIO_WMAC_LED_POWER_GREEN 3 +#define WNR2000V3_GPIO_WMAC_BTN_RESET 8 +#define WNR2000V3_GPIO_WMAC_BTN_RFKILL 9 #define WNR612V2_GPIO_LED_PWR_GREEN 11 @@ -71,16 +87,67 @@ static struct gpio_led wnr2000v3_leds_gpio[] __initdata = { { - .name = "wnr2000v3:green:power", - .gpio = WNR2000V3_GPIO_LED_PWR_GREEN, + .name = "netgear:green:wan", + .gpio = WNR2000V3_GPIO_LED_WAN_GREEN, .active_low = 1, }, { - .name = "wnr2000v3:green:wan", - .gpio = WNR2000V3_GPIO_LED_WAN_GREEN, + .name = "netgear:amber:lan1", + .gpio = WNR2000V3_GPIO_LED_LAN1_AMBER, + .active_low = 1, + }, { + .name = "netgear:amber:lan2", + .gpio = WNR2000V3_GPIO_LED_LAN2_AMBER, + .active_low = 1, + }, { + .name = "netgear:amber:lan3", + .gpio = WNR2000V3_GPIO_LED_LAN3_AMBER, + .active_low = 1, + }, { + .name = "netgear:amber:lan4", + .gpio = WNR2000V3_GPIO_LED_LAN4_AMBER, + .active_low = 1, + }, { + .name = "netgear:green:wps", + .gpio = WNR2000V3_GPIO_LED_WPS_GREEN, + .active_low = 1, + }, { + .name = "netgear:green:lan1", + .gpio = WNR2000V3_GPIO_LED_LAN1_GREEN, + .active_low = 1, + }, { + .name = "netgear:green:lan2", + .gpio = WNR2000V3_GPIO_LED_LAN2_GREEN, + .active_low = 1, + }, { + .name = "netgear:green:lan3", + .gpio = WNR2000V3_GPIO_LED_LAN3_GREEN, + .active_low = 1, + }, { + .name = "netgear:green:lan4", + .gpio = WNR2000V3_GPIO_LED_LAN4_GREEN, + .active_low = 1, + }, { + .name = "netgear:amber:wan", + .gpio = WNR2000V3_GPIO_LED_WAN_AMBER, .active_low = 1, } }; +static struct gpio_led wnr2000v3_wmac_leds_gpio[] = { + { + .name = "netgear:green:power", + .gpio = WNR2000V3_GPIO_WMAC_LED_POWER_GREEN, + .active_low = 1, + .default_state = LEDS_GPIO_DEFSTATE_ON, + }, { + .name = "netgear:amber:test", + .gpio = WNR2000V3_GPIO_WMAC_LED_TEST_AMBER, + .active_low = 1, + } +}; + +static const char *wnr2000v3_wmac_led_name = "netgear:blue:wlan"; + static struct gpio_led wnr612v2_leds_gpio[] __initdata = { { .name = "netgear:green:power", @@ -173,13 +240,32 @@ static struct gpio_led wpn824n_wmac_leds_gpio[] = { } }; -static struct gpio_keys_button wnr2000v3_gpio_keys[] __initdata = { +static struct gpio_keys_button wnr2000v3_keys_gpio[] __initdata = { { .desc = "wps", .type = EV_KEY, .code = KEY_WPS_BUTTON, .debounce_interval = WNR2000V3_KEYS_DEBOUNCE_INTERVAL, .gpio = WNR2000V3_GPIO_BTN_WPS, + .active_low = 1, + } +}; + +static struct gpio_keys_button wnr2000v3_wmac_keys_gpio[] = { + { + .desc = "reset", + .type = EV_KEY, + .code = KEY_RESTART, + .debounce_interval = WNR2000V3_KEYS_DEBOUNCE_INTERVAL, + .gpio = WNR2000V3_GPIO_WMAC_BTN_RESET, + .active_low = 1, + }, { + .desc = "rfkill", + .type = EV_KEY, + .code = KEY_RFKILL, + .debounce_interval = WNR2000V3_KEYS_DEBOUNCE_INTERVAL, + .gpio = WNR2000V3_GPIO_WMAC_BTN_RFKILL, + .active_low = 1, } }; @@ -237,6 +323,26 @@ static void __init wnr2000v3_setup(void) { u8 wlan_mac_addr[6]; + /* + * Disable JTAG to use all AR724X GPIO LEDs. + * Also disable CLKs and bit 20 as u-boot does. + * Finally, allow OS to control all link LEDs. + */ + ath79_gpio_function_setup(AR724X_GPIO_FUNC_JTAG_DISABLE | + AR724X_GPIO_FUNC_UART_EN, + AR724X_GPIO_FUNC_CLK_OBS1_EN | + AR724X_GPIO_FUNC_CLK_OBS2_EN | + AR724X_GPIO_FUNC_CLK_OBS3_EN | + AR724X_GPIO_FUNC_CLK_OBS4_EN | + AR724X_GPIO_FUNC_CLK_OBS5_EN | + AR724X_GPIO_FUNC_GE0_MII_CLK_EN | + AR724X_GPIO_FUNC_ETH_SWITCH_LED0_EN | + AR724X_GPIO_FUNC_ETH_SWITCH_LED1_EN | + AR724X_GPIO_FUNC_ETH_SWITCH_LED2_EN | + AR724X_GPIO_FUNC_ETH_SWITCH_LED3_EN | + AR724X_GPIO_FUNC_ETH_SWITCH_LED4_EN | + BIT(20)); + wnr_get_wmac(wlan_mac_addr, WNR2000V3_MAC0_OFFSET, WNR2000V3_MAC1_OFFSET, WNR2000V3_WMAC_OFFSET); @@ -245,9 +351,21 @@ static void __init wnr2000v3_setup(void) ath79_register_leds_gpio(-1, ARRAY_SIZE(wnr2000v3_leds_gpio), wnr2000v3_leds_gpio); - ath79_register_gpio_keys_polled(-1, WNR2000V3_KEYS_POLL_INTERVAL, - ARRAY_SIZE(wnr2000v3_gpio_keys), - wnr2000v3_gpio_keys); + /* Do not use id=-1, we can have more GPIO key-polled devices */ + ath79_register_gpio_keys_polled(PLATFORM_DEVID_AUTO, + WNR2000V3_KEYS_POLL_INTERVAL, + ARRAY_SIZE(wnr2000v3_keys_gpio), + wnr2000v3_keys_gpio); + + ap9x_pci_setup_wmac_led_pin(0, WNR2000V3_GPIO_WMAC_LED_WLAN_BLUE); + ap9x_pci_setup_wmac_led_name(0, wnr2000v3_wmac_led_name); + + ap9x_pci_setup_wmac_leds(0, wnr2000v3_wmac_leds_gpio, + ARRAY_SIZE(wnr2000v3_wmac_leds_gpio)); + + ap9x_pci_setup_wmac_btns(0, wnr2000v3_wmac_keys_gpio, + ARRAY_SIZE(wnr2000v3_wmac_keys_gpio), + WNR2000V3_KEYS_POLL_INTERVAL); } MIPS_MACHINE(ATH79_MACH_WNR2000_V3, "WNR2000V3", "NETGEAR WNR2000 V3", wnr2000v3_setup);