diff mbox

[OpenWrt-Devel,ar71xx] Send power to USB port on WNR2200

Message ID 20151010134412.710310973f4985713c7fbdd2@bitmessage.ch
State Accepted
Headers show

Commit Message

Riley Baird Oct. 10, 2015, 2:44 a.m. UTC
This patch fixes ticket #15267 by enabling power on the
WNR2200's USB port. At present, the USB port on the WNR2200
is non-functional due to it not receiving power.

This patch defines an additional GPIO pin, but none of the
current GPIO definitions have been modified.

Signed-off-by: Riley Baird <BM-2cVqnDuYbAU5do2DfJTrN7ZbAJ246S4XiX at bitmessage.ch>
----

Comments

John Crispin Oct. 11, 2015, 12:50 p.m. UTC | #1
comments inline

On 10/10/2015 04:44, Riley Baird wrote:
> This patch fixes ticket #15267 by enabling power on the
> WNR2200's USB port. At present, the USB port on the WNR2200
> is non-functional due to it not receiving power.
> 
> This patch defines an additional GPIO pin, but none of the
> current GPIO definitions have been modified.
> 
> Signed-off-by: Riley Baird <BM-2cVqnDuYbAU5do2DfJTrN7ZbAJ246S4XiX at bitmessage.ch>
> ----
> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
> index bf7f9ee..a1de26a 100644
> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
> @@ -36,7 +36,7 @@
>  #define WNR2200_GPIO_LED_LAN4_GREEN	16
>  #define WNR2200_GPIO_LED_PWR_AMBER	21
>  #define WNR2200_GPIO_LED_PWR_GREEN	22
> -
> +#define WNR2200_GPIO_USB_5V		4
>  #define WNR2200_GPIO_USB_POWER		24
>  
>  #define WNR2200_KEYS_POLL_INTERVAL	20 /* msecs */
> @@ -127,9 +127,9 @@ static void __init wnr2200_setup(void)
>  					wnr2200_leds_gpio);
>  
>  	/* enable power for the USB port */
> -	gpio_request_one(WNR2200_GPIO_USB_POWER,
> -			GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED,
> -			"USB power");

was gpio24 just wrong or are there 2 pins for whatever reason ?

	John


> +	ap9x_pci_setup_wmac_gpio(0,
> +		BIT(WNR2200_GPIO_USB_5V),
> +		BIT(WNR2200_GPIO_USB_5V));
>  
>  	ath79_register_usb();
>  }
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
diff mbox

Patch

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
index bf7f9ee..a1de26a 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c
@@ -36,7 +36,7 @@ 
 #define WNR2200_GPIO_LED_LAN4_GREEN	16
 #define WNR2200_GPIO_LED_PWR_AMBER	21
 #define WNR2200_GPIO_LED_PWR_GREEN	22
-
+#define WNR2200_GPIO_USB_5V		4
 #define WNR2200_GPIO_USB_POWER		24
 
 #define WNR2200_KEYS_POLL_INTERVAL	20 /* msecs */
@@ -127,9 +127,9 @@  static void __init wnr2200_setup(void)
 					wnr2200_leds_gpio);
 
 	/* enable power for the USB port */
-	gpio_request_one(WNR2200_GPIO_USB_POWER,
-			GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED,
-			"USB power");
+	ap9x_pci_setup_wmac_gpio(0,
+		BIT(WNR2200_GPIO_USB_5V),
+		BIT(WNR2200_GPIO_USB_5V));
 
 	ath79_register_usb();
 }