From patchwork Mon Jan 5 14:58:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Weber X-Patchwork-Id: 425353 X-Patchwork-Delegate: jow@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CD52E14007F for ; Tue, 6 Jan 2015 01:59:16 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id E84D028C603; Mon, 5 Jan 2015 15:56:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id BBDF728C604 for ; Mon, 5 Jan 2015 15:56:34 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-qg0-f44.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -8.5 Received: from mail-qg0-f44.google.com (mail-qg0-f44.google.com [209.85.192.44]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Mon, 5 Jan 2015 15:56:33 +0100 (CET) Received: by mail-qg0-f44.google.com with SMTP id q107so15469804qgd.31 for ; Mon, 05 Jan 2015 06:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=PEAFojjjO33dLbKFQZGPCqmWVStgd4XkcHlYXzeJaqA=; b=fz4cQeaGGXYY9xn2pqvbGylSw0NFhlOhav7ztFumpP0xOJP+x+fGQMTaPnuHr1L6O7 j1NflLXF/J6zWIE/+xTYHpD/KJDFlmLAChbqu84TrueDeOrlRgWsRY6NEOh/FHyX+ZTH Wiqqjg623cum7ZU7alHDVfqpm/ZhYiSMZtK5FAHMkxSgZSoe+55npDMDKuOLC5c2EAGl oozXJwMzgeGTvAD5iCurrbVoPNmvN9Z7o+3upKtEqByJ334nQdBTIMmzMt+zWYzqYqDv 7TXLEn99wgOaElMvC9gRwuzUd/shENTAkeuebQCe/nOwDOMUNYJACPu39SsG7aMaz3zE 0Vvg== X-Received: by 10.224.79.212 with SMTP id q20mr145760557qak.4.1420469919154; Mon, 05 Jan 2015 06:58:39 -0800 (PST) Received: from gir (HSI-KBW-217-008-059-040.hsi.kabelbw.de. [217.8.59.40]) by mx.google.com with ESMTPSA id 9sm50899837qam.9.2015.01.05.06.58.37 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 05 Jan 2015 06:58:38 -0800 (PST) From: Ulrich Weber X-Google-Original-From: Ulrich Weber Date: Mon, 5 Jan 2015 15:58:34 +0100 To: jow@openwrt.org Message-ID: <20150105145834.GA9004@gir> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH] firewall3: fix left shift on 64 bit systems in fw3_bitlen2netmask X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" otherwise 0.0.0.0/0 is set as 0.0.0.0/255.255.255.255 on x86_64 Signed-off-by: Ulrich Weber --- utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils.c b/utils.c index 71a0f13..b2fbe02 100644 --- a/utils.c +++ b/utils.c @@ -803,7 +803,7 @@ fw3_bitlen2netmask(int family, int bits, void *mask) return false; v4 = mask; - v4->s_addr = htonl(~((1 << (32 - abs(bits))) - 1)); + v4->s_addr = bits ? htonl(~((1 << (32 - abs(bits))) - 1)) : 0; if (bits < 0) v4->s_addr = ~v4->s_addr;