From patchwork Fri Dec 12 22:59:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 420710 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 386EF14009B for ; Sat, 13 Dec 2014 09:58:30 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 2202528A5FF; Fri, 12 Dec 2014 23:56:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id EC712280419 for ; Fri, 12 Dec 2014 23:56:30 +0100 (CET) X-policyd-weight: using cached result; rate:hard: -7.6 Received: from fudo.makrotopia.org (fudo.makrotopia.org [5.135.190.93]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Fri, 12 Dec 2014 23:56:30 +0100 (CET) Received: from local by fudo.makrotopia.org with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1XzZA8-0001ca-Tq; Fri, 12 Dec 2014 23:58:17 +0100 Date: Fri, 12 Dec 2014 23:59:12 +0100 From: Daniel Golle To: openwrt-devel@lists.openwrt.org Message-ID: <20141212225906.GA7534@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Luka Perkov Subject: [OpenWrt-Devel] [PATCH] uboot-envtools: enable UBI support on non-legacy targets X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" We've been carrying around that patch for a while now and didn't ever encounter any problem on non-UBI flashtypes. So I guess the 8kB extra space won't hurt on modern platforms which might even make use of their U-Boot environment being stored in UBI. Let me know if there are any targets missing in the blacklist (i.e. platforms/SoCs without the option to deploy NAND flash or commonly found with only 4MB flash where those 8kB might actually matter, or platforms where we haven't got U-Boot, ...) Signed-off-by: Daniel Golle --- package/boot/uboot-envtools/Config.in | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/package/boot/uboot-envtools/Config.in b/package/boot/uboot-envtools/Config.in index 9fd8103..10c03f9 100644 --- a/package/boot/uboot-envtools/Config.in +++ b/package/boot/uboot-envtools/Config.in @@ -1,7 +1,13 @@ config UBOOT_ENVTOOLS_UBI bool "Support environment in UBI volume" depends on PACKAGE_uboot-envtools - default n + depends on !TARGET_adm5120 && !TARGET_adm8668 && !TARGET_ar7 && \ + !TARGET_ar71xx_generic && !TARGET_atheros && \ + !TARGET_au1000 && !TARGET_avr32 && !TARGET_ramips_rt288x && \ + !TARGET_ramips_rt305x && !TARGET_uml && !TARGET_x86 && \ + !TARGET_x86_64 + + default y help Add support for reading and writing U-Boot environment stored in UBI volume(s).