diff mbox

[OpenWrt-Devel] lantiq: Change the xbar register range to match the datasheet

Message ID 1452520292-20943-1-git-send-email-martin.blumenstingl@googlemail.com
State Changes Requested
Headers show

Commit Message

Martin Blumenstingl Jan. 11, 2016, 1:51 p.m. UTC
According to the datasheet says that the xbar register range is
0x1F400000-0x1F400FFF. Thanks to John Crispin for looking it up.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 target/linux/lantiq/dts/vr9.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Crispin Jan. 11, 2016, 1:59 p.m. UTC | #1
On 11/01/2016 14:51, Martin Blumenstingl wrote:
> According to the datasheet says that the xbar register range is
> 0x1F400000-0x1F400FFF. Thanks to John Crispin for looking it up.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  target/linux/lantiq/dts/vr9.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/lantiq/dts/vr9.dtsi b/target/linux/lantiq/dts/vr9.dtsi
> index df63ce7..927a54a 100644
> --- a/target/linux/lantiq/dts/vr9.dtsi
> +++ b/target/linux/lantiq/dts/vr9.dtsi
> @@ -78,7 +78,7 @@
>  
>  		xbar0: xbar@400000 {
>  			compatible = "lantiq,xbar-xway";
> -			reg = <0x400000 0x1000>;
> +			reg = <0x400000 0xfff>;

0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having
a off-by-one thinko ...
Martin Blumenstingl Jan. 11, 2016, 2:15 p.m. UTC | #2
On Mon, Jan 11, 2016 at 2:59 PM, John Crispin <blogic@openwrt.org> wrote:
> 0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having
> a off-by-one thinko ...
...and I think you are right!
Sorry for the noise, please drop this patch.
John Crispin Jan. 11, 2016, 2:42 p.m. UTC | #3
On 11/01/2016 15:15, Martin Blumenstingl wrote:
> On Mon, Jan 11, 2016 at 2:59 PM, John Crispin <blogic@openwrt.org> wrote:
>> 0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having
>> a off-by-one thinko ...
> ...and I think you are right!
> Sorry for the noise, please drop this patch.
> 

heh, i had one of those last week that cost me 4 hours ;)
diff mbox

Patch

diff --git a/target/linux/lantiq/dts/vr9.dtsi b/target/linux/lantiq/dts/vr9.dtsi
index df63ce7..927a54a 100644
--- a/target/linux/lantiq/dts/vr9.dtsi
+++ b/target/linux/lantiq/dts/vr9.dtsi
@@ -78,7 +78,7 @@ 
 
 		xbar0: xbar@400000 {
 			compatible = "lantiq,xbar-xway";
-			reg = <0x400000 0x1000>;
+			reg = <0x400000 0xfff>;
 		};
 	};