Message ID | 1452520292-20943-1-git-send-email-martin.blumenstingl@googlemail.com |
---|---|
State | Changes Requested |
Headers | show |
On 11/01/2016 14:51, Martin Blumenstingl wrote: > According to the datasheet says that the xbar register range is > 0x1F400000-0x1F400FFF. Thanks to John Crispin for looking it up. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > target/linux/lantiq/dts/vr9.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/lantiq/dts/vr9.dtsi b/target/linux/lantiq/dts/vr9.dtsi > index df63ce7..927a54a 100644 > --- a/target/linux/lantiq/dts/vr9.dtsi > +++ b/target/linux/lantiq/dts/vr9.dtsi > @@ -78,7 +78,7 @@ > > xbar0: xbar@400000 { > compatible = "lantiq,xbar-xway"; > - reg = <0x400000 0x1000>; > + reg = <0x400000 0xfff>; 0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having a off-by-one thinko ...
On Mon, Jan 11, 2016 at 2:59 PM, John Crispin <blogic@openwrt.org> wrote: > 0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having > a off-by-one thinko ... ...and I think you are right! Sorry for the noise, please drop this patch.
On 11/01/2016 15:15, Martin Blumenstingl wrote: > On Mon, Jan 11, 2016 at 2:59 PM, John Crispin <blogic@openwrt.org> wrote: >> 0x1F400000-0x1F400FFF means that its size is 0x1000. i think you having >> a off-by-one thinko ... > ...and I think you are right! > Sorry for the noise, please drop this patch. > heh, i had one of those last week that cost me 4 hours ;)
diff --git a/target/linux/lantiq/dts/vr9.dtsi b/target/linux/lantiq/dts/vr9.dtsi index df63ce7..927a54a 100644 --- a/target/linux/lantiq/dts/vr9.dtsi +++ b/target/linux/lantiq/dts/vr9.dtsi @@ -78,7 +78,7 @@ xbar0: xbar@400000 { compatible = "lantiq,xbar-xway"; - reg = <0x400000 0x1000>; + reg = <0x400000 0xfff>; }; };
According to the datasheet says that the xbar register range is 0x1F400000-0x1F400FFF. Thanks to John Crispin for looking it up. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- target/linux/lantiq/dts/vr9.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)