diff mbox

[OpenWrt-Devel] brcm2708: fix RPi model B plus support

Message ID 1452381199-905-1-git-send-email-roman@advem.lv
State Accepted
Headers show

Commit Message

Roman Yeryomin Jan. 9, 2016, 11:13 p.m. UTC
Not sure if B+ is used or not (mine has B Plus) so leave both

Signed-off-by: Roman Yeryomin <roman@advem.lv>
---
 target/linux/brcm2708/base-files/lib/brcm2708.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Felix Fietkau Jan. 17, 2016, 11:15 a.m. UTC | #1
On 2016-01-10 00:13, Roman Yeryomin wrote:
> Not sure if B+ is used or not (mine has B Plus) so leave both
> 
> Signed-off-by: Roman Yeryomin <roman@advem.lv>
> ---
>  target/linux/brcm2708/base-files/lib/brcm2708.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/linux/brcm2708/base-files/lib/brcm2708.sh b/target/linux/brcm2708/base-files/lib/brcm2708.sh
> index 13c1aa9..cb4089d 100644
> --- a/target/linux/brcm2708/base-files/lib/brcm2708.sh
> +++ b/target/linux/brcm2708/base-files/lib/brcm2708.sh
> @@ -11,6 +11,7 @@ brcm2708_detect() {
>  	"Raspberry Pi Model B Rev"*)
>  		board_name="rpi-b"
>  		;;
> +	"Raspberry Pi Model B Plus Rev"* |\
>  	"Raspberry Pi Model B+ Rev"*)
Why would it have "B Plus" instead of "B+"? I only see "B+" in the
kernel .dts file.

- Felix
Álvaro Fernández Rojas Jan. 17, 2016, 11:22 a.m. UTC | #2
I think it's the firmware the one replacing the model name, since it 
also adds the revision to it...
I don't really know why the firmware does that...

El 17/01/2016 a las 12:15, Felix Fietkau escribió:
> On 2016-01-10 00:13, Roman Yeryomin wrote:
>> Not sure if B+ is used or not (mine has B Plus) so leave both
>>
>> Signed-off-by: Roman Yeryomin <roman@advem.lv>
>> ---
>>   target/linux/brcm2708/base-files/lib/brcm2708.sh | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/target/linux/brcm2708/base-files/lib/brcm2708.sh b/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> index 13c1aa9..cb4089d 100644
>> --- a/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> +++ b/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> @@ -11,6 +11,7 @@ brcm2708_detect() {
>>   	"Raspberry Pi Model B Rev"*)
>>   		board_name="rpi-b"
>>   		;;
>> +	"Raspberry Pi Model B Plus Rev"* |\
>>   	"Raspberry Pi Model B+ Rev"*)
> Why would it have "B Plus" instead of "B+"? I only see "B+" in the
> kernel .dts file.
>
> - Felix
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Roman Yeryomin Jan. 17, 2016, 5:51 p.m. UTC | #3
On 17 January 2016 at 13:15, Felix Fietkau <nbd@openwrt.org> wrote:
> On 2016-01-10 00:13, Roman Yeryomin wrote:
>> Not sure if B+ is used or not (mine has B Plus) so leave both
>>
>> Signed-off-by: Roman Yeryomin <roman@advem.lv>
>> ---
>>  target/linux/brcm2708/base-files/lib/brcm2708.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/target/linux/brcm2708/base-files/lib/brcm2708.sh b/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> index 13c1aa9..cb4089d 100644
>> --- a/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> +++ b/target/linux/brcm2708/base-files/lib/brcm2708.sh
>> @@ -11,6 +11,7 @@ brcm2708_detect() {
>>       "Raspberry Pi Model B Rev"*)
>>               board_name="rpi-b"
>>               ;;
>> +     "Raspberry Pi Model B Plus Rev"* |\
>>       "Raspberry Pi Model B+ Rev"*)
> Why would it have "B Plus" instead of "B+"? I only see "B+" in the
> kernel .dts file.

Didn't investigate the exact reason

Regards,
Roman
diff mbox

Patch

diff --git a/target/linux/brcm2708/base-files/lib/brcm2708.sh b/target/linux/brcm2708/base-files/lib/brcm2708.sh
index 13c1aa9..cb4089d 100644
--- a/target/linux/brcm2708/base-files/lib/brcm2708.sh
+++ b/target/linux/brcm2708/base-files/lib/brcm2708.sh
@@ -11,6 +11,7 @@  brcm2708_detect() {
 	"Raspberry Pi Model B Rev"*)
 		board_name="rpi-b"
 		;;
+	"Raspberry Pi Model B Plus Rev"* |\
 	"Raspberry Pi Model B+ Rev"*)
 		board_name="rpi-b-plus"
 		;;