| Message ID | 1451509166-5157-5-git-send-email-openwrt@kresin.me |
|---|---|
| State | Accepted |
| Headers | show |
On 30/12/2015 21:59, Mathias Kresin wrote: > According to ITU-T G.997.1 Amendment 2 (04/2013) section 2.1, bit 3 of > XTSE octet 8 either allow or denies the initialization of G.993.5. > > Even if the current redistributable xDSL firmware doesn't include > G.993.5 vectoring support, enable this bit by default to allow people to > get their G.993.5 line working using a custom xDSL firmware. > Is this the only change required to get vectoring working or do we need to do anything else ? > Signed-off-by: Mathias Kresin <openwrt@kresin.me> > --- > package/network/config/ltq-vdsl-app/files/dsl_control | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/package/network/config/ltq-vdsl-app/files/dsl_control b/package/network/config/ltq-vdsl-app/files/dsl_control > index f6275a0..fe098d7 100644 > --- a/package/network/config/ltq-vdsl-app/files/dsl_control > +++ b/package/network/config/ltq-vdsl-app/files/dsl_control > @@ -13,18 +13,21 @@ EXTRA_HELP=" status Get DSL status information > > # > # ITU-T G.997.1 (06/2012) - Section 7.3.1.1.1 (xTU transmission system enabling (XTSE)) > +# ITU-T G.997.1 Amendment 2 (04/2013) - Section 2.1 - (Vectoring mode enable (VECTORMODE_ENABLE)) > # > # G.992.1 Annex A > # G.992.3 Annex A / L-US1 / L_US-2 / M > # G.992.5 Annex A / M > # G.993.2 Annex A/B/C > -xtse_xdsl_a="04_00_04_00_4C_01_04_07" > +# G.993.5 Annex A/B/C > +xtse_xdsl_a="04_00_04_00_4C_01_04_0F" > > # G.992.1 Annex B > # G.992.3 Annex B > # G.992.5 Annex B > # G.993.2 Annex A/B/C > -xtse_adsl_b="10_00_10_00_00_04_00_07" > +# G.993.5 Annex A/B/C > +xtse_xdsl_b="10_00_10_00_00_04_00_0F" > > # G.992.1 Annex B > # G.992.3 Annex B > @@ -32,7 +35,8 @@ xtse_adsl_b="10_00_10_00_00_04_00_07" > # G.992.5 Annex B > # G.992.5 Annex J > # G.993.2 Annex A/B/C > -xtse_adsl_j="10_00_10_40_00_04_01_07" > +# G.993.5 Annex A/B/C > +xtse_xdsl_j="10_00_10_40_00_04_01_0F" > > service_triggers() { > procd_add_reload_trigger network >
Am 31.12.2015 um 10:01 schrieb John Crispin: > > > On 30/12/2015 21:59, Mathias Kresin wrote: >> According to ITU-T G.997.1 Amendment 2 (04/2013) section 2.1, bit 3 of >> XTSE octet 8 either allow or denies the initialization of G.993.5. >> >> Even if the current redistributable xDSL firmware doesn't include >> G.993.5 vectoring support, enable this bit by default to allow people to >> get their G.993.5 line working using a custom xDSL firmware. >> > > > Is this the only change required to get vectoring working or do we need > to do anything else ? It should be all. Since r47784, vectoring already works with the XTSE in auto mode[1], using a vectoring capable firmware. I can't say whether this change is really required. My vectoring test user doesn't have access to his line till mid january. According to the ITU spec the bit has to be set. But if I have a look at XTSE from the status output that was send to me the last time[2], I get the feeling that at least this particular provider doesn't use this bit. Since the bit doesn't broke my none vectoring VDSL2 line, I decided to set the bit to be conform to the specification. Mathias [1] http://paste.debian.net/hidden/04381d10/ [2] https://patchwork.ozlabs.org/patch/552876/
diff --git a/package/network/config/ltq-vdsl-app/files/dsl_control b/package/network/config/ltq-vdsl-app/files/dsl_control index f6275a0..fe098d7 100644 --- a/package/network/config/ltq-vdsl-app/files/dsl_control +++ b/package/network/config/ltq-vdsl-app/files/dsl_control @@ -13,18 +13,21 @@ EXTRA_HELP=" status Get DSL status information # # ITU-T G.997.1 (06/2012) - Section 7.3.1.1.1 (xTU transmission system enabling (XTSE)) +# ITU-T G.997.1 Amendment 2 (04/2013) - Section 2.1 - (Vectoring mode enable (VECTORMODE_ENABLE)) # # G.992.1 Annex A # G.992.3 Annex A / L-US1 / L_US-2 / M # G.992.5 Annex A / M # G.993.2 Annex A/B/C -xtse_xdsl_a="04_00_04_00_4C_01_04_07" +# G.993.5 Annex A/B/C +xtse_xdsl_a="04_00_04_00_4C_01_04_0F" # G.992.1 Annex B # G.992.3 Annex B # G.992.5 Annex B # G.993.2 Annex A/B/C -xtse_adsl_b="10_00_10_00_00_04_00_07" +# G.993.5 Annex A/B/C +xtse_xdsl_b="10_00_10_00_00_04_00_0F" # G.992.1 Annex B # G.992.3 Annex B @@ -32,7 +35,8 @@ xtse_adsl_b="10_00_10_00_00_04_00_07" # G.992.5 Annex B # G.992.5 Annex J # G.993.2 Annex A/B/C -xtse_adsl_j="10_00_10_40_00_04_01_07" +# G.993.5 Annex A/B/C +xtse_xdsl_j="10_00_10_40_00_04_01_0F" service_triggers() { procd_add_reload_trigger network
According to ITU-T G.997.1 Amendment 2 (04/2013) section 2.1, bit 3 of XTSE octet 8 either allow or denies the initialization of G.993.5. Even if the current redistributable xDSL firmware doesn't include G.993.5 vectoring support, enable this bit by default to allow people to get their G.993.5 line working using a custom xDSL firmware. Signed-off-by: Mathias Kresin <openwrt@kresin.me> --- package/network/config/ltq-vdsl-app/files/dsl_control | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)