diff mbox

[OpenWrt-Devel,4/4] lantiq: fall back to a more appropriate default dsl firmware

Message ID 1449088692-4597-4-git-send-email-a.heider@gmail.com
State Superseded
Headers show

Commit Message

Andre Heider Dec. 2, 2015, 8:38 p.m. UTC
Signed-off-by: Andre Heider <a.heider@gmail.com>
---

What I'm not sure about is annex j.
Is that using the a or b firmware or will it get its own?

 package/network/config/ltq-vdsl-app/files/dsl_control | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 package/network/config/ltq-vdsl-app/files/dsl_control

Comments

Daniel Schwierzeck Dec. 2, 2015, 9:13 p.m. UTC | #1
Am 02.12.2015 um 21:38 schrieb Andre Heider:
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
> 
> What I'm not sure about is annex j.
> Is that using the a or b firmware or will it get its own?

Annex J is only valid with B firmware. It is only additionally enabled
along with Annex B.

> 
>  package/network/config/ltq-vdsl-app/files/dsl_control | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>  mode change 100644 => 100755 package/network/config/ltq-vdsl-app/files/dsl_control
> 
> diff --git a/package/network/config/ltq-vdsl-app/files/dsl_control b/package/network/config/ltq-vdsl-app/files/dsl_control
> old mode 100644
> new mode 100755
> index d7eb4cd..48815ab
> --- a/package/network/config/ltq-vdsl-app/files/dsl_control
> +++ b/package/network/config/ltq-vdsl-app/files/dsl_control
> @@ -69,11 +69,12 @@ start_service() {
>  	eval "xtse_adsl=\"\${xtse_adsl_$annex}\""
>  	if [ "${xtse_adsl}" ]; then
>  		xtse=$xtse_adsl
> +		[ -z "${firmware}" ] && firmware=/lib/firmware/adsl-${annex}.bin
>  	else
>  		xtse=$xtse_vdsl
> +		[ -z "${firmware}" ] && firmware=/lib/firmware/vdsl.bin
>  	fi
>  
> -	[ -z "${firmware}" ] && firmware=/lib/firmware/vdsl.bin
>  	[ -f "${firmware}" ] || {
>  		echo failed to find $firmware
>  		return 1
>
Andre Heider Dec. 3, 2015, 8:09 a.m. UTC | #2
Hi,

On Wed, Dec 2, 2015 at 10:13 PM, Daniel Schwierzeck
<daniel.schwierzeck@gmail.com> wrote:
> Am 02.12.2015 um 21:38 schrieb Andre Heider:
>> What I'm not sure about is annex j.
>> Is that using the a or b firmware or will it get its own?
>
> Annex J is only valid with B firmware. It is only additionally enabled
> along with Annex B.

nice, thanks for that info, will fix the patch.

Regards,
Andre
diff mbox

Patch

diff --git a/package/network/config/ltq-vdsl-app/files/dsl_control b/package/network/config/ltq-vdsl-app/files/dsl_control
old mode 100644
new mode 100755
index d7eb4cd..48815ab
--- a/package/network/config/ltq-vdsl-app/files/dsl_control
+++ b/package/network/config/ltq-vdsl-app/files/dsl_control
@@ -69,11 +69,12 @@  start_service() {
 	eval "xtse_adsl=\"\${xtse_adsl_$annex}\""
 	if [ "${xtse_adsl}" ]; then
 		xtse=$xtse_adsl
+		[ -z "${firmware}" ] && firmware=/lib/firmware/adsl-${annex}.bin
 	else
 		xtse=$xtse_vdsl
+		[ -z "${firmware}" ] && firmware=/lib/firmware/vdsl.bin
 	fi
 
-	[ -z "${firmware}" ] && firmware=/lib/firmware/vdsl.bin
 	[ -f "${firmware}" ] || {
 		echo failed to find $firmware
 		return 1