diff mbox

[OpenWrt-Devel,procd,v3,07/17] ujail: add <stdio.h> and <syslog.h> to seccomp.h

Message ID 1448641636-42493-8-git-send-email-champetier.etienne@gmail.com
State Accepted
Headers show

Commit Message

Etienne Champetier Nov. 27, 2015, 4:27 p.m. UTC 
headers must include all there dependencies, no more, no less

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
---
 jail/preload.c | 2 --
 jail/seccomp.c | 2 --
 jail/seccomp.h | 3 +++
 3 files changed, 3 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/jail/preload.c b/jail/preload.c
index a1cc0b6..5466f27 100644
--- a/jail/preload.c
+++ b/jail/preload.c
@@ -13,12 +13,10 @@ 
 
 #define _GNU_SOURCE
 #include <sys/types.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <string.h>
 #include <dlfcn.h>
-#include <syslog.h>
 
 #include "seccomp.h"
 #include "../preload.h"
diff --git a/jail/seccomp.c b/jail/seccomp.c
index de01fc6..dcd19ec 100644
--- a/jail/seccomp.c
+++ b/jail/seccomp.c
@@ -10,11 +10,9 @@ 
  * found in the LICENSE file.
  */
 #define _GNU_SOURCE 1
-#include <stdio.h>
 #include <stddef.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <syslog.h>
 
 #include <libubox/utils.h>
 #include <libubox/blobmsg.h>
diff --git a/jail/seccomp.h b/jail/seccomp.h
index 0992b79..6032812 100644
--- a/jail/seccomp.h
+++ b/jail/seccomp.h
@@ -13,6 +13,9 @@ 
 #ifndef _JAIL_SECCOMP_H_
 #define _JAIL_SECCOMP_H_
 
+#include <stdio.h>
+#include <syslog.h>
+
 #define INFO(fmt, ...) do { \
 	syslog(LOG_INFO,"preload-seccomp: "fmt, ## __VA_ARGS__); \
 	fprintf(stderr,"preload-seccomp: "fmt, ## __VA_ARGS__); \