diff mbox

[OpenWrt-Devel] update mtd-utils to 1.5.2

Message ID 1447370416-7716-1-git-send-email-devel-sven@geroedel.de
State Changes Requested
Headers show

Commit Message

Sven Roederer Nov. 12, 2015, 11:20 p.m. UTC
- update mtd-utils to 1.5.2 (git a494d30ab1ae40cb7665680cadf5af3ca3830a73)
 - remove patches that went upstream
 - fixes build from scratch as of broken patches

just had a crash-course to git send-email ....

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
---
 tools/mtd-utils/Makefile                           |  6 ++--
 tools/mtd-utils/patches/110-portability.patch      | 21 -----------
 tools/mtd-utils/patches/137-no_extern_inline.patch | 41 ----------------------
 .../300-libfec_use_standard_unsigned_long.patch    | 35 ------------------
 4 files changed, 3 insertions(+), 100 deletions(-)
 delete mode 100644 tools/mtd-utils/patches/137-no_extern_inline.patch
 delete mode 100644 tools/mtd-utils/patches/300-libfec_use_standard_unsigned_long.patch

Comments

Hauke Mehrtens Nov. 15, 2015, 9:59 p.m. UTC | #1
On 11/13/2015 12:20 AM, Sven Roederer wrote:
>  - update mtd-utils to 1.5.2 (git a494d30ab1ae40cb7665680cadf5af3ca3830a73)
>  - remove patches that went upstream
>  - fixes build from scratch as of broken patches
> 
> just had a crash-course to git send-email ....
> 
> Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
> ---
>  tools/mtd-utils/Makefile                           |  6 ++--
>  tools/mtd-utils/patches/110-portability.patch      | 21 -----------
>  tools/mtd-utils/patches/137-no_extern_inline.patch | 41 ----------------------
>  .../300-libfec_use_standard_unsigned_long.patch    | 35 ------------------
>  4 files changed, 3 insertions(+), 100 deletions(-)
>  delete mode 100644 tools/mtd-utils/patches/137-no_extern_inline.patch
>  delete mode 100644 tools/mtd-utils/patches/300-libfec_use_standard_unsigned_long.patch


your patch is not formatted correctly.

Why are you using some random commit and not the commit of the 1.5.2 tag?

When I build it I get this warning, can you fix it?

compr_lzma.c:95:14: warning: initialization from incompatible pointer
type [-Wincompatible-pointer-types]
  .compress = &jffs2_lzma_compress,
              ^
compr_lzma.c:95:14: note: (near initialization for
'jffs2_lzma_comp.compress')
compr_lzma.c:96:16: warning: initialization from incompatible pointer
type [-Wincompatible-pointer-types]
  .decompress = &jffs2_lzma_decompress,
                ^
compr_lzma.c:96:16: note: (near initialization for
'jffs2_lzma_comp.decompress')

Hauke

> 
> diff --git a/tools/mtd-utils/Makefile b/tools/mtd-utils/Makefile
> index b863179..d38798b 100644
> --- a/tools/mtd-utils/Makefile
> +++ b/tools/mtd-utils/Makefile
> @@ -7,14 +7,14 @@
>  include $(TOPDIR)/rules.mk
>  
>  PKG_NAME:=mtd-utils
> -PKG_VERSION:=1.5.1
> +PKG_VERSION:=1.5.2
>  
> -PKG_SOURCE_VERSION:=92686f212c9a4e16891c6a3c57629cbf4f0f8360
> +PKG_SOURCE_VERSION:=a494d30ab1ae40cb7665680cadf5af3ca3830a73
>  PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-$(PKG_SOURCE_VERSION).tar.gz
>  PKG_SOURCE_URL:=git://git.infradead.org/mtd-utils.git
>  PKG_SOURCE_PROTO:=git
>  PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
> -PKG_MIRROR_MD5SUM:=9fe0518213feddacd1842935dddeb6c8
> +PKG_MIRROR_MD5SUM:=0785919dc5888e9397a8bb77e7e0e19c

Where did you get this md5sum from?

>  PKG_CAT:=zcat
>  
>  HOST_BUILD_DIR:=$(BUILD_DIR_HOST)/$(PKG_NAME)-$(PKG_VERSION)
Sven Roederer Dec. 1, 2015, 11:55 p.m. UTC | #2
Am Sonntag, 15. November 2015, 22:59:48 schrieben Sie:
> 
> Why are you using some random commit and not the commit of the 1.5.2 tag?
> 
it was the most recent commit this moment and the messages seems to give only 
improvements

> When I build it I get this warning, can you fix it?
> 

got also these compile-warnings, but I'm not really famillar with this code. 
maybe I can fix the warnings, but I'm not really sure if teh code will do as 
supposed.
My intention was just just to get a working build-env ...

> > 
> > -PKG_MIRROR_MD5SUM:=9fe0518213feddacd1842935dddeb6c8
> > +PKG_MIRROR_MD5SUM:=0785919dc5888e9397a8bb77e7e0e19c
> 
> Where did you get this md5sum from?
> 

my hack was, to create a tgz from the gitcheckout and let the md5sum-tool 
calculate the sum.

Sven
diff mbox

Patch

diff --git a/tools/mtd-utils/Makefile b/tools/mtd-utils/Makefile
index b863179..d38798b 100644
--- a/tools/mtd-utils/Makefile
+++ b/tools/mtd-utils/Makefile
@@ -7,14 +7,14 @@ 
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=mtd-utils
-PKG_VERSION:=1.5.1
+PKG_VERSION:=1.5.2
 
-PKG_SOURCE_VERSION:=92686f212c9a4e16891c6a3c57629cbf4f0f8360
+PKG_SOURCE_VERSION:=a494d30ab1ae40cb7665680cadf5af3ca3830a73
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-$(PKG_SOURCE_VERSION).tar.gz
 PKG_SOURCE_URL:=git://git.infradead.org/mtd-utils.git
 PKG_SOURCE_PROTO:=git
 PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
-PKG_MIRROR_MD5SUM:=9fe0518213feddacd1842935dddeb6c8
+PKG_MIRROR_MD5SUM:=0785919dc5888e9397a8bb77e7e0e19c
 PKG_CAT:=zcat
 
 HOST_BUILD_DIR:=$(BUILD_DIR_HOST)/$(PKG_NAME)-$(PKG_VERSION)
diff --git a/tools/mtd-utils/patches/110-portability.patch b/tools/mtd-utils/patches/110-portability.patch
index 4ad209a..c4cdab9 100644
--- a/tools/mtd-utils/patches/110-portability.patch
+++ b/tools/mtd-utils/patches/110-portability.patch
@@ -150,27 +150,6 @@ 
  #include <inttypes.h>
  #include "version.h"
  
-@@ -117,11 +116,6 @@ extern "C" {
- 	fprintf(stderr, "%s: warning!: " fmt "\n", PROGRAM_NAME, ##__VA_ARGS__); \
- } while(0)
- 
--#if defined(__UCLIBC__)
--/* uClibc versions before 0.9.34 don't have rpmatch() */
--#if __UCLIBC_MAJOR__ == 0 && \
--		(__UCLIBC_MINOR__ < 9 || \
--		(__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ < 34))
- #undef rpmatch
- #define rpmatch __rpmatch
- static inline int __rpmatch(const char *resp)
-@@ -129,8 +123,6 @@ static inline int __rpmatch(const char *
-     return (resp[0] == 'y' || resp[0] == 'Y') ? 1 :
- 	(resp[0] == 'n' || resp[0] == 'N') ? 0 : -1;
- }
--#endif
--#endif
- 
- /**
-  * prompt the user for confirmation
 --- a/include/mtd/ubifs-media.h
 +++ b/include/mtd/ubifs-media.h
 @@ -33,7 +33,15 @@
diff --git a/tools/mtd-utils/patches/137-no_extern_inline.patch b/tools/mtd-utils/patches/137-no_extern_inline.patch
deleted file mode 100644
index d871d67..0000000
--- a/tools/mtd-utils/patches/137-no_extern_inline.patch
+++ /dev/null
@@ -1,41 +0,0 @@ 
---- a/mkfs.ubifs/hashtable/hashtable_itr.c
-+++ b/mkfs.ubifs/hashtable/hashtable_itr.c
-@@ -35,18 +35,6 @@ hashtable_iterator(struct hashtable *h)
- }
- 
- /*****************************************************************************/
--/* key      - return the key of the (key,value) pair at the current position */
--/* value    - return the value of the (key,value) pair at the current position */
--
--void *
--hashtable_iterator_key(struct hashtable_itr *i)
--{ return i->e->k; }
--
--void *
--hashtable_iterator_value(struct hashtable_itr *i)
--{ return i->e->v; }
--
--/*****************************************************************************/
- /* advance - advance the iterator to the next element
-  *           returns zero if advanced to end of table */
- 
---- a/mkfs.ubifs/hashtable/hashtable_itr.h
-+++ b/mkfs.ubifs/hashtable/hashtable_itr.h
-@@ -28,7 +28,7 @@ hashtable_iterator(struct hashtable *h);
- /* hashtable_iterator_key
-  * - return the value of the (key,value) pair at the current position */
- 
--extern inline void *
-+static inline void *
- hashtable_iterator_key(struct hashtable_itr *i)
- {
-     return i->e->k;
-@@ -37,7 +37,7 @@ hashtable_iterator_key(struct hashtable_
- /*****************************************************************************/
- /* value - return the value of the (key,value) pair at the current position */
- 
--extern inline void *
-+static inline void *
- hashtable_iterator_value(struct hashtable_itr *i)
- {
-     return i->e->v;
diff --git a/tools/mtd-utils/patches/300-libfec_use_standard_unsigned_long.patch b/tools/mtd-utils/patches/300-libfec_use_standard_unsigned_long.patch
deleted file mode 100644
index 73a68b5..0000000
--- a/tools/mtd-utils/patches/300-libfec_use_standard_unsigned_long.patch
+++ /dev/null
@@ -1,35 +0,0 @@ 
---- a/lib/libfec.c
-+++ b/lib/libfec.c
-@@ -61,8 +61,6 @@ struct timeval {
- };
- #define gettimeofday(x, dummy) { (x)->ticks = clock() ; }
- #define DIFF_T(a,b) (1+ 1000000*(a.ticks - b.ticks) / CLOCKS_PER_SEC )
--typedef unsigned long u_long ;
--typedef unsigned short u_short ;
- #else /* typically, unix systems */
- #include <sys/time.h>
- #define DIFF_T(a,b) \
-@@ -75,12 +73,12 @@ typedef unsigned short u_short ;
- 	t = x.tv_usec + 1000000* (x.tv_sec & 0xff ) ; \
- 	}
- #define TOCK(t) \
--	{ u_long t1 ; TICK(t1) ; \
-+	{ unsigned long t1 ; TICK(t1) ; \
- 	  if (t1 < t) t = 256000000 + t1 - t ; \
- 	  else t = t1 - t ; \
- 	  if (t == 0) t = 1 ;}
- 
--u_long ticks[10];	/* vars for timekeeping */
-+unsigned long ticks[10];	/* vars for timekeeping */
- #else
- #define DEB(x)
- #define DDB(x)
-@@ -625,7 +623,7 @@ init_fec(void)
- #define FEC_MAGIC	0xFECC0DEC
- 
- struct fec_parms {
--    u_long magic ;
-+    unsigned long magic ;
-     int k, n ;		/* parameters of the code */
-     gf *enc_matrix ;
- } ;