diff mbox

[OpenWrt-Devel] busybox: enable find mtime support by default

Message ID 1445239042.2907.9.camel@brenken.org
State Changes Requested
Headers show

Commit Message

Dirk Brenken Oct. 19, 2015, 7:17 a.m. UTC
busybox binary in openwrt neither supports stat nor find mtime.
This patch adds find mtime support by default.

I've compared ipk size for three different targets
(ar71xx, brcm2708, x86):

209908 Okt 16 13:48 busybox_1.23.2-3_ar71xx.ipk-0before
210031 Okt 16 16:47 busybox_1.23.2-3_ar71xx.ipk-1after
difference: +123 Byte

223519 Okt 16 13:06 busybox_1.23.2-3_brcm2708.ipk-0before
223720 Okt 16 13:53 busybox_1.23.2-3_brcm2708.ipk-1after
difference: +201 Byte

221477 Okt 16 13:47 busybox_1.23.2-3_x86_64.ipk-0before
221622 Okt 16 13:52 busybox_1.23.2-3_x86_64.ipk-1after
difference: +145 Byte

Signed-off-by: Dirk Brenken <dirk@brenken.org>
---

Comments

Felix Fietkau Oct. 30, 2015, 10:13 p.m. UTC | #1
On 2015-10-19 09:17, Dirk Brenken wrote:
> busybox binary in openwrt neither supports stat nor find mtime.
> This patch adds find mtime support by default.
> 
> I've compared ipk size for three different targets
> (ar71xx, brcm2708, x86):
> 
> 209908 Okt 16 13:48 busybox_1.23.2-3_ar71xx.ipk-0before
> 210031 Okt 16 16:47 busybox_1.23.2-3_ar71xx.ipk-1after
> difference: +123 Byte
> 
> 223519 Okt 16 13:06 busybox_1.23.2-3_brcm2708.ipk-0before
> 223720 Okt 16 13:53 busybox_1.23.2-3_brcm2708.ipk-1after
> difference: +201 Byte
> 
> 221477 Okt 16 13:47 busybox_1.23.2-3_x86_64.ipk-0before
> 221622 Okt 16 13:52 busybox_1.23.2-3_x86_64.ipk-1after
> difference: +145 Byte
> 
> Signed-off-by: Dirk Brenken <dirk@brenken.org>
> ---
> diff --git a/a/package/utils/busybox/Config-defaults.in
> b/b/package/utils/busybox/Config-defaults.in
Your patch is line wrapped and does not apply. Please fix and resend.

- Felix
diff mbox

Patch

diff --git a/a/package/utils/busybox/Config-defaults.in
b/b/package/utils/busybox/Config-defaults.in
index a61109a..5b77f93 100644
--- a/a/package/utils/busybox/Config-defaults.in
+++ b/b/package/utils/busybox/Config-defaults.in
@@ -987,7 +987,7 @@  config BUSYBOX_DEFAULT_FEATURE_FIND_PRINT0
        default y
 config BUSYBOX_DEFAULT_FEATURE_FIND_MTIME
        bool
-       default n
+       default y
 config BUSYBOX_DEFAULT_FEATURE_FIND_MMIN
        bool
        default n