diff mbox

[OpenWrt-Devel] lldpd: implement a reload hook

Message ID 1444637424-4733-1-git-send-email-ardeleanalex@gmail.com
State Accepted
Headers show

Commit Message

Alexandru Ardelean Oct. 12, 2015, 8:10 a.m. UTC 
From: Alexandru Ardelean <aa@ocedo.com>

Seems the default one is not working as expected.
The way that reload should work is that the 'start' service
call should return 1 (if lldpd is running) and then a normal
restart would be called.

However, for lldpd a reload would mean just clearing all custom TLVs
(if they're configured) and reloading the configuration.

So, this patch adds a reload hook, which would:
 - 'start' lldpd if it's not running (because we return 1 if not running)
 - reload configuration if it is running (also previously 
    clearing custom TLVs if present)

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
---
 package/network/services/lldpd/files/lldpd.init | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init
index 3d7d8b9..04e5b8c 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++ b/package/network/services/lldpd/files/lldpd.init
@@ -4,6 +4,8 @@ 
 START=90
 
 USE_PROCD=1
+LLDPCLI=/usr/sbin/lldpcli
+LLDPSOCKET=/var/run/lldpd.socket
 
 find_release_info()
 {
@@ -71,6 +73,21 @@  start_service() {
 	procd_close_instance
 }
 
+service_running() {
+	pgrep -x /usr/sbin/lldpd &> /dev/null
+}
+
+reload_service() {
+	running || return 1
+	# Custom TLVs are special and should be
+	# reloaded from config during lldpd reload
+	$LLDPCLI -u $LLDPSOCKET unconfigure lldp custom-tlv &> /dev/null
+	$LLDPCLI -u $LLDPSOCKET -c /etc/lldpd.conf -c /etc/lldpd.d &> /dev/null
+	# Broadcast update over the wire
+	$LLDPCLI -u $LLDPSOCKET update &> /dev/null
+	return 0
+}
+
 stop_service() {
-	rm -f /var/run/lldpd.socket /var/run/lldpd.pid
+	rm -rf /var/run/lldp $LLDPSOCKET
 }