| Message ID | 1440447789-29478-1-git-send-email-abrodkin@synopsys.com |
|---|---|
| State | Rejected |
| Headers | show |
On 08/24/2015 10:23 PM, Alexey Brodkin wrote: > Default value of both SERIAL_8250_NR_UARTS & SERIAL_8250_RUNTIME_UARTS is 4, > see: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/8250/Kconfig > > And some boards rely on that default setting. > What's worse some boards use 3rd or even 4th UART as its primary > serial console. > > For example Synopsys DesignWare SDP board, see "console=ttyS3,115200n8" > here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/boot/dts/axs101.dts > > So having expected default value allows usage of kernel configs that are > closer to their upstream versions. > > Cc: Jonas Gorski <jogo@openwrt.org> > Cc: Zoltan HERPAI <wigyori@uid0.hu> > Cc: Hauke Mehrtens <hauke@hauke-m.de> > Cc: Dirk Neukirchen <dirkneukirchen@web.de> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > --- Nack. Most targets are using 2 uarts. If your target needs more just overwrite this in your target/linux/<target name>/config-4.1 file like it is done in target/linux/sunxi/config-4.1 for example. Hauke
Hi Hauke, On Mon, 2015-08-24 at 22:27 +0200, Hauke Mehrtens wrote: > On 08/24/2015 10:23 PM, Alexey Brodkin wrote: > > Default value of both SERIAL_8250_NR_UARTS & SERIAL_8250_RUNTIME_UARTS is 4, > > see: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/8250/Kconfig > > > > And some boards rely on that default setting. > > What's worse some boards use 3rd or even 4th UART as its primary > > serial console. > > > > For example Synopsys DesignWare SDP board, see "console=ttyS3,115200n8" > > here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/boot/dts/axs101.dts > > > > So having expected default value allows usage of kernel configs that are > > closer to their upstream versions. > > > > Cc: Jonas Gorski <jogo@openwrt.org> > > Cc: Zoltan HERPAI <wigyori@uid0.hu> > > Cc: Hauke Mehrtens <hauke@hauke-m.de> > > Cc: Dirk Neukirchen <dirkneukirchen@web.de> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > > --- > > Nack. > > Most targets are using 2 uarts. If your target needs more just overwrite > this in your target/linux/<target name>/config-4.1 file like it is done > in target/linux/sunxi/config-4.1 for example. Ok I'll add those in my board's config. Still just for my understanding I'm wondering what benefit this limitation allows to achieve? -Alexey
diff --git a/target/linux/generic/config-4.1 b/target/linux/generic/config-4.1 index de4c62c..c7d5871 100644 --- a/target/linux/generic/config-4.1 +++ b/target/linux/generic/config-4.1 @@ -3567,10 +3567,10 @@ CONFIG_SERIAL_8250_DMA=y # CONFIG_SERIAL_8250_FOURPORT is not set # CONFIG_SERIAL_8250_HUB6 is not set # CONFIG_SERIAL_8250_MANY_PORTS is not set -CONFIG_SERIAL_8250_NR_UARTS=2 +CONFIG_SERIAL_8250_NR_UARTS=4 # CONFIG_SERIAL_8250_PCI is not set # CONFIG_SERIAL_8250_RSA is not set -CONFIG_SERIAL_8250_RUNTIME_UARTS=2 +CONFIG_SERIAL_8250_RUNTIME_UARTS=4 # CONFIG_SERIAL_8250_SYSRQ is not set # CONFIG_SERIAL_ALTERA_JTAGUART is not set # CONFIG_SERIAL_ALTERA_UART is not set
Default value of both SERIAL_8250_NR_UARTS & SERIAL_8250_RUNTIME_UARTS is 4, see: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/8250/Kconfig And some boards rely on that default setting. What's worse some boards use 3rd or even 4th UART as its primary serial console. For example Synopsys DesignWare SDP board, see "console=ttyS3,115200n8" here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/boot/dts/axs101.dts So having expected default value allows usage of kernel configs that are closer to their upstream versions. Cc: Jonas Gorski <jogo@openwrt.org> Cc: Zoltan HERPAI <wigyori@uid0.hu> Cc: Hauke Mehrtens <hauke@hauke-m.de> Cc: Dirk Neukirchen <dirkneukirchen@web.de> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> --- target/linux/generic/config-4.1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)