diff mbox

[OpenWrt-Devel,RESEND] swconfig: swlib.c: Fix another memleak

Message ID 1436337436-32354-1-git-send-email-ardeleanalex@gmail.com
State Accepted
Headers show

Commit Message

Alexandru Ardelean July 8, 2015, 6:37 a.m. UTC 
From: Helmut Schaa <hs@ocedo.com>

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

---
 package/network/config/swconfig/src/swlib.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Felix Fietkau July 8, 2015, 12:05 p.m. UTC | #1 
On 2015-07-08 08:37, Alexandru Ardelean wrote:
> From: Helmut Schaa <hs@ocedo.com>
> 
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Erm... The author is supposed to add the Signed-off-by himself, as
described in https://dev.openwrt.org/wiki/SubmittingPatches

- Felix
Helmut Schaa July 8, 2015, 1:09 p.m. UTC | #2 
On Wed, Jul 8, 2015 at 2:05 PM, Felix Fietkau <nbd@openwrt.org> wrote:
> On 2015-07-08 08:37, Alexandru Ardelean wrote:
>> From: Helmut Schaa <hs@ocedo.com>
>>
>> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Erm... The author is supposed to add the Signed-off-by himself, as
> described in https://dev.openwrt.org/wiki/SubmittingPatches

Sorry, should have used my googlemail address ...

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

Helmut
diff mbox

Patch

diff --git a/package/network/config/swconfig/src/swlib.c b/package/network/config/swconfig/src/swlib.c
index dae603c..f79b826 100644
--- a/package/network/config/swconfig/src/swlib.c
+++ b/package/network/config/swconfig/src/swlib.c
@@ -529,10 +529,13 @@  struct switch_attr *swlib_lookup_attr(struct switch_dev *dev,
 static void
 swlib_priv_free(void)
 {
+	if (family)
+		nl_object_put((struct nl_object*)family);
 	if (cache)
 		nl_cache_free(cache);
 	if (handle)
 		nl_socket_free(handle);
+	family = NULL;
 	handle = NULL;
 	cache = NULL;
 }