| Message ID | 1432675677-8806-4-git-send-email-mathieu@codeaurora.org |
|---|---|
| State | Accepted |
| Headers | show |
Please note that the sunxi and oxnas targets already use stmmac. However, in your patch the selected config symbols do not apply to stmmac in general but are specific to the hardware you are using. Please either make the module depend on the target platforms it is meant to be used on or fix it so it actually covers the generic case. On Tue, May 26, 2015 at 02:27:54PM -0700, Mathieu Olivari wrote: > Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org> > --- > package/kernel/linux/modules/netdevices.mk | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk > index 9dd18f3..62fd949 100644 > --- a/package/kernel/linux/modules/netdevices.mk > +++ b/package/kernel/linux/modules/netdevices.mk > @@ -811,6 +811,27 @@ endef > $(eval $(call KernelPackage,vmxnet3)) > > > +define KernelPackage/stmmac > + SUBMENU:=$(NETWORK_DEVICES_MENU) > + TITLE:=STMicro 10/100/1000 Ethernet driver > + DEPENDS:=+kmod-mii +kmod-ptp > + KCONFIG:=CONFIG_NET_VENDOR_STMICRO=y \ > + CONFIG_STMMAC_ETH \ > + CONFIG_STMMAC_PLATFORM=y \ > + CONFIG_STMMAC_DEBUG_FS=y \ > + CONFIG_STMMAC_DA=y \ > + CONFIG_DWMAC_IPQ806X=y > + FILES:=$(LINUX_DIR)/drivers/net/ethernet/stmicro/stmmac/stmmac.ko > + AUTOLOAD:=$(call AutoLoad,50,stmmac.ko) > +endef > + > +define KernelPackage/stmmac/description > + Kernel module for STMicroelectronics 10/100/1000 Ethernet driver > +endef > + > +$(eval $(call KernelPackage,stmmac)) > + > + > define KernelPackage/spi-ks8995 > SUBMENU:=$(NETWORK_DEVICES_MENU) > TITLE:=Micrel/Kendin KS8995 Ethernet switch control > -- > 2.1.4 > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
On 2015-05-26 23:27, Mathieu Olivari wrote:
> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>
How about simply enabling stmmac in the target kernel config?
- Felix
Yeah; that's what I was thinking actually. I'll post a patch today. -----Original Message----- From: Felix Fietkau [mailto:nbd@openwrt.org] Sent: Friday, May 29, 2015 1:35 PM To: Mathieu Olivari; blogic@openwrt.org; kaloz@openwrt.org Cc: openwrt-devel@lists.openwrt.org Subject: Re: [PATCH 3/6] kernel: add stmmac as a new kernel package On 2015-05-26 23:27, Mathieu Olivari wrote: > Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org> How about simply enabling stmmac in the target kernel config? - Felix
diff --git a/package/kernel/linux/modules/netdevices.mk b/package/kernel/linux/modules/netdevices.mk index 9dd18f3..62fd949 100644 --- a/package/kernel/linux/modules/netdevices.mk +++ b/package/kernel/linux/modules/netdevices.mk @@ -811,6 +811,27 @@ endef $(eval $(call KernelPackage,vmxnet3)) +define KernelPackage/stmmac + SUBMENU:=$(NETWORK_DEVICES_MENU) + TITLE:=STMicro 10/100/1000 Ethernet driver + DEPENDS:=+kmod-mii +kmod-ptp + KCONFIG:=CONFIG_NET_VENDOR_STMICRO=y \ + CONFIG_STMMAC_ETH \ + CONFIG_STMMAC_PLATFORM=y \ + CONFIG_STMMAC_DEBUG_FS=y \ + CONFIG_STMMAC_DA=y \ + CONFIG_DWMAC_IPQ806X=y + FILES:=$(LINUX_DIR)/drivers/net/ethernet/stmicro/stmmac/stmmac.ko + AUTOLOAD:=$(call AutoLoad,50,stmmac.ko) +endef + +define KernelPackage/stmmac/description + Kernel module for STMicroelectronics 10/100/1000 Ethernet driver +endef + +$(eval $(call KernelPackage,stmmac)) + + define KernelPackage/spi-ks8995 SUBMENU:=$(NETWORK_DEVICES_MENU) TITLE:=Micrel/Kendin KS8995 Ethernet switch control
Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org> --- package/kernel/linux/modules/netdevices.mk | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)