From patchwork Thu Jan 8 16:08:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?QW50dGkgU2VwcMOkbMOk?= X-Patchwork-Id: 426698 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C00E140119 for ; Fri, 9 Jan 2015 03:09:21 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id F101A28051C; Thu, 8 Jan 2015 17:06:58 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 955582802F8 for ; Thu, 8 Jan 2015 17:06:51 +0100 (CET) X-policyd-weight: using cached result; rate:hard: -4.5 Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 8 Jan 2015 17:06:51 +0100 (CET) Received: by mail-lb0-f173.google.com with SMTP id z12so3665527lbi.4 for ; Thu, 08 Jan 2015 08:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=w0rW6yWTaythNCSXIPqmMqi0i5+dVLAZlGDI2vQtFwQ=; b=Xi/2ap2cS/qnyKHu59vHTk++i+98JOHm29SX84Bs07eZf0SZrssWuq0o8hKWY6Ke2Q DhrkjkaWKr0jETYLOoOavhVKoiVn5QaXWxn5+IMmxyfVoH8BtPIgdWoPpyty2/mHHk8Z 8I/U/lPcWHw8j7Nd5C4NDb10laAhJbrB5OFlc2lYCDCNG1VRy7MEj7GsV6XTm26Fj4Dq ETv/MEaN6ABZLls+/dPIcji6JFRO2tA2yGhgL3vjkRndyz7rZ04ifPHT1JIyQlUuhdmg vHqsysSpvchIg2GHiV9ZsIV31fX21CvE7NObfVtOKVvcTTdFGabBzR5z0N7IiBe0LGxW 4TKg== X-Received: by 10.152.7.229 with SMTP id m5mr15141826laa.80.1420733337273; Thu, 08 Jan 2015 08:08:57 -0800 (PST) Received: from griffin.lan (a91-154-177-123.elisa-laajakaista.fi. [91.154.177.123]) by mx.google.com with ESMTPSA id vu9sm1231568lbb.36.2015.01.08.08.08.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jan 2015 08:08:56 -0800 (PST) From: =?UTF-8?q?Antti=20Sepp=C3=A4l=C3=A4?= To: openwrt-devel@lists.openwrt.org Date: Thu, 8 Jan 2015 18:08:19 +0200 Message-Id: <1420733299-18005-1-git-send-email-a.seppala@gmail.com> X-Mailer: git-send-email 2.0.5 MIME-Version: 1.0 Subject: [OpenWrt-Devel] [PATCH] igmpproxy: add patch to silence unnecessary logging of downstream igmp traffic X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" This patch adds a simple check to silence logging of messages about unrecognized igmp packets which originate from devices in local network. Without this patch igmpproxy floods openwrt syslog with messages such as: user.warn igmpproxy[19818]: The source address 192.168.1.175 for group 239.255.250.250, is not in any valid net for upstream VIF. Signed-off-by: Antti Seppälä --- ...0-Silence-downstream-interface-igmp-messages.patch | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 package/network/services/igmpproxy/patches/020-Silence-downstream-interface-igmp-messages.patch diff --git a/package/network/services/igmpproxy/patches/020-Silence-downstream-interface-igmp-messages.patch b/package/network/services/igmpproxy/patches/020-Silence-downstream-interface-igmp-messages.patch new file mode 100644 index 0000000..ccd000c --- /dev/null +++ b/package/network/services/igmpproxy/patches/020-Silence-downstream-interface-igmp-messages.patch @@ -0,0 +1,19 @@ +--- a/src/igmp.c ++++ b/src/igmp.c +@@ -139,8 +139,14 @@ + return; + } + else if(!isAdressValidForIf(checkVIF, src)) { +- my_log(LOG_WARNING, 0, "The source address %s for group %s, is not in any valid net for upstream VIF.", +- inetFmt(src, s1), inetFmt(dst, s2)); ++ struct IfDesc *downVIF = getIfByAddress(src); ++ if (downVIF && downVIF->state & IF_STATE_DOWNSTREAM) { ++ my_log(LOG_NOTICE, 0, "The source address %s for group %s is from downstream VIF. Ignoring.", ++ inetFmt(src, s1), inetFmt(dst, s2)); ++ } else { ++ my_log(LOG_WARNING, 0, "The source address %s for group %s, is not in any valid net for upstream VIF.", ++ inetFmt(src, s1), inetFmt(dst, s2)); ++ } + return; + } +