From patchwork Wed Nov 12 13:59:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yousong Zhou X-Patchwork-Id: 419622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DAAE71400A0 for ; Wed, 10 Dec 2014 23:20:37 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id CF83928C1EA; Wed, 10 Dec 2014 13:16:37 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, DATE_IN_PAST_96_XX, FREEMAIL_FROM,T_DKIM_INVALID autolearn=no version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id F06B728C1E1 for ; Wed, 10 Dec 2014 13:16:19 +0100 (CET) X-policyd-weight: using cached result; rate: -8.5 Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Wed, 10 Dec 2014 13:16:15 +0100 (CET) Received: by mail-pa0-f45.google.com with SMTP id lf10so2108730pab.32 for ; Wed, 10 Dec 2014 04:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hoGTg2mn37nLWLU9idIOmvp/OYsuc+aTeS5Gdf46npw=; b=gFZZuxvNx7QqgpjSxCm2Iskz/G+uU4cRjFQTR56sWgjxCVjJfcCEsZuVLAKR82A3u6 W+nxZ0AWIqDMKv4Uh5u+DhcLVHO1rW37n4otz78aHHru8ywObZ/VfNFf7ycrY4Mn+sKX 4TVwled+3oKtiwP4fa1Xgz6j5mS9hTOd6/OO/jwPH/ej+Gyf1Qx9+MBz3jKEakHy3How cSgGHrOu9BFNTZhvQQxNi5nR+U8BmoHZh8+utwtp42rqnMPW69WkZiQ55yOIJyhjeL8y kCQq3as82FBqTUn3vwDNwmsQ12U7EKiSsNLizepHlMEIuO1WP7OPXmoaAYsKF7j276+/ 4n9A== X-Received: by 10.70.49.77 with SMTP id s13mr6954253pdn.24.1418213874985; Wed, 10 Dec 2014 04:17:54 -0800 (PST) Received: from debian.lan ([103.29.140.56]) by mx.google.com with ESMTPSA id hc10sm4063709pbd.78.2014.12.10.04.17.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Dec 2014 04:17:53 -0800 (PST) From: Yousong Zhou To: nbd@openwrt.org Date: Wed, 12 Nov 2014 21:59:19 +0800 Message-Id: <1415800763-14311-7-git-send-email-yszhou4tech@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1415800763-14311-1-git-send-email-yszhou4tech@gmail.com> References: <1415800763-14311-1-git-send-email-yszhou4tech@gmail.com> Cc: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH v2 06/10] blobmsg: remove unneeded assignment in blobmsg_alloc_string_buffer(). X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" data_dest should already be assigned by blobmsg_new() if the return value is not NULL. Signed-off-by: Yousong Zhou --- blobmsg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/blobmsg.c b/blobmsg.c index 9fe96e4..80b984a 100644 --- a/blobmsg.c +++ b/blobmsg.c @@ -262,7 +262,6 @@ blobmsg_alloc_string_buffer(struct blob_buf *buf, const char *name, unsigned int if (!attr) return NULL; - data_dest = blobmsg_data(attr); blob_set_raw_len(buf->head, blob_pad_len(buf->head) - blob_pad_len(attr)); blob_set_raw_len(attr, blob_raw_len(attr) - maxlen);