diff mbox

[OpenWrt-Devel] add UCI option for leasetime per static host

Message ID 1151851012.240310.cb572b60-11c9-400b-9548-5e1ae167cbee.open-xchange@email.1und1.de
State Changes Requested
Headers show

Commit Message

ufomanfred@freaktose.net Dec. 30, 2015, 5:28 a.m. UTC 
Hi guys,

I wanted to use this feature and decided to figure out how to commit to the
awesome OpenWrt project.

I am completely new to development so please be kind when reviewing. I
appreciate any (constructive) feedback!

Cheers, ufomanfred

Edit: screw you HTML webmail client..

---
package/network/services/dnsmasq/files/dnsmasq.init | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


dhcp_tag_add() {

Comments

Felix Fietkau Jan. 3, 2016, 8:19 p.m. UTC | #1 
On 2015-12-30 06:28, ufomanfred@freaktose.net wrote:
> Hi guys,
> 
> I wanted to use this feature and decided to figure out how to commit to the
> awesome OpenWrt project.
> 
> I am completely new to development so please be kind when reviewing. I
> appreciate any (constructive) feedback!
> 
> Cheers, ufomanfred
> 
> Edit: screw you HTML webmail client..
Patch is still broken (line wrapped).
Also, the subject should have a proper prefix, e.g. 'dnsmasq:' and the
email body should only contain things that should end up in the commit
message, e.g. a proper description what the change does and why it does
it. Please fix and resend.

Thanks,

- Felix
Hannu Nyman Jan. 5, 2016, 11:57 a.m. UTC | #2 
Felix Fietkau  wrote at Sun Jan 3 21:19:20 CET 2016:
 > On 2015-12-30 06:28, ufomanfred at freaktose.net wrote:
 > > Hi guys,
 > >
 > > I wanted to use this feature and decided to figure out how to commit to the
 > > ...
 > Patch is still broken (line wrapped).
 > Also, the subject should have a proper prefix, e.g. 'dnsmasq:' and
 > ...

Jumping into the discussion:
I had a similar patch ready in my own build, so I submitted a hopefully 
correct version as
https://patchwork.ozlabs.org/patch/563051/
diff mbox

Patch

diff --git a/package/network/services/dnsmasq/files/dnsmasq.init
b/package/network/services/dnsmasq/files/dnsmasq.init
index 3ef2b3d..f89bd8c 100644
--- a/package/network/services/dnsmasq/files/dnsmasq.init
+++ b/package/network/services/dnsmasq/files/dnsmasq.init
@@ -334,7 +334,9 @@  dhcp_host_add() {
config_get_bool broadcast "$cfg" broadcast 0
[ "$broadcast" = "0" ] && broadcast=

- xappend
"--dhcp-host=$macs${networkid:+,net:$networkid}${broadcast:+,set:needs-broadcast}${tag:+,set:$tag}${ip:+,$ip}${name:+,$name}"
+ config_get leasetime "$cfg" leasetime
+
+ xappend
"--dhcp-host=$macs${networkid:+,net:$networkid}${broadcast:+,set:needs-broadcast}${tag:+,set:$tag}${ip:+,$ip}${name:+,$name}${leasetime:+,$leasetime}"
}