mbox series

[OpenWrt-Devel,0/4] Overhaul distfeeds.conf generation

Message ID cover.1531174081.git.mschiffer@universe-factory.net
Headers show
Series Overhaul distfeeds.conf generation | expand

Message

Matthias Schiffer July 9, 2018, 10:31 p.m. UTC
Hi,
I've been annoyed with the way we handle distfeeds.conf generation for
quite some time, as the feeds that are used to build and the feeds that end
up in the opkg config always had to be the same (disabling some of the
CONFIG_FEED_... symbols would also disable the feed for rootfs creation,
making these options basically useless - the result was usually a broken
build).

This patchset implements a way to add additional distfeeds.conf entries
(src-dummy method), makes rootfs creation independent of feed enable
status, and moves from global ADD_DISABLED and ADD_COMMENTED symbols to
per-feed configuration.

I would like to add this patchset to 18.06 as well, as we require these
changes for Gluon, and we obviously want to avoid adding downstream patches
as much as possible.

The same patchset can also be found in my staging tree at 
https://git.openwrt.org/?p=openwrt/staging/neoraider.git;a=summary

Regards,
Matthias


Matthias Schiffer (4):
  scripts/feeds: add src-dummy method
  include/feeds.mk: always add available feeds to PACKAGE_SUBDIRS
  base-files: fix feed list in PKG_CONFIG_DEPENDS
  include/feeds.mk: rework generation of opkg distfeeds.conf

 include/feeds.mk                   | 17 ++++++-----------
 package/base-files/Makefile        |  4 +---
 package/base-files/image-config.in | 14 --------------
 scripts/feeds                      | 12 +++++++++---
 4 files changed, 16 insertions(+), 31 deletions(-)

Comments

Jo-Philipp Wich July 11, 2018, 9:10 a.m. UTC | #1
> This patchset implements a way to add additional distfeeds.conf entries
> (src-dummy method), makes rootfs creation independent of feed enable
> status, and moves from global ADD_DISABLED and ADD_COMMENTED symbols to
> per-feed configuration.

Acked-by: Jo-Philipp Wich <jo@mein.io>