mbox series

[OpenWrt-Devel,v2,0/7] Move caldata extraction and MAC patching to common file

Message ID 20190922095717.1714-1-freifunk@adrianschmutzler.de
Headers show
Series Move caldata extraction and MAC patching to common file | expand

Message

Adrian Schmutzler Sept. 22, 2019, 9:57 a.m. UTC 
This is an update of my patchset unifying caldata extraction
and MAC patching. I've improved some tiny things and despite that
mostly done rebasing.
I've also included the patch for the special situation in lantiq
I sent separately for v1.

The patchset removes 417 lines of redundant code, which despite that
also included several variations of the same approach.

This has been tested on:
- ath79/ath9k: WDR4300 v1
- ath79/ath10k: Archer C60 v2
- ipq806x: TP-Link C2600

I would be happy about other tests, especially for ramips and lantiq.

#
#*** BLURB HERE ***
#
Adrian Schmutzler (7):
  treewide: fix hex2dec conversion for MAC address checksum offset
  base-files: move xor() from caldata extraction to functions.sh
  treewide: move calibration data extraction function to library
  treewide: move MAC address patch functions to common library
  ath79: set checksum when patching MAC address on ath10k
  lantiq: set checksum when patching MAC address on ath10k
  lantiq: modify ath9k caldata extraction to reuse caldata.sh

 package/base-files/files/lib/functions.sh     |  16 ++
 .../base-files/files/lib/functions/caldata.sh | 128 ++++++++++++++
 .../etc/hotplug.d/firmware/10-ath9k-eeprom    |  61 +------
 .../etc/hotplug.d/firmware/10-ath9k-eeprom    | 162 ++++--------------
 .../etc/hotplug.d/firmware/11-ath10k-caldata  | 159 +++++------------
 .../etc/hotplug.d/firmware/10-rt2x00-eeprom   |  27 +--
 .../etc/hotplug.d/firmware/11-ath10k-caldata  | 139 +++------------
 .../etc/hotplug.d/firmware/11-ath10k-caldata  | 100 ++---------
 .../etc/hotplug.d/firmware/11-ath10k-caldata  |  37 +---
 .../etc/hotplug.d/firmware/12-ath9k-eeprom    | 151 +++-------------
 .../etc/hotplug.d/firmware/10-ath9k-eeprom    |  25 +--
 .../etc/hotplug.d/firmware/10-rt2x00-eeprom   |  48 +-----
 12 files changed, 318 insertions(+), 735 deletions(-)
 create mode 100644 package/base-files/files/lib/functions/caldata.sh

Comments

Adrian Schmutzler Oct. 2, 2019, 10:46 p.m. UTC | #1 
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Adrian Schmutzler
> Sent: Sonntag, 22. September 2019 11:57
> To: openwrt-devel@lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH v2 0/7] Move caldata extraction and MAC
> patching to common file
> 
> This is an update of my patchset unifying caldata extraction and MAC
> patching. I've improved some tiny things and despite that mostly done
> rebasing.
> I've also included the patch for the special situation in lantiq I sent separately
> for v1.
> 
> The patchset removes 417 lines of redundant code, which despite that also
> included several variations of the same approach.
> 
> This has been tested on:
> - ath79/ath9k: WDR4300 v1
> - ath79/ath10k: Archer C60 v2
> - ipq806x: TP-Link C2600
> 

Tested on mpc85xx (WDR4900 v1).
Adrian Schmutzler Oct. 7, 2019, 5:45 p.m. UTC | #2 
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] On Behalf Of mail@adrianschmutzler.de
> Sent: Donnerstag, 3. Oktober 2019 00:46
> To: openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH v2 0/7] Move caldata extraction and MAC patching to common file
> 
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> > On Behalf Of Adrian Schmutzler
> > Sent: Sonntag, 22. September 2019 11:57
> > To: openwrt-devel@lists.openwrt.org
> > Subject: [OpenWrt-Devel] [PATCH v2 0/7] Move caldata extraction and MAC
> > patching to common file
> >
> > This is an update of my patchset unifying caldata extraction and MAC
> > patching. I've improved some tiny things and despite that mostly done
> > rebasing.
> > I've also included the patch for the special situation in lantiq I sent
> > separately
> > for v1.
> >
> > The patchset removes 417 lines of redundant code, which despite that also
> > included several variations of the same approach.
> >
> > This has been tested on:
> > - ath79/ath9k: WDR4300 v1
> > - ath79/ath10k: Archer C60 v2
> > - ipq806x: TP-Link C2600
> >
> 
> Tested on mpc85xx (WDR4900 v1).

Tested on ipq40xx (Netgear EX6150v2).