mbox series

[OpenWrt-Devel,v3,0/6] Speed up and merge caldata/eeprom extraction

Message ID 20190227221809.1697-1-freifunk@adrianschmutzler.de
Headers show
Series Speed up and merge caldata/eeprom extraction | expand

Message

Adrian Schmutzler Feb. 27, 2019, 10:18 p.m. UTC 
This patchset goes on with the attempt to
- speed up caldata/eeprom handling by reading blockwise,
- merge the similar functions in one library.

It depends on the patch "ath79: speed up ath9k-eeprom extraction"
by Dmitry Tunin to be applied beforehand.

It replaces my earlier patchsets
- Speed up caldata/eeprom handling for ar71xx/ath79
- Speed up caldata/eeprom handling with common file

The patches 1 to 4 have been run-tested (all at once) on the following
devices:
TP-Link WDR4300 (ar71xx and ath79)
Ubnt AC Mesh (ath79)
TP-Link CPE210 v2 (ar71xx)

The patches 5 and 6 are optional. Since a have no ipq40xx or ramips
device at hand, I cannot test them. Thus, one can apply patches 1 to 4
and then easily do patches 5 and 6 if/after they are tested. (So they
do not hold up the earlier patches.)
However, it would be nice if someone did test ramips and ipq40xx.

Adrian Schmutzler (6):
  ath79: Speed up caldata/eeprom handling
  ar71xx: Speed up caldata/eeprom handling
  ar71xx: Speed up mtd extraction in ar71xx.sh
  ar71xx/ath79: Merge eeprom/caldata extraction into eeprom.sh
  ipq40xx: Make use of common eeprom.sh library for caldata
  ramips: Merge ath9k-eeprom extraction to common eeprom.sh

 package/base-files/files/lib/functions/eeprom.sh   | 91 ++++++++++++++++++++
 .../etc/hotplug.d/firmware/10-ath9k-eeprom         | 99 +++++-----------------
 .../etc/hotplug.d/firmware/11-ath10k-caldata       | 80 ++++++-----------
 target/linux/ar71xx/base-files/lib/ar71xx.sh       |  4 +-
 .../etc/hotplug.d/firmware/10-ath9k-eeprom         | 86 ++++++-------------
 .../etc/hotplug.d/firmware/11-ath10k-caldata       | 62 ++++----------
 .../etc/hotplug.d/firmware/11-ath10k-caldata       | 82 +++++-------------
 .../etc/hotplug.d/firmware/10-rt2x00-eeprom        | 32 ++-----
 8 files changed, 209 insertions(+), 327 deletions(-)
 create mode 100644 package/base-files/files/lib/functions/eeprom.sh

Comments

Petr Štetiar March 1, 2019, 10:16 a.m. UTC | #1 
Adrian Schmutzler <freifunk@adrianschmutzler.de> [2019-02-27 23:18:03]:

Hi,

> This patchset goes on with the attempt to
> - speed up caldata/eeprom handling by reading blockwise,
> - merge the similar functions in one library.

thanks a lot for taking care of this!

> It depends on the patch "ath79: speed up ath9k-eeprom extraction"
> by Dmitry Tunin to be applied beforehand.
> 
> It replaces my earlier patchsets
> - Speed up caldata/eeprom handling for ar71xx/ath79
> - Speed up caldata/eeprom handling with common file

I just wanted to build some images for testing, but unfortunately it seems
like the repository is fast moving target and the patchset doesn't apply
cleanly already.

 $ git log --pretty=oneline -1
 0e8ddc953f844861b60debec4d7c65f9b4de7434 libubox: bump to version 2019-02-27

 $ pwclient git-am 1046790 1049166 1049168 1049163 1049169 1049164 1049167
 Applying patch #1046790 using 'git am'
 Description: [OpenWrt-Devel] ath79: speed up ath9k-eeprom extraction
 Applying: ath79: speed up ath9k-eeprom extraction
 Applying patch #1049166 using 'git am'
 Description: [OpenWrt-Devel,v3,1/6] ath79: Speed up caldata/eeprom handling
 Applying: ath79: Speed up caldata/eeprom handling
 Applying patch #1049168 using 'git am'
 Description: [OpenWrt-Devel,v3,2/6] ar71xx: Speed up caldata/eeprom handling
 Applying: ar71xx: Speed up caldata/eeprom handling
 Applying patch #1049163 using 'git am'
 Description: [OpenWrt-Devel,v3,3/6] ar71xx: Speed up mtd extraction in ar71xx.sh
 Applying: ar71xx: Speed up mtd extraction in ar71xx.sh
 Applying patch #1049169 using 'git am'
 Description: [OpenWrt-Devel,v3,4/6] ar71xx/ath79: Merge eeprom/caldata extraction into eeprom.sh
 Applying: ar71xx/ath79: Merge eeprom/caldata extraction into eeprom.sh
 error: patch failed: target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata:92
 error: target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata: patch does not apply
 Patch failed at 0001 ar71xx/ath79: Merge eeprom/caldata extraction into eeprom.sh
 The copy of the patch that failed is found in: .git/rebase-apply/patch
 When you have resolved this problem, run "git am --continue".
 If you prefer to skip this patch, run "git am --skip" instead.
 To restore the original branch and stop patching, run "git am --abort".
 'git am' failed with exit status 128

-- ynezz
Adrian Schmutzler March 1, 2019, 1:14 p.m. UTC | #2 
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] On
> Behalf Of Petr Štetiar
> Sent: Freitag, 1. März 2019 11:16
> To: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> Cc: openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH v3 0/6] Speed up and merge
> caldata/eeprom extraction
> 
> Adrian Schmutzler <freifunk@adrianschmutzler.de> [2019-02-27 23:18:03]:
> 
> Hi,
> 
> > This patchset goes on with the attempt to
> > - speed up caldata/eeprom handling by reading blockwise,
> > - merge the similar functions in one library.
> 
> thanks a lot for taking care of this!
> 
> > It depends on the patch "ath79: speed up ath9k-eeprom extraction"
> > by Dmitry Tunin to be applied beforehand.
> >
> > It replaces my earlier patchsets
> > - Speed up caldata/eeprom handling for ar71xx/ath79
> > - Speed up caldata/eeprom handling with common file
> 
> I just wanted to build some images for testing, but unfortunately it seems
> like the repository is fast moving target and the patchset doesn't apply
> cleanly already.
> 
>  $ git log --pretty=oneline -1
>  0e8ddc953f844861b60debec4d7c65f9b4de7434 libubox: bump to version 2019-
> 02-27
> 
>  $ pwclient git-am 1046790 1049166 1049168 1049163 1049169 1049164 1049167
>  Applying patch #1046790 using 'git am'
>  Description: [OpenWrt-Devel] ath79: speed up ath9k-eeprom extraction
>  Applying: ath79: speed up ath9k-eeprom extraction
>  Applying patch #1049166 using 'git am'
>  Description: [OpenWrt-Devel,v3,1/6] ath79: Speed up caldata/eeprom handling
>  Applying: ath79: Speed up caldata/eeprom handling
>  Applying patch #1049168 using 'git am'
>  Description: [OpenWrt-Devel,v3,2/6] ar71xx: Speed up caldata/eeprom
> handling
>  Applying: ar71xx: Speed up caldata/eeprom handling
>  Applying patch #1049163 using 'git am'
>  Description: [OpenWrt-Devel,v3,3/6] ar71xx: Speed up mtd extraction in
> ar71xx.sh
>  Applying: ar71xx: Speed up mtd extraction in ar71xx.sh
>  Applying patch #1049169 using 'git am'
>  Description: [OpenWrt-Devel,v3,4/6] ar71xx/ath79: Merge eeprom/caldata
> extraction into eeprom.sh
>  Applying: ar71xx/ath79: Merge eeprom/caldata extraction into eeprom.sh
>  error: patch failed: target/linux/ath79/base-files/etc/hotplug.d/firmware/11-
> ath10k-caldata:92
>  error: target/linux/ath79/base-files/etc/hotplug.d/firmware/11-ath10k-caldata:
> patch does not apply
>  Patch failed at 0001 ar71xx/ath79: Merge eeprom/caldata extraction into
> eeprom.sh
>  The copy of the patch that failed is found in: .git/rebase-apply/patch
>  When you have resolved this problem, run "git am --continue".
>  If you prefer to skip this patch, run "git am --skip" instead.
>  To restore the original branch and stop patching, run "git am --abort".
>  'git am' failed with exit status 128
> 
> -- ynezz
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Hi,

there was at least one ath79 device support patch yesterday, I will rebase somewhat tomorrow.

Best

Adrian