| Message ID | e1e03f9f89c47c6aaccd354016bd122fcbbf7a16.1499179167.git.mleitner@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On 4 July 2017 at 11:04, Marcelo Ricardo Leitner <mleitner@redhat.com> wrote: > Currently it is using the datapath name/type but what has actually > failed was the netdev. > > Fix it by using netdev name/type instead and also log why it failed. > > Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com> Thanks for the patch, I applied this to master.
diff --git a/lib/dpif.c b/lib/dpif.c index 45c1890411ba44b3d0aa767b4bf980377ac9db92..4d6ecf88993acfcf95b3aa36d9f1b4e9bfa8b5d0 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -369,7 +369,8 @@ do_open(const char *name, const char *type, bool create, struct dpif **dpifp) netdev_ports_insert(netdev, DPIF_HMAP_KEY(dpif), &dpif_port); netdev_close(netdev); } else { - VLOG_WARN("could not open netdev %s type %s", name, type); + VLOG_WARN("could not open netdev %s type %s: %s", + dpif_port.name, dpif_port.type, ovs_strerror(err)); } } } else {
Currently it is using the datapath name/type but what has actually failed was the netdev. Fix it by using netdev name/type instead and also log why it failed. Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com> --- lib/dpif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)