| Message ID | b80311c8279f5afe9894a055981f1a29d4f69ce2.1594312857.git.gmuthukr@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | system-dpdk: add tso negotiation tests | expand |
On Thu, Jul 09, 2020 at 10:18:18PM +0530, Gowrishankar Muthukrishnan wrote: > Moved commands to set hugepages in every numa node into a macro > for tests to reuse. > > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com> > --- LGTM Acked-by: Flavio Leitner <fbl@sysclose.org>
On 7/9/20 6:48 PM, Gowrishankar Muthukrishnan wrote: > Moved commands to set hugepages in every numa node into a macro > for tests to reuse. > > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com> > --- Hi. Sorry for so long delays. This patch seems redundant. I think, new tests should not configure socket memory as it's not required by current versions of DPDK. Instead of moving the code to a function, this patch might just remove it. But this is kind of a separate change to this patch set. Best regards, Ilya Maximets. > tests/system-dpdk.at | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at > index ab10f44..623bd34 100644 > --- a/tests/system-dpdk.at > +++ b/tests/system-dpdk.at > @@ -1,6 +1,11 @@ > m4_define([CONFIGURE_VETH_OFFLOADS], > [AT_CHECK([ethtool -K $1 tx off], [0], [ignore], [ignore])]) > > +m4_define([SET_NUMA_NODE], > + [ > + AT_CHECK([lscpu | awk '/NUMA node\(s\)/ {c=1; while (c++<$(3)) {printf "$1,"}; print "$1"}' > NUMA_NODE]) > +]) > + > AT_BANNER([OVS-DPDK unit tests]) > > dnl -------------------------------------------------------------------------- > @@ -96,8 +101,7 @@ OVS_DB_START() > OVS_DPDK_START() > > dnl Find number of sockets > -AT_CHECK([lscpu], [], [stdout]) > -AT_CHECK([cat stdout | grep "NUMA node(s)" | awk '{c=1; while (c++<$(3)) {printf "512,"}; print "512"}' > NUMA_NODE]) > +SET_NUMA_NODE([512]) > > dnl Add userspace bridge and attach it to OVS > AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev]) > @@ -175,8 +179,7 @@ OVS_DB_START() > OVS_DPDK_START() > > dnl Find number of sockets > -AT_CHECK([lscpu], [], [stdout]) > -AT_CHECK([cat stdout | grep "NUMA node(s)" | awk '{c=1; while (c++<$(3)) {printf "512,"}; print "512"}' > NUMA_NODE]) > +SET_NUMA_NODE([512]) > > dnl Add userspace bridge and attach it to OVS > AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev]) >
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index ab10f44..623bd34 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -1,6 +1,11 @@ m4_define([CONFIGURE_VETH_OFFLOADS], [AT_CHECK([ethtool -K $1 tx off], [0], [ignore], [ignore])]) +m4_define([SET_NUMA_NODE], + [ + AT_CHECK([lscpu | awk '/NUMA node\(s\)/ {c=1; while (c++<$(3)) {printf "$1,"}; print "$1"}' > NUMA_NODE]) +]) + AT_BANNER([OVS-DPDK unit tests]) dnl -------------------------------------------------------------------------- @@ -96,8 +101,7 @@ OVS_DB_START() OVS_DPDK_START() dnl Find number of sockets -AT_CHECK([lscpu], [], [stdout]) -AT_CHECK([cat stdout | grep "NUMA node(s)" | awk '{c=1; while (c++<$(3)) {printf "512,"}; print "512"}' > NUMA_NODE]) +SET_NUMA_NODE([512]) dnl Add userspace bridge and attach it to OVS AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev]) @@ -175,8 +179,7 @@ OVS_DB_START() OVS_DPDK_START() dnl Find number of sockets -AT_CHECK([lscpu], [], [stdout]) -AT_CHECK([cat stdout | grep "NUMA node(s)" | awk '{c=1; while (c++<$(3)) {printf "512,"}; print "512"}' > NUMA_NODE]) +SET_NUMA_NODE([512]) dnl Add userspace bridge and attach it to OVS AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev])
Moved commands to set hugepages in every numa node into a macro for tests to reuse. Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr@redhat.com> --- tests/system-dpdk.at | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)