| Message ID | b4c70eecd2e9a78916fe8dfe603a46513653e0ed.1612549143.git.marcelo.leitner@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [ovs-dev,v4] vswitchd: update tc hwol docs regarding vswitchd restarts | expand |
On Fri, Feb 05, 2021 at 03:20:41PM -0300, Marcelo Ricardo Leitner wrote: > hw-offload is can actually be enabled without a restart. Then, once > enabled, a restart is needed in order to make the new value effective. > > tc-policy, just like hw-offload, is protected by ovsthread_once_start() > in netdev_set_flow_api_enabled() and is only parsed when hw-offload is > enabled. So lets document that if hw-offload was already enabled > changing it requires a restart in order for it to have effect. > > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Hi Marcelo, This patch appears to have gone stale in patchwork, for one reason or another. If it is still relevant then I think it needs to be revisited, by being reposted after appropriate preparation. As such I'm marking this patch as "Deferred" in patchwork. No action is required unless there is a desire to revisit this patch.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 5b2a174ab813139d3f3253be47758d4bfb1beac3..cde791d4e19f69f49ab7f77ec3abfc6b8f4f30f9 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -228,8 +228,9 @@ Set this value to <code>true</code> to enable netdev flow offload. </p> <p> - The default value is <code>false</code>. Changing this value requires - restarting the daemon + The default value is <code>false</code>. Changing this value from + <code>true</code> to <code>false</code> requires restarting the + daemon. </p> <p> Currently Open vSwitch supports hardware offloading on @@ -267,7 +268,9 @@ <ref column="other_config" key="hw-offload"/> is enabled. </p> <p> - The default value is <code>none</code>. + The default value is <code>none</code>. Changing this value requires + restarting the daemon if + <ref column="other_config" key="hw-offload"/> was already enabled. </p> </column>
hw-offload is can actually be enabled without a restart. Then, once enabled, a restart is needed in order to make the new value effective. tc-policy, just like hw-offload, is protected by ovsthread_once_start() in netdev_set_flow_api_enabled() and is only parsed when hw-offload is enabled. So lets document that if hw-offload was already enabled changing it requires a restart in order for it to have effect. Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> --- Notes: v2: include changes regarding the new understanding on hw-offload v3: fixed warnings v4: fix wording vswitchd/vswitch.xml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)