From patchwork Tue Apr 9 14:45:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1921448 X-Patchwork-Delegate: i.maximets@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=ldLOq2l+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDTKf4886z1yYH for ; Wed, 10 Apr 2024 00:45:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DF4D481F1F; Tue, 9 Apr 2024 14:45:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Kd_1zatetg37; Tue, 9 Apr 2024 14:45:48 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A772781D7C Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=ldLOq2l+ Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A772781D7C; Tue, 9 Apr 2024 14:45:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4BD63C0077; Tue, 9 Apr 2024 14:45:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 56960C0037 for ; Tue, 9 Apr 2024 14:45:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 387CF60D4D for ; Tue, 9 Apr 2024 14:45:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SKyIdvcnGHfY for ; Tue, 9 Apr 2024 14:45:46 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2819::800; helo=aus01-sy4-obe.outbound.protection.outlook.com; envelope-from=miterv@outlook.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6559A60C33 Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=outlook.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6559A60C33 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=ldLOq2l+ Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn20800.outbound.protection.outlook.com [IPv6:2a01:111:f403:2819::800]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6559A60C33 for ; Tue, 9 Apr 2024 14:45:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLb/3CXy0WPRf0aXPDcQcFQLxwxIfrGKjx07IrRgZg8yVoKMv9R11ZPUHekEMYBULcS/c3rcFdySudPKYykDbTa27T8+7R665W6++ccH2+owG+kD3HTlFocNliKsizzO/mhP//j1IDDUNiAKWaNTznorjS9LL44Cs1I/PWWE+/aslp9vcGh63CZBwik/Lc9hEmiejlDgmwaZk9XL0tsehHzP93MwScCkxoPSFJLr+eKJhxSfCHShBwBIAia+ZYREAqptZztBTyx75gjSQ3ybt7PyGZTqC7vjVBtZbuwgloHL+7MUl7RyB5D+vLLO5GAiTQ1mjFi5unP5P+gWWWYMqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6q+pU1Wntb0zmuFu6yCJxgxeP+L4P/RnT8xW4dfE7qk=; b=G2bAPg9epL3JAS/4y4/tPmsZWGvK6z5cbgsOHTctgVY+N4Eo2zvsjrI5dMrKq7D073vSFRtOc8+ReDmgmH71Pxe6FfNwAfMpJ8ZMm9mqzrY06JaajW5ETgVw1Sa3TrwMfSpYzZp9crg8OxPoj6Gzvxkj7lU1oO/FiBPWkgO2WQQHcAfvPhv2cuf61sKKiCW+W/oGloNUwZpqYJ0brFMcb6xNBLaKh6hytwvlu0Ta8dATr9JeJ+WG/lU/6MblG2CYLbUBTnlIo4lNyRDElArAJ9KSxVAsi5sO2Ic9sLLyFeN/iGU9NaYFUU8og6G8HizGTIhWk0bPdglMVtWpV+XSuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6q+pU1Wntb0zmuFu6yCJxgxeP+L4P/RnT8xW4dfE7qk=; b=ldLOq2l+gKGwC7keVoWtD/CSGO/Z7u81bDxYGQyobaYhatBhmjxj+87IoEnGJtf3XLpXQfGlDRkHXBCVfE2Ss63UrOmVSJRFpsqtrweiN5kRyg61QR0JzvdJbLkoqJdtvL6wTyYifdJ+l/GJVKZqDrMNCK3XsXRY4LjWygd65NFizk18SSMT2yiFBasSUYj+1Xjyx8tYvrY5aPu9nK5Fj9es/EvYO5Rep3zWw+oazaLjN9pAORMPYHdiPe7VwthBBZ7yJUw2CPctnnDYrqxbcG+43glU4UBk+43znbus3Zd3a+Lz7ybCrhVs8b2HjB/BzMhSrfYMsqrOyP9xN1VpRw== Received: from SY8P282MB4580.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:258::12) by ME0P282MB5367.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:23a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 9 Apr 2024 14:45:40 +0000 Received: from SY8P282MB4580.AUSP282.PROD.OUTLOOK.COM ([fe80::e9ba:b1b2:16a6:13d9]) by SY8P282MB4580.AUSP282.PROD.OUTLOOK.COM ([fe80::e9ba:b1b2:16a6:13d9%5]) with mapi id 15.20.7409.023; Tue, 9 Apr 2024 14:45:40 +0000 From: miterv@outlook.com To: dev@openvswitch.org, i.maximets@ovn.org, aconole@redhat.com Date: Tue, 9 Apr 2024 22:45:18 +0800 Message-ID: X-Mailer: git-send-email 2.39.3 X-TMN: [0AeXdojkUnouZ8GCnF2D/xfDRvslGgQM] X-ClientProxiedBy: SG2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::15) To SY8P282MB4580.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:258::12) X-Microsoft-Original-Message-ID: <20240409144518.1740-1-miterv@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SY8P282MB4580:EE_|ME0P282MB5367:EE_ X-MS-Office365-Filtering-Correlation-Id: dcd7e91f-5c05-4dbf-68e7-08dc58a3b8e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YNhKqk6cgD4WAS+ybOLI0ul3I9wqO/73p51/hhTjmdeKQ+c6EGX08QPXAV1EbtibV/0+Nu4mEaXunwqEt8DP/Lm99eDz7hmZ9SmmY/qRRxK4RYueaodyyLsn6BLrakVo+YwNfU3Vp0RleDzN3zpYO71WN/P3hPajQsWWPMgI5MojYKi6fhjEziFZ/3n+dkncm+eXqaKSGbvmsl1coonu6UTMlof90dBdkggF+kot+TocoIQCEEAiDXh9iC+p8nxCeNdYBh0468L/2I6BYKLM2MP5s1j5JkhllqkzsSk7JgiB/gGn7RIREPmIksHDPzEe3MTBjBsIrAnG5hqbl3DR+8V0yfJs3ZIWXpphpLbeXz6CSzrxRddA85qzL288lFK3Zcc/ydFg4jvhfjfx2vyL39vEk72JSQJ3c+mnBRRICOA2TIXenw6z74NMBHKOZ0AhI95m7IrfRgs0bOryH4zfok7JfJrlwtCaDrst0aHq9hwXmYEy2zO0aAJuWad/vpP8438lhHss0diQRfh/ysLHgzTe2weHUKx8P4Pv9CNETBaJEjEpQImlpTaRLlpjCzQp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0gC0rXdBpcNe4GWizXvy0zNtyElvOhOnNHI41SiSr57H4RO/37rmoJie6WlXGxchjIlF0cLPb30gft2FVEAZtm22x0rO8pdC6SCPihkteQGThuKhXAmfNWTJki+JkfEwTzTPKSa7HjXhY/6W9uPRVrE2h3pQSeN6UtEag/KyD7+JqXNaeBaRoUthtoraffx+BPsAMYlhDeiVlXuJAhrPL+2mg8OqlNon19VCws9PwI5CnqwcN6Bo8vPaxLjc22YWgGHT5deQtvvyTdmg14n29o1hNdq7MPuAVxN12+1kJh24i9qsPrcDRglHMIWBECYzvlYlKaVIF++7zfiYRQ5eM8k4wSPbu2dKNX9HeGiju7t/youbbWSsM74LoLASDYSgEpnfnfCFeVfn+Zk0LvwUEpEr5dc9q+pCpyPNy8N9TXhSOIpu9WCABIUl1ghhiKnRI2s3LdsXlWkOyvIf0T1/VDib1DQH3PkbnngznKWk441CsJQUem/SRD7ev1JI4z8OCPA3x1QgL7jYYrScBTw2m+1b3049yjx7K3HMueRgU37r4J9AR+jnPNpARpjZGBQrRaVlLl9yeRi/PcZ2eDrlUatAe9DJzU8bMCLmFdnLU/M5pnZX1M5ZWgkTGo2imsOyqe91Tz9jCGFPljxTWLb1u+uc6ZzNTU/zaMcgbjEbAoCW6IWQrwql3YEO8/VJNmDpWBsauNXdu22m50bYNXOPf3qH7XHNlQbHZojOrKEr36c9KiGUkZw3P/x2t+AxmNeND4SC9x6eKIcDVUFdnyVGr9e4Smxg+FQbe1s8elSEgA/fJENVxnGcKJdW9Z2fEnz86PTMVXTcPa00QnRfM0Kre18+iXZvVW52kqrhS6DEgEpYhJauFStFGCVnDwOS0MOrXeFOCAlleBLx26vDue3Ja5zhvVP7B/V0o7evo0Xc8ipn+gRSeyRcdq68L1358ECHhh6oj7pSgwI7IRmIykCcOCwPh5zuldPJbPC0+KMP1ievcnu7dNbXfyw2g3aUkp19mxvD609mnUycD8gOC5QVkyJWkRogiiHja4eBm6MFGjKaf8x2d7fJ4caBDzQnSAE1R0bl6mlThQRYRQ1xu7kV1eSJTaKLWefxGUcdxJkH/tcsWqOx7HL38cJ3BaW2YUAlBxg5OSjK0t/JfsqGAoNxZmqs+g2s6VjKubIIgrQ9GECjFSjOla0wkv4yfEcD1DAV9bRy0ICtqKqdbHG3Yh1wwV0S7cQ/4VROGBee/e3wxbM= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcd7e91f-5c05-4dbf-68e7-08dc58a3b8e4 X-MS-Exchange-CrossTenant-AuthSource: SY8P282MB4580.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 14:45:38.7786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME0P282MB5367 Subject: [ovs-dev] [PATCH v2] ofproto: Fix Coverity false positive. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Lin Huang Coverity reports a false positive below: Ofproto_class_find__() may return NULL, and dereference it to cause segfault. This patch is made just to avoid false-positive Coverity report. Tested-by: Zhang YuHuang Signed-off-by: Lin Huang --- ofproto/ofproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 122a06f30..21c6a1d82 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -800,7 +800,7 @@ ofproto_type_set_config(const char *datapath_type, const struct smap *cfg) datapath_type = ofproto_normalize_type(datapath_type); class = ofproto_class_find__(datapath_type); - if (class->type_set_config) { + if (class && class->type_set_config) { class->type_set_config(datapath_type, cfg); } }