diff mbox

[ovs-dev,1/2] ovn-controller: fix vlan_trunk bug

Message ID OFFCC99087.988C33D9-ON4825815D.000D1D9E-4825815D.000D2DB7@zte.com.cn
State Changes Requested
Headers show

Commit Message

wang qianyu July 14, 2017, 2:24 a.m. UTC
The bug description is as follow:

Neutron configure a trunk-sub port. The parent-port and sub-port located 
in different network. there is a vm attached to parent port. And no vm 
attached to the network of sub-port in the same chassis. In this 
situation, the ovn-controller can not get the configuration info of 
sub-port.

The reason is that ovn-controller does not monitor the port-binding with 
parent.

This patch fix this bug.

Change-Id: I0ce3f5b1b5a9e81608ecc587a796998520a8da47
Signed-off-by: 10110202 <wang.qianyu@zte.com.cn>
---
 ovn/controller/ovn-controller.c | 1 +
 1 file changed, 1 insertion(+)

     }
     if (local_datapaths) {

Comments

Ben Pfaff Aug. 2, 2017, 8:38 p.m. UTC | #1
On Fri, Jul 14, 2017 at 10:24:17AM +0800, wang.qianyu@zte.com.cn wrote:
> The bug description is as follow:
> 
> Neutron configure a trunk-sub port. The parent-port and sub-port located 
> in different network. there is a vm attached to parent port. And no vm 
> attached to the network of sub-port in the same chassis. In this 
> situation, the ovn-controller can not get the configuration info of 
> sub-port.
> 
> The reason is that ovn-controller does not monitor the port-binding with 
> parent.
> 
> This patch fix this bug.
> 
> Change-Id: I0ce3f5b1b5a9e81608ecc587a796998520a8da47
> Signed-off-by: 10110202 <wang.qianyu@zte.com.cn>

I took the liberty of fixing the Signed-off-by line, and then applied
this to master and branch-2.7.
wang qianyu Aug. 3, 2017, 12:42 a.m. UTC | #2
ok




Ben Pfaff <blp@ovn.org>
2017/08/03 04:38
 
        收件人:        wang.qianyu@zte.com.cn, 
        抄送:  dev@openvswitch.org
        主题:  Re: [ovs-dev]  [PATCH 1/2] ovn-controller: fix vlan_trunk 
bug


On Fri, Jul 14, 2017 at 10:24:17AM +0800, wang.qianyu@zte.com.cn wrote:
> The bug description is as follow:

> 

> Neutron configure a trunk-sub port. The parent-port and sub-port located 


> in different network. there is a vm attached to parent port. And no vm 

> attached to the network of sub-port in the same chassis. In this 

> situation, the ovn-controller can not get the configuration info of 

> sub-port.

> 

> The reason is that ovn-controller does not monitor the port-binding with 


> parent.

> 

> This patch fix this bug.

> 

> Change-Id: I0ce3f5b1b5a9e81608ecc587a796998520a8da47

> Signed-off-by: 10110202 <wang.qianyu@zte.com.cn>


I took the liberty of fixing the Signed-off-by line, and then applied
this to master and branch-2.7.
diff mbox

Patch

diff --git a/ovn/controller/ovn-controller.c 
b/ovn/controller/ovn-controller.c
index 00b4cda..4406f00 100644
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -174,6 +174,7 @@  update_sb_monitors(struct ovsdb_idl *ovnsb_idl,
         const char *name;
         SSET_FOR_EACH (name, local_ifaces) {
             sbrec_port_binding_add_clause_logical_port(&pb, OVSDB_F_EQ, 
name);
+            sbrec_port_binding_add_clause_parent_port(&pb, OVSDB_F_EQ, 
name);
         }