diff mbox series

[ovs-dev] conntrack : dpif parameter is used, need to remove OVS_UNUSED.

Message ID MEYP282MB3302B7EAE6E78416886577E4CDC89@MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM
State Superseded
Headers show
Series [ovs-dev] conntrack : dpif parameter is used, need to remove OVS_UNUSED. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/apply-robot fail apply and check: fail

Commit Message

lin huang Aug. 27, 2021, 7:40 a.m. UTC
The dpif parameter of zone limits function is used.
We need to remove OVS_UNUSED flag.

Signed-off-by: linhuang <linhuang@ruijie.com.cn>
---
 lib/dpif-netdev.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

--
2.12.2

Comments

David Marchand Sept. 9, 2021, 11:56 a.m. UTC | #1
For the title, my suggestion is:

dpif-netdev: Remove unnecessary OVS_UNUSED.

On Fri, Aug 27, 2021 at 12:30 PM lin huang <miterv@outlook.com> wrote:
>
> The dpif parameter of zone limits function is used.
> We need to remove OVS_UNUSED flag.

Strictly speaking, there is no *need* for removing the flag.
But I agree this flag here can be dropped: the compiler would only
care for this hint if the variable was unused (which is not the case
here).

I would add a Fixes: tag in the commitlog.

Fixes: a7f33fdbfb67 ("conntrack: Support zone limits.")

>
> Signed-off-by: linhuang <linhuang@ruijie.com.cn>

Please double check the robot warnings on Author and SoB tag.

With those comments fixed, you can add:
Reviewed-by: David Marchand <david.marchand@redhat.com>
diff mbox series

Patch

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index b3e57bb95..1708a5f9e 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -8418,9 +8418,9 @@  dpif_netdev_ct_get_tcp_seq_chk(struct dpif *dpif, bool *enabled)
 }

 static int
-dpif_netdev_ct_set_limits(struct dpif *dpif OVS_UNUSED,
-                           const uint32_t *default_limits,
-                           const struct ovs_list *zone_limits)
+dpif_netdev_ct_set_limits(struct dpif *dpif,
+                          const uint32_t *default_limits,
+                          const struct ovs_list *zone_limits)
 {
     int err = 0;
     struct dp_netdev *dp = get_dp_netdev(dpif);
@@ -8443,10 +8443,10 @@  dpif_netdev_ct_set_limits(struct dpif *dpif OVS_UNUSED,
 }

 static int
-dpif_netdev_ct_get_limits(struct dpif *dpif OVS_UNUSED,
-                           uint32_t *default_limit,
-                           const struct ovs_list *zone_limits_request,
-                           struct ovs_list *zone_limits_reply)
+dpif_netdev_ct_get_limits(struct dpif *dpif,
+                          uint32_t *default_limit,
+                          const struct ovs_list *zone_limits_request,
+                          struct ovs_list *zone_limits_reply)
 {
     struct dp_netdev *dp = get_dp_netdev(dpif);
     struct conntrack_zone_limit czl;
@@ -8483,8 +8483,8 @@  dpif_netdev_ct_get_limits(struct dpif *dpif OVS_UNUSED,
 }

 static int
-dpif_netdev_ct_del_limits(struct dpif *dpif OVS_UNUSED,
-                           const struct ovs_list *zone_limits)
+dpif_netdev_ct_del_limits(struct dpif *dpif,
+                          const struct ovs_list *zone_limits)
 {
     int err = 0;
     struct dp_netdev *dp = get_dp_netdev(dpif);