From patchwork Sun Apr 24 15:56:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1621541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=X6HpPvQP; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KmXp81Lgwz9s09 for ; Mon, 25 Apr 2022 01:57:03 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D365181D2D; Sun, 24 Apr 2022 15:57:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qB6nsl8-aLYj; Sun, 24 Apr 2022 15:57:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 08DC181BD9; Sun, 24 Apr 2022 15:57:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CE5D3C0032; Sun, 24 Apr 2022 15:56:59 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 44CD7C002D for ; Sun, 24 Apr 2022 15:56:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2C7FD60B77 for ; Sun, 24 Apr 2022 15:56:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=outlook.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AqAB13atsi15 for ; Sun, 24 Apr 2022 15:56:58 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn20815.outbound.protection.outlook.com [IPv6:2a01:111:f403:7004::815]) by smtp3.osuosl.org (Postfix) with ESMTPS id ABB6160B29 for ; Sun, 24 Apr 2022 15:56:57 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KLUeUh4SAIaM1vWGWRkIp9OqwCrk1NoIN2JUGwYooVu9IsEymSpDyL2JpGrQFyWz6JFjyD4VdhYykbabp964HZhDi7v5IkLVbhfXF9V+hX0chzlgYAyn9DS7FIwq4wC7xI2QXVToXa7pSjHrNL/eSt2pVyy03jDGVBwaZqsolkbeMLvnxWAknb6AOyvaXgUcucwWXDXNCfgF7aVxx/u2KiiPbx+tu8dbIz9RXvzFkcavn9tHzW+MoR0oIrMRZLMVY+3vm++sSEkZOX8DOiiQQh9Hp3RnDqUVGnhPmRxWHQOOd2za3Vw829bIW1/ENqhHqZcTUMMvJfUn/KFq1CKjtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GUGuw+q0I7WAeZCp0b4mFGNvs1n3KK0/UCrYMMXyg/g=; b=NuEgdAEl8WiOaL0kDLKx0JtHIcM5ZkjuGbwp/AZRvbDMJrxwg88bKUJ21/fvDgDq/EcADtBSdCHCsyoX/4m/gF9+DtNloy8Mh/73jupoKZVUT7/aKGsFbq1pkCsFEPwK2mJqtY/4O21VsZgLZ+zN8HMvZqLGSaciuXusF/RLvHNCJbnA7RqNMf53AA8h8LKPjYxmb9iN1x3Nq3UEIV6zXFDxxtgSqSHEPK4F9tTj3ojZYLX+Gyw9G8XoN6idYGEa6v4PMLo4o+EYM7wqR3KYOLcdCl6F34zERFUmsVEgeyXUuaCAOv7FeoWyt+iOzlSn9onNpljsMBJPKEZykRmgEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUGuw+q0I7WAeZCp0b4mFGNvs1n3KK0/UCrYMMXyg/g=; b=X6HpPvQPw6JiNe03r+Bgb31m5qFwcX26NraeH4L0CMGUOPCT2xjw/Bqx4N0kmv9HWcBEXmVeBwyTowfhnqa4GxI3TtwZ+CzxsMcENMfnmpELLWXVaNYTZRa2Dnxkglko+uUkaikb95nNE33L6/TOWBGyK4/ir8blpGYJbEuWoIC+HCaKrAR/AiZ7PsPBmbM1yFMl6WWHZ9KYVDjJXf4MAb1ZIHkVJ1cVTKB32+WLPKlPtLp5ow+FvP/XZrQxiwNcIGL1Ss5YsOitHmrlw47FSDl9DvQGmMMYGhVvWu7Ysas1PSvygvyMq0SuhXEM7cjjMoTcoLd4sPqlR2tEryArAw== Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15b::24) by SY4P282MB2806.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:159::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sun, 24 Apr 2022 15:56:51 +0000 Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a]) by MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a%3]) with mapi id 15.20.5186.021; Sun, 24 Apr 2022 15:56:51 +0000 From: lin huang To: "dev@openvswitch.org" Thread-Topic: [PATCH v2] dpif-netdev : Fix ALB rebalance interval zero value. Thread-Index: AdhX7wAz9GixegXITBmkobq+fsxtUA== Date: Sun, 24 Apr 2022 15:56:51 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [SiENFFmdROYu8RnMIg1X/CsPdFDmyy1e] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a185dac-b9d4-41c2-d2a2-08da260b0c1e x-ms-traffictypediagnostic: SY4P282MB2806:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gqyajkBTnNOYu74pcmeAeohFLuu0M9sHmzCDyH04X05bKtAZEnF6fFjQEKOZoSayRnAtDriVfGDWHx2k9c8ZY4W1YymrEUMHc85PNwBSzjtb208zq9Si1Wnv0MP9XKF/C+owo/NPT87ecH5/8TNyQ9tHLGFv2CkyUhpSya98pfEZEv5nzN3ec/2uOW+A0CVdIaSMCFU1x969AuK5TzGVMuWEtK9cpPnrZ4F7d7zsKxhItdAHD7AQzsjOUbzDchs/7YxruywLQgYtJiL0uiHEug+MxzuesQKiQ1BKFMit/YfD1aHGz1kbHjMfXdrSYa6uzzSQv0hFpB7XpjrFc7B9UUcH1ZLP+x2bUC9B2cit2i6J4+cIsycuAc0GsX/3h+BGmb05Cii8Vx2oFgux2HCZeHThcpD2esyy3lGVCTDikOQ3vnT6aZcpag1UKXLvMwgw1KuaMIZ1hpIk/EA5TEgZU2nX1MstEVQPOtnfKURydSekqEbrNkgwhRi+PMxUk3t6CYIavVFj0AswSORe3wAiGB2nZRSnYFl9/fuX5H62RaIlD9I7h3PEnUlqtdiQ+dwi/iWH604ZeU2Gf3EMX218dw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?NGI3ZUtOZWNRQzNNZE5zYnJm?= =?eucgb2312_cn?b?NmVJUFozaE8vQyticjNNeit3OTJHSHFjWTRsMXR2YW81VGF2VlEzakt1cWFQUDFM?= =?eucgb2312_cn?b?Z3BmNDNUSjhqV3pyZmI2bkRpbjBLK0x0VzNUbDhtaStjN1IwQjVYc1c5bmlDemR4?= =?eucgb2312_cn?b?amJWNlBBajNEZmhIQlB5cWc3U2p0dXREcnFVY28xakRPTDk1LzBEL1NCZ291cWh6?= =?eucgb2312_cn?b?UjdJbHd2WWxPUS9wNkNnbm1pMDk3S1hPTlF5R0FkWVZPdjljQ3hNZlhPR3RJZzlK?= =?eucgb2312_cn?b?N0ZUWmtmT1JROEdMMHBtNDlnajBmTzdhc3NDNzBlbGJpZEg0NFJ1elhYNERVeEIr?= =?eucgb2312_cn?b?TlRFdFZHZ28rSTFmRm4yZ2RtYzJhRHNXZk1EMmNpOXZ0TnlxZjUvb3M2Z2dCbjN3?= =?eucgb2312_cn?b?STFqY24wYVplWkFHVG0yT2NRL0hZUkpoNmZMYXRoQmhxUmNyYk5CYyt4K280aUNG?= =?eucgb2312_cn?b?NFpqWEtxc0hQcEJRQ1c4ZU83TlU1RWRGZW02ZWlGWDNPbXlUZy9vMWEwdlpCQWt2?= =?eucgb2312_cn?b?dEVuNC9nQm1iZEhzSTRpWGZFOGZueXUyUXJYbko3d3ZkNy9kbm9lY0t3dlk3SHRR?= =?eucgb2312_cn?b?d2o1RGo3TlZ3ZEJzem4rVnVtMWt0b2pIQmw0YkoxWlBGU0NiUHVhcVh1Y2xoZWRv?= =?eucgb2312_cn?b?eFgyVmJkVmZRMlFvdzlRTUljM2U5dEdFNCt6UEFwRk56ck1qaXRCV1BFbnJiUjhT?= =?eucgb2312_cn?b?OEwxa3JJbXFHU3lDMjEwU0I2TEVqWlpQcU9xaUF1OTBDUGd3cEFvOWtuY2I0cGJF?= =?eucgb2312_cn?b?a1UzRkxEdzNiUDhha29COVRzVXErTmk1WFZFNW9DbVhNRjRoK1luRHJrenJUQUVs?= =?eucgb2312_cn?b?UkJ3MHBhWUJsQnJRTy9hUnZnbEwwRHRmSE1KQmhHYktsVHl2QkJRb1UycFFyT1cx?= =?eucgb2312_cn?b?a3Y5ZWphNnc5U0pYdDM0bkY0Q0dabmJ3d1NCNlQ2WjZ5ME95ajBydHd3ODlLZ2Fs?= =?eucgb2312_cn?b?K001V0RxN0Q3VU5rc2tCK1lsMnpuT1FuRkxTRFRheEpKSnFhMi93ZnNhbzRubVdv?= =?eucgb2312_cn?b?Q3JoRktJTmNMUGh5T0ZveHdLN25uYVcvZlMwTGRFU2t5NjJsSGNvZFI1Zm5GUHo0?= =?eucgb2312_cn?b?STcxYjdXSW9wR0R6Vy8ralVuTVBoRzJEc2ZxN3YzaE1yWFRjTDIxMzluVFFmaTRi?= =?eucgb2312_cn?b?Zm9PNjhTWHU3QnNnaTdaMVJ6UENscU55VmFYd1FtdTJjQ2tyTlNGMlpIUEx3TC9r?= =?eucgb2312_cn?b?S0Y2bTNseEx5S2J2VFhsUm1YcVBDbHdJVzV1a0ttSkRQcTN0cmtoMG1DOTkxR0ZG?= =?eucgb2312_cn?b?aDdrUHZSa0JCM1NQa3lvMTNRamVMNXVlS0s4Q0lFeU5LQmx5RnFkQ3dFVjd3dUVo?= =?eucgb2312_cn?b?SUJiNDJBdEtFQ0cwSkZDZytjbEUvZTBnMnc1RnQ4OXlnU2JlUmNINFdibmhMRE5s?= =?eucgb2312_cn?b?S284a0NDeGgwVmUzTmc1cWhtL284bm5hQVk3NlpiZTBvVy9WTUJCVnNXazJmTCtN?= =?eucgb2312_cn?b?TGQ5MnZMV04reFg5L0ROVzUxNHRqN0ZvdmVUUWlXTmZlSGs3enZyNXVOV0pNOUQr?= =?eucgb2312_cn?b?bVVFdm4wVGd2bEhxTU5kWFpSaGRkeVIvVWxMeitBN3pZdlZCZkhoTTJ4eXhYb1ZX?= =?eucgb2312_cn?b?RFNzeUg4RWRxV2VBbDRMREttNVJTSm1UWGN4QlNKemkvekd5cUI1WjJGRDd4T2hl?= =?eucgb2312_cn?b?SjdjN3VFZ2JWU1RIZ1ZuZTI5YmdUYnFUMzRjSzJxQVNhTFNZZlZ2WWE3ZDRiWTBt?= =?eucgb2312_cn?b?WENUcTYvWGhSbTY3MUZMRGxtK0NDN0x0bFdITlAyaVphUm5iWnpCekdCOG84SVp4?= =?eucgb2312_cn?b?Z2JFUTRSTnIyUjNyNUdMYmRXUlBSQllVTEZJbGpoSXNibGZNZFJRK1pjT1c0UGZj?= =?eucgb2312_cn?b?NllRSXloU05ZUnBpQ2RZY2RXOXc9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8a185dac-b9d4-41c2-d2a2-08da260b0c1e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2022 15:56:51.5564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB2806 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH v2] dpif-netdev : Fix ALB rebalance interval zero value. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When we set a special value "-0" to pmd-auto-lb-rebal-interval, its value is 0 not 1. e.g. ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="-0" 2022-04-20T11:31:44.987Z|00526|dpif_netdev|INFO|PMD auto load balance interval set to 0 mins So, fix pmd-auto-lb-rebal-interval's value to 1. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang linhuang@ruijie.com.cn --- lib/dpif-netdev.c | 6 ++++-- tests/alb.at | 10 ++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) dev mailing list dev@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 9f35713ef..5f25bdd68 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4884,8 +4884,10 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) ALB_REBALANCE_INTERVAL); /* Input is in min, convert it to msec. */ - rebalance_intvl = - rebalance_intvl ? rebalance_intvl * MIN_TO_MSEC : MIN_TO_MSEC; + if (rebalance_intvl < ALB_REBALANCE_INTERVAL) { + rebalance_intvl = ALB_REBALANCE_INTERVAL; + } + rebalance_intvl *= MIN_TO_MSEC; if (pmd_alb->rebalance_intvl != rebalance_intvl) { pmd_alb->rebalance_intvl = rebalance_intvl; diff --git a/tests/alb.at b/tests/alb.at index 2bef06f39..d105b72bf 100644 --- a/tests/alb.at +++ b/tests/alb.at @@ -197,6 +197,16 @@ get_log_next_line_num AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="0"]) CHECK_ALB_PARAM([interval], [1 mins], [+$LINENUM]) +# Set new value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="100"]) +CHECK_ALB_PARAM([interval], [100 mins], [+$LINENUM]) + +# Set below min value +get_log_next_line_num +AT_CHECK([ovs-vsctl set open_vswitch . other_config:pmd-auto-lb-rebal-interval="-0"]) +CHECK_ALB_PARAM([interval], [1 mins], [+$LINENUM]) + # No check for above max as it is only a documented max value and not a hard limit OVS_VSWITCHD_STOP -- 2.27.0 _______________________________________________