diff mbox series

[ovs-dev] dpif-netdev.c : remove dpif OVS_UNUSED flag.

Message ID MEYP282MB330276937B5AE233C5CE54E8CDDD9@MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM
State Accepted
Headers show
Series [ovs-dev] dpif-netdev.c : remove dpif OVS_UNUSED flag. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed

Commit Message

miter Sept. 17, 2021, 11:50 a.m. UTC 
From: linhuang <linhuang@ruijie.com.cn>

The dpif is used, so remove the OVS_UNUSED flag.

Signed-off-by: linhuang <linhuang@ruijie.com.cn>
---
 lib/dpif-netdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
2.32.0

Comments

David Marchand Sept. 22, 2021, 2:06 p.m. UTC | #1 
On Fri, Sep 17, 2021 at 2:30 PM lin huang <miterv@outlook.com> wrote:
>
> From: linhuang <linhuang@ruijie.com.cn>
>
> The dpif is used, so remove the OVS_UNUSED flag.
>
> Signed-off-by: linhuang <linhuang@ruijie.com.cn>

Lin,

Usually, reviewers are Cc'd on a new revision of a patch, so please keep me Cc:.
Also submit new revision with a version number.


Ilya,

There is a failure in GHA for this patch.
It seems unrelated to the patch (ASan flagging some meter object
use-after-free).

I don't think there is a need for a new revision.
You can simply fix the title and add the following Fixes: tag.

Fixes: a7f33fdbfb67 ("conntrack: Support zone limits.")
Reviewed-by: David Marchand <david.marchand@redhat.com>
Ilya Maximets Sept. 22, 2021, 10:54 p.m. UTC | #2 
On 9/22/21 16:06, David Marchand wrote:
> On Fri, Sep 17, 2021 at 2:30 PM lin huang <miterv@outlook.com> wrote:
>>
>> From: linhuang <linhuang@ruijie.com.cn>
>>
>> The dpif is used, so remove the OVS_UNUSED flag.
>>
>> Signed-off-by: linhuang <linhuang@ruijie.com.cn>
> 
> Lin,
> 
> Usually, reviewers are Cc'd on a new revision of a patch, so please keep me Cc:.
> Also submit new revision with a version number.
> 
> 
> Ilya,
> 
> There is a failure in GHA for this patch.
> It seems unrelated to the patch (ASan flagging some meter object
> use-after-free).
> 
> I don't think there is a need for a new revision.
> You can simply fix the title and add the following Fixes: tag.
> 
> Fixes: a7f33fdbfb67 ("conntrack: Support zone limits.")
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Thanks!  I updated the commit message and applied.

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 4cd0e9ebd..75f381ec1 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -8429,7 +8429,7 @@  dpif_netdev_ct_get_tcp_seq_chk(struct dpif *dpif, bool *enabled)
 }

 static int
-dpif_netdev_ct_set_limits(struct dpif *dpif OVS_UNUSED,
+dpif_netdev_ct_set_limits(struct dpif *dpif,
                            const uint32_t *default_limits,
                            const struct ovs_list *zone_limits)
 {
@@ -8454,7 +8454,7 @@  dpif_netdev_ct_set_limits(struct dpif *dpif OVS_UNUSED,
 }

 static int
-dpif_netdev_ct_get_limits(struct dpif *dpif OVS_UNUSED,
+dpif_netdev_ct_get_limits(struct dpif *dpif,
                            uint32_t *default_limit,
                            const struct ovs_list *zone_limits_request,
                            struct ovs_list *zone_limits_reply)
@@ -8494,7 +8494,7 @@  dpif_netdev_ct_get_limits(struct dpif *dpif OVS_UNUSED,
 }

 static int
-dpif_netdev_ct_del_limits(struct dpif *dpif OVS_UNUSED,
+dpif_netdev_ct_del_limits(struct dpif *dpif,
                            const struct ovs_list *zone_limits)
 {
     int err = 0;