From patchwork Sat May 7 17:09:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1627944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=M9jqn2/7; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KwYpC3Sy6z9s1l for ; Sun, 8 May 2022 03:09:55 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7B27A60E95; Sat, 7 May 2022 17:09:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w0pv8x1LwPbB; Sat, 7 May 2022 17:09:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8DDE560DFC; Sat, 7 May 2022 17:09:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3E88DC0039; Sat, 7 May 2022 17:09:51 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id DFCB5C002D for ; Sat, 7 May 2022 17:09:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BFA2760E1E for ; Sat, 7 May 2022 17:09:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7w1zYb1OyxOd for ; Sat, 7 May 2022 17:09:49 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01acsn20808.outbound.protection.outlook.com [IPv6:2a01:111:f403:7005::808]) by smtp3.osuosl.org (Postfix) with ESMTPS id 18B4760DFC for ; Sat, 7 May 2022 17:09:49 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TkJkQIc4MSD10O1MchYN4yTyorr7f+avADEGXL9uKY5CKjENMtqCdcWZPc3ykGIT13XXlk2xvH+vDkyOn+85+9ngCBsRrzkYPQW0awneuoQruBtpgibNC+kgzAEL+tcmRKt2FkTcNaH/CGSeWjHJX8OOv4A2IL63FbQe+h9EtCYW2dauJXeLXzhVFfu+LT+fphbdAaeKcPNhyLXbZBfQY0+eB8Xx8wGxFXVyaTc00i7RayNEtfS9mvF61WAz82ChrX5nxCndFFhQzKlmbEU2iAAJpwPnFdjNz/VKZjvk3kgOFmt0XWfRjqWivlHc9Z3649Vj8UBQ7Wfdjep6sT2yMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z8FTV/YJvnUtT2i5YeqQ2Gq9EXqgdppkV7U360XEdrA=; b=h3W8aL5bVN0Huazluju2UQ6WUmJdfxGF0Nc/ORzUU/ZtDAqTSF2+FBbQSqf5c72IFAW3mCID8lS7Fh+cskxHyOJB9r34TkzMRavuM3YlPgIyz6ynYbxjlVxSBb06NIax1XLfn5OHdtjyWdnopwzYmFzXX8VjTxsVSUzk77m2P5dcOkgcahMU9ZoOKp4N3AjlriiOkCEs9bJpx3w/hxB9Q0OXdfbyDPD2sO6r2ZwcLRaq46t5yj0ITFrFiaoNMrZQPU1h8D7g0V17fJDTi1n5A5QLdB3Z5MLtcTC+2136BtQSfoTdJXj0X+hWJ+dTWEfidwuARvD3vVEiyReEaEQI6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z8FTV/YJvnUtT2i5YeqQ2Gq9EXqgdppkV7U360XEdrA=; b=M9jqn2/7mO6FnngFcbq94b407a9GraOLRaJUQUR7KIBDBXMwkP2IT2O8KAEkgDovo0bD6Xn5Hj0n9X+NBV5xzohgfERZWVaW4Zu7BZ7dky1madtXZFzZledet+p5KgXsjvXyEclaYIuJ6o0rsLfgWoYlqg/JQ4R0Fsjxmw5yAL85B06alUCD/nwLMZL/qfFa5Wt21ZYDGiQGQqxp4kBAXZH7tQ1Ky0lQ/DJLI68q76LXlgf+5BdMRWciXW5SkUEFYSXDkOHOQPTvL1E1Wo95FaORNQWtIodIVIq2nQDpoG1k0V8ozojQY89/Q82S/Z6F1np2oMrmvsAiK8Cc2Q+gJw== Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15b::24) by SY4P282MB3014.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:161::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 17:09:44 +0000 Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a]) by MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::f1b0:b062:c467:b9a%3]) with mapi id 15.20.5227.022; Sat, 7 May 2022 17:09:44 +0000 From: lin huang To: "dev@openvswitch.org" Thread-Topic: [PATCH 1/2] dpif-netdev : Fix ALB parameters type mismatch. Thread-Index: AdhiNTpUMCBgfGwCQ16LMkOXi+fO7w== Date: Sat, 7 May 2022 17:09:43 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [zDpoYa7KM5vonQPq7DjNpXxQuWJkeVCU] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a193f75f-6a6e-497e-f0d3-08da304c61a6 x-ms-traffictypediagnostic: SY4P282MB3014:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pUaoPBnP2KhQ7I+qQ7pMGeBBeMUtwNWSfvMW+KYJDarN5JwshUkOKL1ESz7kCjuyiQEjd9M/8kr8QZAD9u6SCC8A3c/XQKPwLZFp7BriLelri7IENb3cQnz1H19tzdTyQhg/aT+K/4ug3CoTChrpdyoJ2CUTAfyFk6sztMzKjTbGSqFSJmYFAJPlpjoewH2Hy1uN/i1W2/qwsMTtHYWUpxa+6ubb4eYPa4ihfK3LSwEez69vItKje68wcgOYdHIv/fzfV0UogZwUcbC++Qiriyz8TsUe/56VPXVcuvby8XA4f9lK9iIuyOiwjFQtEeqlQkhjk985O2tpNJIHn8kmB7k4BPgyvwIT8Lneu8kMgegS5AsUROWDNMSvqGtuQmBfvrgyM0e791GpaJMYeIDxHDxY6HKdqTkHZh467ebrSDKnahwpVtAXLwRxT3b/9VIQIyn/BjSPZOIeeAwcswd3xrUfTHXklGe8N7Wg5u6SKQS6/ntf/j6TYhVYNtGFG278ApHeZWSrZ9NbJn7i8eCEEsMbZFzyheWdyzLZv2mpVjvQwEXcEUHKG2WW5oLphQdM1Ys2fAlVupx8AiJx3jouV/d0uUZi0pdjt4eok2qpLidr0TGSY9bBCM9ZmAfw+JhGwQOLChLK90jUf3ZDiJinCA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?windows-1252?q?5wrqwxxHeDFuqloB8VtWr?= =?windows-1252?q?SWW04glgDQK039l4vtjdlnPNY3YEdmNcmP4jpetAFT9X9uXXW+h2Om9ZON?= =?windows-1252?q?dsoRQUbOb4m1OM5VJ8vHRpVbmBO+unGmcKEtvLLxxZBpSbalHYH2E2mq0L?= =?windows-1252?q?/JSa3ypymIiFMB3w2xqGXxZfBjhc1FVF/467nhz4FigjSJDdEw0Y4Tx5/r?= =?windows-1252?q?3n/CHKY7y+ukQaYUNNc/sPSEfMgNGgaw0BEUV4/GzfndYHzZ/T9fHaLN0a?= =?windows-1252?q?A0TOMLlj0Q0bwNfV/h5ohKApoxFkoNxHhzeQMMvaLH/O2JWK4/XN4kF7p3?= =?windows-1252?q?cTXBwxdV9mi66c50ZoYS5TLOptJumpd+gLTmtHdkFQfAd/fQQJVzF+48Li?= =?windows-1252?q?QL0X6ExozgrBApVfhG6ig1Gk8Pp9I6W+d3MvKdnN1yYmjvyUh6q8h7VBbb?= =?windows-1252?q?9dlzxiJBioOa1He56KfSjhG0P4KGqDWWmjaSZtqXvoPICNBNLEiX80S4Fa?= =?windows-1252?q?KQKwqHtr4cRx9aigpsBAhiO2eAMePtln26OywCRs/z+OgSxYpCqFITvx+e?= =?windows-1252?q?zNbqqWYu/D4zZBlNwDVII8V40EdG/eXqSouReYf84QS7xp0/S2w1Pt4ixX?= =?windows-1252?q?KH6cJJvwhWbV0a6gJDkkbcnJaZ2+JzrylEV9rqZWSqH9giypnIa+cz9FTg?= =?windows-1252?q?sAv4esiOG1OTNOkk8ErrugOYD9Bdca4X3LZwYT5z3YPL+sZcHCWWpTO/0l?= =?windows-1252?q?lI5IN+r6wQmoInvgnrMiCKdks4Yffummz3f1RH5Y4RHJ5lLcpKKcuU/3zS?= =?windows-1252?q?dksSk/Ip7jG0rKP/84gQtFm5ze69HXhIGVi/XXCSrOj3HCJNf+0ibgxHWF?= =?windows-1252?q?e7uDOGIgqC38hKYmznZTv7scfdXaWyBPliA0bjiBgElUmlZdcS/+vVcMG8?= =?windows-1252?q?i2DddPJRTetfLpMWj3pfYWzqbm+ZYrE/6MSsr+VelfAe7faVklAF91KWLF?= =?windows-1252?q?kTSfsrUQ5oJX22V2nWBfQlzcuoXy9CcE59rP6mMh5KSDs/HAr+pogHWcpt?= =?windows-1252?q?s2IpuY/wmjE/waQ3GEX7nTTVrX1mA3+nfbg/XfMAEv9rmQhVf3agpQua/x?= =?windows-1252?q?G3GqbJhzFTDZ91b9w7wJpd0lF9SDdlh0d/EOGBXCduBsd1sVJTp0x/uiCX?= =?windows-1252?q?nXYeKz0VbooQI3WEVNA7Fj5E/bcaWzlZY2Vd8c15ScBMwdUUtPRa/vUEcD?= =?windows-1252?q?4vhyzXaEQ+tAWAqpaGHFH8h2tFBnd6HTjufJWGA8GQSKXSgfJtJ7V4os88?= =?windows-1252?q?2cfN5XAXyFD/M8FvTEE+9UpsnmR62mJEejegT0nF/0fNWSQUWMWkQ8WWn6?= =?windows-1252?q?56KDVa06zBrd4nyaKsT1X0ajRFnHfDhZcHDan44kygz/ead41oIwXh0ytb?= =?windows-1252?q?ZqVPKtFcX0vXntP5g2vnhDsVuikHKir4ERhsbXh4LzbOTmtju4bnE3uqA9?= =?windows-1252?q?2JO6Hk8CClKKBcLjQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a193f75f-6a6e-497e-f0d3-08da304c61a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 17:09:44.0012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB3014 Subject: [ovs-dev] [PATCH 1/2] dpif-netdev : Fix ALB parameters type mismatch. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The ALB parameters should never be negative. So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang linhuang@ruijie.com.cn Signed-off-by: Lin Huang --- lib/dpif-netdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 88a5459cc..2e4be433c 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4879,8 +4879,8 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) struct pmd_auto_lb *pmd_alb = &dp->pmd_alb; - rebalance_intvl = smap_get_int(other_config, "pmd-auto-lb-rebal-interval", - ALB_REBALANCE_INTERVAL); + rebalance_intvl = smap_get_ullong(other_config, "pmd-auto-lb-rebal-interval", + ALB_REBALANCE_INTERVAL); /* Input is in min, convert it to msec. */ rebalance_intvl = @@ -4893,9 +4893,9 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_improve = smap_get_int(other_config, - "pmd-auto-lb-improvement-threshold", - ALB_IMPROVEMENT_THRESHOLD); + rebalance_improve = smap_get_uint(other_config, + "pmd-auto-lb-improvement-threshold", + ALB_IMPROVEMENT_THRESHOLD); if (rebalance_improve > 100) { rebalance_improve = ALB_IMPROVEMENT_THRESHOLD; } @@ -4906,8 +4906,8 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_load = smap_get_int(other_config, "pmd-auto-lb-load-threshold", - ALB_LOAD_THRESHOLD); + rebalance_load = smap_get_uint(other_config, "pmd-auto-lb-load-threshold", + ALB_LOAD_THRESHOLD); if (rebalance_load > 100) { rebalance_load = ALB_LOAD_THRESHOLD; }