From patchwork Wed May 18 14:18:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1632835 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=O3fzSMVA; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L3FVP5wlPz9sGh for ; Thu, 19 May 2022 00:19:24 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 361236120F; Wed, 18 May 2022 14:19:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DdqZaGsk3Qxi; Wed, 18 May 2022 14:19:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5B98460C34; Wed, 18 May 2022 14:19:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 83204C0032; Wed, 18 May 2022 14:19:19 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 38ADCC002D for ; Wed, 18 May 2022 14:19:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AD83B60C34 for ; Wed, 18 May 2022 14:19:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U0QYO86TC0Pr for ; Wed, 18 May 2022 14:19:16 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn20828.outbound.protection.outlook.com [IPv6:2a01:111:f403:7004::828]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0CB4161082 for ; Wed, 18 May 2022 14:19:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTDpP/Beuvb0xkq4xBgsD4FszX/9xlm9JhvO+rqL0S7PybRZYz90Uohi9rnqSPLwXfL6Iy3WIoHFZ9ba86juuxQ6X3StJvvAqBWcI7PKqTWRgUN8Z2c2JhFxjUSlFp//41Nvm1yvT687Yn52Q8PpV2OkXnPKHpJkyOgiIHSewZGMqfqvWbUiLQe5ueTj55RFH14s2wOxPpVR2PDf05flCQICEladWeRGpdtchVni9i2sui5GSmHAFKFkZP0JMxXT4221O8K7xdVxgtNU6psoTf3/zR9CHThFdFOPQLbU8J52qpthSlcFH/yA6Hiuc9b3a30NBO175ekji0Q5lVI0gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o22W2svu8l0teJAz2itV5YAI1gq8rmqsm9WfR2J/tnw=; b=fNgHJ5lxzLpr6lVUu5q8IMsoMQUgbyeiUwSptoz5jn832Hhncdrd9ZGupxEFX/+Um2iAeLwL/wXTVkGl6k3mT13mqLbzKI6JSA1ee/xYnTqsmuNcGHowo/zDTLN6HEsx7uR+XpXQfF+z94cxKIBTUJ13rIKRcxCxLmcmvllhVz3+tV18w1kZEdvK9XjzWFRC6MtDCq0xdWvh5ZqSMtugjI6PGS9RAItc+Ip9J4cjmCHSp2l8pLRDnzStDNLbJndC9lHC9jUhfRUMeXs/ySQwXRPPMEndc+83/qogUrHLABVjds3XPGIGuwVs3VxMK7u+irvBXAFP4rlMxmPw+NLK3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o22W2svu8l0teJAz2itV5YAI1gq8rmqsm9WfR2J/tnw=; b=O3fzSMVA8x5YfKNLcaGtOBE57Azp3eaVK2cNcOfpMO2Lq82SU6FthF79wwsg5ftqc95xfSgNjDO9LSSRrcSm3BagRY1XimycOxXIXp1n19kXhaecuxQceFwngM5ueeehV2+7GM020YRSQLSScGG7u0Lh5uwvXVJnRDyuWoNOZem/FOJIiuunVojGHL5G7TkyQMILBn6uZrrDDV7ojHslJoUF1r+7b9R2AG1XlIQEOh9zCGEW2Vdlt7yk2fzoB3nLeKTpyjZB5AvwLmDssP1/DXFGVaEzhXgqKbe3KZAS940ZiAaYAuRGR6JPdktcK4bYFfpKq/0j5VD318Az1GfCHA== Received: from ME3P282MB3507.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:18a::13) by ME3P282MB2711.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:168::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 14:19:12 +0000 Received: from ME3P282MB3507.AUSP282.PROD.OUTLOOK.COM ([fe80::f437:b1a4:3950:938f]) by ME3P282MB3507.AUSP282.PROD.OUTLOOK.COM ([fe80::f437:b1a4:3950:938f%5]) with mapi id 15.20.5250.018; Wed, 18 May 2022 14:19:12 +0000 From: miterv@outlook.com To: ovs-dev@openvswitch.org Date: Wed, 18 May 2022 22:18:40 +0800 Message-ID: X-Mailer: git-send-email 2.36.1.windows.1 In-Reply-To: <20220518141841.958-1-miterv@outlook.com> References: <20220518141841.958-1-miterv@outlook.com> X-TMN: [iGQ+f/zcjOQHVUxRBMFslrXw287fSg7S] X-ClientProxiedBy: TYAPR01CA0007.jpnprd01.prod.outlook.com (2603:1096:404::19) To ME3P282MB3507.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:18a::13) X-Microsoft-Original-Message-ID: <20220518141841.958-2-miterv@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1316f50b-1466-448a-a5cf-08da38d96166 X-MS-TrafficTypeDiagnostic: ME3P282MB2711:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H7yZZLrl+A7/QZ2pIEEpYU+d/i57Kl5LHT/r946JL7f23pZjhL1si6gJG2xrsAcmPxlZXfqsHpQ7hmKOetiifbo8obSCzR9fbzQjlpLyVp/wzjZrjlz4DixGw6J/P+u0gsOd4/vM6lw3EbJ81yLQ/WzCFCghwzWejLGieafd8ZS2Ts6nqnWQ8UA62Sk2ziMWJ84lDlLLbvXUmhCUv6De/LPhLTKv9ri1aS06q9Hp9duD147/8o8GENQLufAyLZ0A4vZ8GwE+qAI0gR1Diqh7c5Wz/4ePlnBtCOgUJTv7b/b1uy7BD2r7B3d3wTiUeZBDoGkAj49te3q0eA6m+nFJnFGDc0yqHEra+q/sl4a5A3ZUSr8o5GxKwiSQsaxfV4T6+U3Uk9MoaZDyQObq7KfCXLwniUv+3m4Duaj2vfbZoGgx6poAzpEcXzYtfnvdLL5Ftlj/Wf/fQ9r3Vq5YzQtrPHczjcZ7uvzX71ZVTxghPasXvYgA0vK5mrjEs/p6j2Sjt4qz6SWvTTBZG6QKzdF6JgK4tFqeOPEPnz4lhiQjGxGns0IiXcAXATzqTCtKkFK1VJR498NplAWVIEd3bpmYMg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RqR+LtQjKdHN37ZsVRke2OPwIO1QbEMpjBmv0v+QL/GORvu7aaev4u8g02m3q6Y7KdD9hddWEWl1XUhVBARH566k4mTCVZLP66qcDElXrg4nNM5FZwps6BAgmq6u3UUNSSTlL2HgYTJPwZnp/AFr0aHoXVGF74gFgEEIzPwkBK/6MCWHLBVjN7S04adFuvg4xMorrU5AV5qEMglqOFV7lIgSd7ASWcPX9R8lN2/LVXg2TCANdp+gKNljFJX5ocmN4bK6ZUl/5Eug1vsfiC1eL5nXczVN2JWVGOtUpJVcMEN4uoff9vaUrA8UpasXO++bqaSKRYcd1RlncrJy6rYOo5ju6e6il4U76xObTEiip/DckWiQwsMVeTPd0WEBEWqYhsahbqrxSAiBGYm1CsKbwHvsf2HIFDCbc+kTwCXGvMIUNLsxYSJgwIX97z963iEK9rHzf9NWcw5sOOv6ctKOqsvghkD8Y+GgPYK17PbAIKZwfxwqxbkw5iIQ8TS+zPMdcJjpGxAoR5UtlR+ATRP1aFXhESRcbAYzdSP0g3YPaYuWYPL+/yd0wqur3ePpcW8hV/kCRyA5MBq/4fN2HhpS1aEblbx18RQD6VjMj6pCLj3mmePq3E/SX8OTUCXArVFtAKnqner+5WV6vmC3lm7MZbAZJ2M0PHIuV1k3zAwRF0XRzrxaAVBZBhc4bphZfbVEekJHGcJcRBHKLW5EaTq4Ysi1zGrRVsErkjkoaleNLNUrx1ChMS3kf+ui/RrJL85sv7yZR1asQjYLZiMd+gFL/0H+e4BcuDFT3W0adFDZzIPCspsEbdHQuicQ0wuIqJV3KoWUDnsesq9fvu5ucMmutSVvuy4SBc0fR8p8lq4GComgTlT713vuM/vxiIKCNOUjKXN5n+iDqR/2XF2ZluLojyH0b+IClKnH7J28f9ra11EgXqii60wLZVOzXXd82maRHPgnwoVVsP/vnbEfTBxR6IdgiNkhhOczVBNxCW1aq501SGoRRxPpHm1s79Di3/WaWkyNnuQDBJWvXZZ3e3s7fI0RYwJ2GYT+TxsZrzsdIKdtv5LEhJnVPSA6Q8v63vC6E8p1ejN0SPkVOTfaNAtN02i8NstSTYO/ImZFgJJOwMyR2G735vB274+VKDSVMADouvSxnxj+fpmVHhLMaYKpp125XGq28Q7QaaHAbraXCC5Yj2oY1AWAi+7tyx5cv/zom2pfJQXYZYZp+BNEsn9N/UYsElwSwtY+N8sRdGVL9MP8mZRiCKbHf2pmO3RB82lU2L6BC8+gCOQOYkVwYAZkEGaSX7EVeqWWZPFOSM9fQDsw3Cj3VDpx+BWu6FCQHdEo6HBGXqfob8IBORzqKMpxdEZEQC8uV6qvRaOY+8Jl7EUFDNKJdWuF7dSyxh26ElgRAXAIDe42+NHl/tVoj8eukWU1fmKl2ETvoj/reDsA47M= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1316f50b-1466-448a-a5cf-08da38d96166 X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB3507.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 14:19:12.2647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME3P282MB2711 Cc: Lin Huang Subject: [ovs-dev] [PATCH v4 1/2] dpif-netdev : Fix ALB parameters type mismatch. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Lin Huang The ALB parameters should never be negative. So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly. Fixes: 5bf84282482a ("Adding support for PMD auto load balancing") Signed-off-by: Lin Huang --- lib/dpif-netdev.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 21277b236..3597d7e40 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4880,8 +4880,9 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) struct pmd_auto_lb *pmd_alb = &dp->pmd_alb; - rebalance_intvl = smap_get_int(other_config, "pmd-auto-lb-rebal-interval", - ALB_REBALANCE_INTERVAL); + rebalance_intvl = smap_get_ullong(other_config, + "pmd-auto-lb-rebal-interval", + ALB_REBALANCE_INTERVAL); /* Input is in min, convert it to msec. */ rebalance_intvl = @@ -4894,9 +4895,9 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_improve = smap_get_int(other_config, - "pmd-auto-lb-improvement-threshold", - ALB_IMPROVEMENT_THRESHOLD); + rebalance_improve = smap_get_uint(other_config, + "pmd-auto-lb-improvement-threshold", + ALB_IMPROVEMENT_THRESHOLD); if (rebalance_improve > 100) { rebalance_improve = ALB_IMPROVEMENT_THRESHOLD; } @@ -4907,8 +4908,8 @@ dpif_netdev_set_config(struct dpif *dpif, const struct smap *other_config) log_autolb = true; } - rebalance_load = smap_get_int(other_config, "pmd-auto-lb-load-threshold", - ALB_LOAD_THRESHOLD); + rebalance_load = smap_get_uint(other_config, "pmd-auto-lb-load-threshold", + ALB_LOAD_THRESHOLD); if (rebalance_load > 100) { rebalance_load = ALB_LOAD_THRESHOLD; }