From patchwork Mon May 15 21:06:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shashank Ram X-Patchwork-Id: 762726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wRY5r6Q4fz9s7B for ; Tue, 16 May 2017 07:06:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=onevmw.onmicrosoft.com header.i=@onevmw.onmicrosoft.com header.b="oqSY5EI8"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 37FAAB5A; Mon, 15 May 2017 21:06:06 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D298F89E for ; Mon, 15 May 2017 21:06:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0047.outbound.protection.outlook.com [104.47.34.47]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A8A571F5 for ; Mon, 15 May 2017 21:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=c8Y/xkZCvywzqd2BnoBTkNQYaE+sBDTtJcTR1bzqT0w=; b=oqSY5EI8iq0SBOxoUhZraA4tsp7tKFUzAu+GFq2Tz65PYcHCHJ07bTCEsrZlNtleFAIwdpaRTu89xRV0bW7VwyqhfJujfsVA5n4qynwRodx0/v8At0yBJ7vgOxFy0+PXvxoQ3WGClZ/+UFO97nuVGEofuiPIXgvnk8GTniAPTL8= Received: from CY4PR05MB2805.namprd05.prod.outlook.com (10.169.182.139) by CY4PR05MB2807.namprd05.prod.outlook.com (10.169.182.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.8; Mon, 15 May 2017 21:06:02 +0000 Received: from CY4PR05MB2805.namprd05.prod.outlook.com ([10.169.182.139]) by CY4PR05MB2805.namprd05.prod.outlook.com ([10.169.182.139]) with mapi id 15.01.1101.009; Mon, 15 May 2017 21:06:02 +0000 From: Shashank Ram To: Alin Serdean , "dev@openvswitch.org" Thread-Topic: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt Thread-Index: AQHSxfMloy+MMKDAsEGH9uBFyMnZaaH17ceAgAACvgCAAAFsBg== Date: Mon, 15 May 2017 21:06:02 +0000 Message-ID: References: <20170505225743.10688-1-rams@vmware.com> <6FDA0CACF4BC624BBE12167875D71C9B4094560D@CBSEX1.cloudbase.local>, <6FDA0CACF4BC624BBE12167875D71C9B40945639@CBSEX1.cloudbase.local> In-Reply-To: <6FDA0CACF4BC624BBE12167875D71C9B40945639@CBSEX1.cloudbase.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cloudbasesolutions.com; dkim=none (message not signed) header.d=none; cloudbasesolutions.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [25.172.162.132] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR05MB2807; 7:9YWcv8yuKcdVrxz0OGHajk6QmbM6Do59jRRswfGvADmWtzIKD8dMA8Dv+9zOQMHHsVQrNWLdTKqeZgL9vTZ1xTCjYSpBVfuG8w8blSUj7wsp7CHzh1v9GHTc8yqdWbgK7PIOknshPF1HK/fppvlqrAMg4FW8Ld2lIBKCf8CChowI/NJYS/Nfn/6HFPGVDBZdNHLoGCB+hBlIXaZdYuWQnc3HAsB/IUXe686menbs83pQQdveZQ4iYfQSOGhHv8sKsKyw6qpe35+IPRU5WrMbeJYg9XrVn9sSfY9dyHn0ShtI/AvMlnM3V9wBItziSPRRTWCdtbPrsvTyIAV/kq0V4A==; 20:0fgoxdvo715fRhn4rcZkCMbFRwxz6JyUl1VU368rurD5mW7OqdyA29OG6Ze9srB//JyFT03Wrr6fyYah9btfznJ1Gyf0vobE5i2IcRQxUHzNrsgs+M9IF6fijIlSuPutdv1KqAvBs0I5F909RoR5qg2lQLH3fRtXtYGhpws0oDs= x-ms-traffictypediagnostic: CY4PR05MB2807: x-ms-office365-filtering-correlation-id: b55352e7-a399-4240-62ee-08d49bd6317d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:CY4PR05MB2807; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(61668805478150)(158342451672863)(216315784871565); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123564025)(6072148); SRVR:CY4PR05MB2807; BCL:0; PCL:0; RULEID:; SRVR:CY4PR05MB2807; x-forefront-prvs: 0308EE423E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39450400003)(39840400002)(39850400002)(39400400002)(39410400002)(377454003)(13464003)(229853002)(53546009)(5660300001)(25786009)(38730400002)(9686003)(2950100002)(3660700001)(2501003)(7696004)(122556002)(74316002)(50986999)(478600001)(76176999)(54356999)(575784001)(86362001)(3280700002)(81166006)(8676002)(6116002)(6246003)(102836003)(3846002)(7736002)(66066001)(33656002)(8936002)(189998001)(236005)(55016002)(53936002)(2906002)(54896002)(6506006)(77096006)(2900100001)(99286003)(6436002)(18265965002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR05MB2807; H:CY4PR05MB2805.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2017 21:06:02.0869 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB2807 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, WEIRD_QUOTING autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Subject: Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Alin, that will not work I guess, because the ProductVersion property should have the version in "x.x.x.x" format, not comma separated. Thanks, Shashank diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc index a7cf0a7..8896256 100644 --- a/datapath-windows/ovsext/ovsext.rc +++ b/datapath-windows/ovsext/ovsext.rc @@ -33,12 +33,12 @@ BEGIN BEGIN VALUE "CompanyName", "The Linux Foundation (R)" VALUE "FileDescription", "Open vSwitch Extension" - VALUE "FileVersion", STR(Version) + VALUE "FileVersion", STR(VersionWithCommas) VALUE "InternalName", "OVSExt.SYS" VALUE "LegalCopyright", "Licensed under the Apache License, Version 2.0 (the ""License"")" VALUE "OriginalFilename", "OVSExt.SYS" VALUE "ProductName", "Open vSwitch" - VALUE "ProductVersion", STR(Version) + VALUE "ProductVersion", STR(VersionWithCommas) END END BLOCK "VarFileInfo"