@@ -2679,12 +2679,19 @@ netdev_dpdk_set_qos(struct netdev *netdev,
/* Install new QoS configuration. */
error = new_ops->qos_construct(netdev, details);
- ovs_assert((error == 0) == (dev->qos_conf != NULL));
}
} else {
error = new_ops->qos_construct(netdev, details);
+ }
+
+ if (!error) {
ovs_assert((error == 0) == (dev->qos_conf != NULL));
}
+ else {
+ VLOG_ERR("Failed to set QoS type %s on port %s, returned error %d",
+ type, netdev->name, error);
+ ovs_assert(dev->qos_conf == NULL);
+ }
I think we can replace this with: