From patchwork Fri Jul 14 18:18:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Stringer X-Patchwork-Id: 788720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x8LYf5YHPz9s78 for ; Sat, 15 Jul 2017 04:19:18 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4343BCF1; Fri, 14 Jul 2017 18:19:17 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E574BC24 for ; Fri, 14 Jul 2017 18:19:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 412571ED for ; Fri, 14 Jul 2017 18:19:15 +0000 (UTC) Received: from mfilter10-d.gandi.net (mfilter10-d.gandi.net [217.70.178.139]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 06F371720B8 for ; Fri, 14 Jul 2017 20:19:14 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter10-d.gandi.net Received: from relay4-d.mail.gandi.net ([IPv6:::ffff:217.70.183.196]) by mfilter10-d.gandi.net (mfilter10-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id NjtO0HFnzmoh for ; Fri, 14 Jul 2017 20:19:12 +0200 (CEST) X-Originating-IP: 209.85.218.49 Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) (Authenticated sender: joe@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 783881720AF for ; Fri, 14 Jul 2017 20:19:12 +0200 (CEST) Received: by mail-oi0-f49.google.com with SMTP id l130so77857775oib.1 for ; Fri, 14 Jul 2017 11:19:12 -0700 (PDT) X-Gm-Message-State: AIVw110lg4+ZuVyQsko91JOrdwEHFF9cp/Dc9HnpXVg6NKy4Bzq3ztSI t7KceaVSL4P3sFjK8ZscVLJr8bAnHA== X-Received: by 10.202.87.130 with SMTP id l124mr5949779oib.180.1500056351024; Fri, 14 Jul 2017 11:19:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.136.67 with HTTP; Fri, 14 Jul 2017 11:18:50 -0700 (PDT) In-Reply-To: <20170707183254.GE23376@ovn.org> References: <20170607235427.15324-1-e@erig.me> <20170707183254.GE23376@ovn.org> From: Joe Stringer Date: Fri, 14 Jul 2017 11:18:50 -0700 X-Gmail-Original-Message-ID: Message-ID: To: Ben Pfaff X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: ovs dev , Eric Garver Subject: Re: [ovs-dev] [PATCH 0/4] system-traffic: Add basic IPv6 underlay tunnel tests X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org On 7 July 2017 at 11:32, Ben Pfaff wrote: > On Wed, Jun 07, 2017 at 07:54:23PM -0400, Eric Garver wrote: >> Currently there is no system-traffic coverage for tunnels with IPv6 underlays. >> This series adds very basic ping tests for VXLANv6 and GENEVEv6. >> >> Note: GREv6 is not added by this series due to some incompatibilities between >> OVS and Linux native ip6gretap. More info available in bugzilla [0]. >> >> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1459605 >> >> Eric Garver (4): >> system-common-macros: Add ip_addr_flags argument to ADD_VETH() >> system-common-macros: Add macros to create IPv6 tunnels >> system-traffic: datapath: Add vxlan6 test case. >> system-traffic: datapath: Add geneve6 test case. > > Joe, are you the right person to review these? Slowly catching up on my backlog, sorry for the delay. Yes. Eric, thanks for the series. For the first patch, I think that it'd be nice to apply this for all IPv6 tests to speed them up. Given that we assume control of the host for running these tests, I don't think there's any situation where we actually want duplicate address detection here. I looked to see if we could change the addresses in the testsuite, for example to use link-local IPv6 addresses which I think could avoid DAD, but if we did this then we would need to update all of the pings and wgets and so on to specify a device; as it turns out, even quite recent versions of wget do not parse the arguments reliably to be able to do this. So, I think this would be more hassle than it's worth. For now, we should stick with IPv6 ULAs (fc00:) for the testsuite and just see if we can edge towards always disabling DAD. I intend to apply this series as-is shortly, with just the following incremental to skip the geneve6 test when iproute can't configure it properly: ADD_BR([br-underlay]) Cheers, Joe diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 2c3b2f9880c8..5b4c515cb0c5 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -382,6 +382,7 @@ AT_CLEANUP AT_SETUP([datapath - ping over geneve6 tunnel]) OVS_CHECK_GENEVE() +AT_SKIP_IF([! ip link add foo type geneve help 2>&1 | grep zerocsum >/dev/null]) OVS_TRAFFIC_VSWITCHD_START()