| Message ID | BY2PR0501MB211980DD124111FB51821E2DA2AD0@BY2PR0501MB2119.namprd05.prod.outlook.com |
|---|---|
| State | Not Applicable |
| Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x8JYl0NkKz9s76 for <incoming@patchwork.ozlabs.org>; Sat, 15 Jul 2017 02:49:15 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=onevmw.onmicrosoft.com header.i=@onevmw.onmicrosoft.com header.b="kqd++JRq"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 03DB6C7E; Fri, 14 Jul 2017 16:49:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 01732C0D for <dev@openvswitch.org>; Fri, 14 Jul 2017 16:49:09 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0052.outbound.protection.outlook.com [104.47.33.52]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9E62D151 for <dev@openvswitch.org>; Fri, 14 Jul 2017 16:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6E9jnDohBd3DzFgAne35JI4owDMYy8GhzKtfeXVf7ms=; b=kqd++JRqXUJckFznC0U2FkALquUa1UAR/OKNJJ/YeC2ZZBKI7rK6X9I3z54stA9upvAogERFc7dviSoCob8ojnhVIze33LmIANJFNoS3BW6twKTNvCXBu0r3ERZbq69vn3xsm5+gNOTscVp+RdDabeduWGsNlxntt401XC7E4pA= Received: from BY2PR0501MB2119.namprd05.prod.outlook.com (10.163.198.17) by BY2PR0501MB2102.namprd05.prod.outlook.com (10.163.198.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.4; Fri, 14 Jul 2017 16:49:04 +0000 Received: from BY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) by BY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) with mapi id 15.01.1282.005; Fri, 14 Jul 2017 16:49:04 +0000 From: Shashank Ram <rams@vmware.com> To: Alin Serdean <aserdean@cloudbasesolutions.com>, "dev@openvswitch.org" <dev@openvswitch.org> Thread-Topic: [ovs-dev] [PATCH 05/40] datapath-windows: Fix possible NULL dereference in IpFragment Thread-Index: AQHS/FwBJG/kqkj+ZUCKKrIkIFT7jaJTiRLv Date: Fri, 14 Jul 2017 16:49:04 +0000 Message-ID: <BY2PR0501MB211980DD124111FB51821E2DA2AD0@BY2PR0501MB2119.namprd05.prod.outlook.com> References: <20170714044033.15196-1-aserdean@cloudbasesolutions.com>, <20170714044033.15196-6-aserdean@cloudbasesolutions.com> In-Reply-To: <20170714044033.15196-6-aserdean@cloudbasesolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cloudbasesolutions.com; dkim=none (message not signed) header.d=none; cloudbasesolutions.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [208.91.1.34] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BY2PR0501MB2102; 20:fBRNYyCQ97jt1MfkrDxeNY456jUDeJrVjUhp1gTj8PNCjqUSAbu9obYs/8/cr08XY0zTefshhnDQth1ihbsBqYQHtc1jzJsrM/cqFBgcuiIsWeC92PkaH6FqebVCDq6jMrUKKE2IjGDM1GkcRLvM/WwcYztnOMpgHYlpvNyhUQE= x-ms-office365-filtering-correlation-id: f908f2a9-128a-46e9-e9cd-08d4cad83cb1 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR0501MB2102; x-ms-traffictypediagnostic: BY2PR0501MB2102: x-exchange-antispam-report-test: UriScan:(216315784871565)(236129657087228); x-microsoft-antispam-prvs: <BY2PR0501MB2102EB7BAC06C936B5B2B0B6A2AD0@BY2PR0501MB2102.namprd05.prod.outlook.com> x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0501MB2102; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0501MB2102; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6029001)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39400400002)(377454003)(2501003)(8676002)(81166006)(305945005)(3280700002)(25786009)(74316002)(9686003)(7736002)(3660700001)(53546010)(14454004)(102836003)(86362001)(6116002)(5660300001)(3846002)(6246003)(2900100001)(55016002)(66066001)(99286003)(38730400002)(478600001)(229853002)(53936002)(2950100002)(6436002)(189998001)(2906002)(7696004)(77096006)(8936002)(54356999)(33656002)(50986999)(6506006)(76176999); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0501MB2102; H:BY2PR0501MB2119.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2017 16:49:04.4871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0501MB2102 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [ovs-dev] [PATCH 05/40] datapath-windows: Fix possible NULL dereference in IpFragment X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c index e601a15..eb278ef 100644 --- a/datapath-windows/ovsext/IpFragment.c +++ b/datapath-windows/ovsext/IpFragment.c @@ -205,7 +205,7 @@ OvsIpv4Reassemble(POVS_SWITCH_CONTEXT switchContext, *newNbl = OvsAllocateNBLFromBuffer(switchContext, packetBuf, packetLen); if (*newNbl == NULL) { OVS_LOG_ERROR("Insufficient resources, failed to allocate newNbl"); - status = NDIS_STATUS_RESOURCES; + return NDIS_STATUS_RESOURCES; ---- This will result in a memory leak because packetBuf is allocated above and not freed yet. packetBuf = (CHAR*)OvsAllocateMemoryWithTag(packetLen,