From patchwork Wed Feb 17 16:34:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaetan Rivet X-Patchwork-Id: 1441288 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=u256.net header.i=@u256.net header.a=rsa-sha256 header.s=fm1 header.b=l6wh6gQ7; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=uInqIt7F; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DgkBR543Jz9sSC for ; Thu, 18 Feb 2021 03:41:35 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3E15486CAC; Wed, 17 Feb 2021 16:41:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0D4OY3obbQR; Wed, 17 Feb 2021 16:41:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 2415E86DB3; Wed, 17 Feb 2021 16:41:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 16B31C1E6F; Wed, 17 Feb 2021 16:41:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3A825C013A for ; Wed, 17 Feb 2021 16:41:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 36FF487220 for ; Wed, 17 Feb 2021 16:41:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5F8b+kdnFmFH for ; Wed, 17 Feb 2021 16:41:10 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0871D87239 for ; Wed, 17 Feb 2021 16:41:10 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id A75B4580359; Wed, 17 Feb 2021 11:34:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 17 Feb 2021 11:34:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=yy1co82+mvulp qoZGEQP0Dgi0TlxruCYSZUnrnKQiO0=; b=l6wh6gQ7Zl0J2ok1Yv4MLSjuOt3XU +6A9+0m8E9I/9vIUPPjWolWC/dLJF8ppyks1K3Pcsm1YrFgWsDQwt3OcHsINZ7dx ZRNYUbQQIfyWzzMsgE7MdE/lGKxnaxYNykHbwlWjzKtfUkSw9Ew2z/uW7iQ66wfD W0vtVKU8Yns3INyC35Bwd6VHcFKdoUKgBVJijY+y/OuYWhghkQKVPGVTV1e6mp4/ NNVt3oXp9uwAlKLgk02iZS81dZsnrrG+XisLpw1oSPNQpaWMh2a4v/lDq7o+JWKF IeBPz8Q8HB7qlbjdt5jHCi/9Tktu2kSC6uVNCU0Pe2yxkxlBZSPacJ/7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=yy1co82+mvulpqoZGEQP0Dgi0TlxruCYSZUnrnKQiO0=; b=uInqIt7F D3AbrU4ZE2U+lCGhWZEG8BAf0g+4LEsBmuqgp+XxxbLHwUxBxADUFTx4fSfSqJGL RY1nC+mlcAYmUsr7vbOFhd3GZj4YYZ0J+Xw3yn4IxSWfbbCklEc0HLvH5+3Renz3 MfUsB6pHPuNmaAvCW6nA0R0P09fy0UErrqpEGTc6lg/6GPeMJxknJVYsvy6JfQfG DHr+54ELYXlIB/m4VLyW2bAqpHj+xqNxpfkkyz2dqs4W1QEyX2vIOSC31rMS6oPE pa7GUi0K8EKqdT2o0zVvdmzkd1IDoPnVkr19sh7PVYh5SJXgUoAA41XjNyRWnNsp t8+t+04IcrQbbA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjedvgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepifgrvghtrghn ucftihhvvghtuceoghhrihhvvgesuhdvheeirdhnvghtqeenucggtffrrghtthgvrhhnpe ehgfevffekteehteefieefvdehleefjeefheevudetjefhkeeutdekieeuvdetheenucfk phepkeeirddvheegrddvgeefrddugeeinecuvehluhhsthgvrhfuihiivgepfeenucfrrg hrrghmpehmrghilhhfrhhomhepghhrihhvvgesuhdvheeirdhnvght X-ME-Proxy: Received: from inocybe.home (lfbn-poi-1-930-146.w86-254.abo.wanadoo.fr [86.254.243.146]) by mail.messagingengine.com (Postfix) with ESMTPA id E3021240065; Wed, 17 Feb 2021 11:34:52 -0500 (EST) From: Gaetan Rivet To: dev@openvswitch.org Date: Wed, 17 Feb 2021 17:34:42 +0100 Message-Id: <9940347db5b3f2107001b5c0f89630bcfb9c3898.1613557616.git.grive@u256.net> X-Mailer: git-send-email 2.30.0 In-Reply-To: References: MIME-Version: 1.0 Cc: Eli Britstein , ameerm@nvidia.com, majd@nvidia.com Subject: [ovs-dev] [PATCH v1 8/9] conntrack: Do not log empty ct-sweep X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Do not add noise to the DBG log for empty sweeps. Only log time taken when some connections were cleaned. Signed-off-by: Gaetan Rivet Reviewed-by: Eli Britstein Acked-by: William Tu --- lib/conntrack.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 1b21b79bd..e042683aa 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1574,8 +1574,10 @@ ct_sweep(struct conntrack *ct, long long now, size_t limit) } out: - VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count, - time_msec() - now); + if (count > 0) { + VLOG_DBG("conntrack cleanup %"PRIuSIZE" entries in %lld msec", count, + time_msec() - now); + } return min_expiration; }