From patchwork Tue Sep 29 08:37:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: XiaoXiong Ding X-Patchwork-Id: 1373143 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C0t732lKdz9sRR for ; Tue, 29 Sep 2020 18:37:32 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 27139870BA; Tue, 29 Sep 2020 08:37:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EKS-zz6PZ+RX; Tue, 29 Sep 2020 08:37:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id E986986FC4; Tue, 29 Sep 2020 08:37:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BA3D3C0889; Tue, 29 Sep 2020 08:37:29 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5DE33C0051 for ; Tue, 29 Sep 2020 08:37:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5805F86706 for ; Tue, 29 Sep 2020 08:37:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pTZPqxvqyupj for ; Tue, 29 Sep 2020 08:37:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from huawei.com (szxga08-in.huawei.com [45.249.212.255]) by whitealder.osuosl.org (Postfix) with ESMTPS id 93DE586519 for ; Tue, 29 Sep 2020 08:37:24 +0000 (UTC) Received: from dggeme702-chm.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id C80B4A3884588D54A840; Tue, 29 Sep 2020 16:37:10 +0800 (CST) Received: from dggeme761-chm.china.huawei.com (10.3.19.107) by dggeme702-chm.china.huawei.com (10.1.199.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 29 Sep 2020 16:37:10 +0800 Received: from dggeme761-chm.china.huawei.com ([10.6.66.35]) by dggeme761-chm.china.huawei.com ([10.6.66.35]) with mapi id 15.01.1913.007; Tue, 29 Sep 2020 16:37:10 +0800 From: dingxiaoxiong To: "dev@openvswitch.org" Thread-Topic: [PATCH] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports. Thread-Index: AQHWljrTXHUW9cpgB0WzSoYwTc5gKql/ShPA Date: Tue, 29 Sep 2020 08:37:10 +0000 Message-ID: <979cbc6b298f42b29c82f135675543ae@huawei.com> References: <20200929083033.140584-1-dingxiaoxiong@huawei.com> In-Reply-To: <20200929083033.140584-1-dingxiaoxiong@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.243.44] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: "fbl@sysclose.org" , "Guohongzhi \(Russell Lab\)" Subject: [ovs-dev] =?eucgb2312_cn?b?tPC4tDogW1BBVENIXSBvZnByb3RvLWRwaWYteGxhdGU6?= =?eucgb2312_cn?b?IFN0b3AgZm9yd2FyZGluZyBNTEQgcmVwb3J0cyB0byBncm91cCBwb3J0cy4=?= X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" I am a litter busy on my project right now , I suppose to add the test case after a while. -----邮件原件----- 发件人: dingxiaoxiong 发送时间: 2020年9月29日 16:31 收件人: dev@openvswitch.org 抄送: fbl@sysclose.org; Guohongzhi (Russell Lab) ; dingxiaoxiong 主题: [PATCH] ofproto-dpif-xlate: Stop forwarding MLD reports to group ports. According with rfc4541 section 2.1.1, a snooping switch should forward membership reports only to ports with routers attached. The current code violates the RFC forwarding membership reports to group ports as well. The same issue doesn't exist with IPv4. Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") Signed-off-by: XiaoXiong Ding --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index e0ede2cab..47571e790 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -3100,6 +3100,7 @@ xlate_normal(struct xlate_ctx *ctx) xlate_report(ctx, OFT_DETAIL, "MLD query, flooding"); xlate_normal_flood(ctx, in_xbundle, &xvlan); } + return; } else { if (is_ip_local_multicast(flow, wc)) { /* RFC4541: section 2.1.2, item 2: Packets with a dst IP