diff mbox series

[ovs-dev,09/41] dpif-offload-dpdk: Add port management framework.

Message ID 7f738279a8e0bb59823feed4cdc350ca4de9c6ae.1762950453.git.echaudro@redhat.com
State Changes Requested
Headers show
Series Architectural refactoring of hardware offload infrastructure | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Eelco Chaudron Nov. 12, 2025, 3:35 p.m. UTC 
Existing dpdk offload provider is updated to use the new
framework for port management.

Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
 lib/dpif-offload-dpdk.c | 86 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 86 insertions(+)

Comments

0-day Robot Nov. 14, 2025, 2:16 p.m. UTC | #1 
Git SHA: 7f738279a8e0bb59823feed4cdc350ca4de9c6ae
Author: Eelco Chaudron <echaudro@redhat.com>
Subject: dpif-offload-dpdk: Add port management framework.

This commit updates the existing DPDK offload provider to use the new
framework for port management, adding port registration, cleanup, and
configuration support.

> diff --git a/lib/dpif-offload-dpdk.c b/lib/dpif-offload-dpdk.c
> index 76e0ba15f..be33346a4 100644
> --- a/lib/dpif-offload-dpdk.c
> +++ b/lib/dpif-offload-dpdk.c
> @@ -15,6 +15,7 @@
>   */
>  
>  #include <config.h>
> +#include <errno.h>
>  
>  #include "dpif-offload.h"
>  #include "dpif-offload-provider.h"
> @@ -34,6 +35,7 @@ static unsigned int offload_thread_nb = DEFAULT_OFFLOAD_THREAD_NB;
>  /* dpif offload interface for the dpdk rte_flow implementation. */
>  struct dpif_offload_dpdk {
>      struct dpif_offload offload;
> +    struct dpif_offload_port_mgr *port_mgr;
>  
>      /* Configuration specific variables. */
>      struct ovsthread_once once_enable; /* Track first-time enablement. */
> @@ -46,6 +48,59 @@ dpif_offload_dpdk_cast(const struct dpif_offload *offload)
>      return CONTAINER_OF(offload, struct dpif_offload_dpdk, offload);
>  }
>  
> +static int
> +dpif_offload_dpdk_enable_offload(struct dpif_offload *offload_,
> +                                 struct dpif_offload_port_mgr_port *port)
> +{
> +    dpif_offload_set_netdev_offload(port->netdev, offload_);
> +    return 0;
> +}
> +
> +static int
> +dpif_offload_dpdk_cleanup_offload(struct dpif_offload *offload_ OVS_UNUSED,
> +                                  struct dpif_offload_port_mgr_port *port)
> +{
> +    dpif_offload_set_netdev_offload(port->netdev, NULL);
> +    return 0;
> +}
> +
> +static int
> +dpif_offload_dpdk_port_add(struct dpif_offload *offload_,
> +                           struct netdev *netdev, odp_port_t port_no)
> +{
> +    struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_);
> +    struct dpif_offload_port_mgr_port *port = xmalloc(sizeof *port);
> +
> +    if (dpif_offload_port_mgr_add(offload->port_mgr, port, netdev,
> +                                  port_no, false)) {

Does this code leak the allocated port structure when 
dpif_offload_port_mgr_add() fails but returns true, causing the 
function to exit early without freeing the memory?

> +        if (dpif_offload_is_offload_enabled()) {
> +            return dpif_offload_dpdk_enable_offload(offload_, port);

Does dpif_offload_dpdk_port_add leak the port structure when 
dpif_offload_dpdk_enable_offload() fails and returns a non-zero error 
code?

> +        }
> +        return 0;
> +    }
> +
> +    free(port);
> +    return EEXIST;
> +}

[ ... ]

> @@ -125,6 +209,8 @@ struct dpif_offload_class dpif_offload_dpdk_class = {
>      .close = dpif_offload_dpdk_close,
>      .set_config = dpif_offload_dpdk_set_config,
>      .can_offload = dpif_offload_dpdk_can_offload,
> +    .port_add = dpif_offload_dpdk_port_add,
> +    .port_del = dpif_offload_dpdk_port_del,
>  };
diff mbox series

Patch

diff --git a/lib/dpif-offload-dpdk.c b/lib/dpif-offload-dpdk.c
index 76e0ba15f..be33346a4 100644
--- a/lib/dpif-offload-dpdk.c
+++ b/lib/dpif-offload-dpdk.c
@@ -15,6 +15,7 @@ 
  */
 
 #include <config.h>
+#include <errno.h>
 
 #include "dpif-offload.h"
 #include "dpif-offload-provider.h"
@@ -34,6 +35,7 @@  static unsigned int offload_thread_nb = DEFAULT_OFFLOAD_THREAD_NB;
 /* dpif offload interface for the dpdk rte_flow implementation. */
 struct dpif_offload_dpdk {
     struct dpif_offload offload;
+    struct dpif_offload_port_mgr *port_mgr;
 
     /* Configuration specific variables. */
     struct ovsthread_once once_enable; /* Track first-time enablement. */
@@ -46,6 +48,59 @@  dpif_offload_dpdk_cast(const struct dpif_offload *offload)
     return CONTAINER_OF(offload, struct dpif_offload_dpdk, offload);
 }
 
+static int
+dpif_offload_dpdk_enable_offload(struct dpif_offload *offload_,
+                                 struct dpif_offload_port_mgr_port *port)
+{
+    dpif_offload_set_netdev_offload(port->netdev, offload_);
+    return 0;
+}
+
+static int
+dpif_offload_dpdk_cleanup_offload(struct dpif_offload *offload_ OVS_UNUSED,
+                                  struct dpif_offload_port_mgr_port *port)
+{
+    dpif_offload_set_netdev_offload(port->netdev, NULL);
+    return 0;
+}
+
+static int
+dpif_offload_dpdk_port_add(struct dpif_offload *offload_,
+                           struct netdev *netdev, odp_port_t port_no)
+{
+    struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_);
+    struct dpif_offload_port_mgr_port *port = xmalloc(sizeof *port);
+
+    if (dpif_offload_port_mgr_add(offload->port_mgr, port, netdev,
+                                  port_no, false)) {
+        if (dpif_offload_is_offload_enabled()) {
+            return dpif_offload_dpdk_enable_offload(offload_, port);
+        }
+        return 0;
+    }
+
+    free(port);
+    return EEXIST;
+}
+
+static int
+dpif_offload_dpdk_port_del(struct dpif_offload *offload_, odp_port_t port_no)
+{
+    struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_);
+    struct dpif_offload_port_mgr_port *port;
+    int ret = 0;
+
+    port = dpif_offload_port_mgr_remove(offload->port_mgr, port_no, true);
+    if (port) {
+        if (dpif_offload_is_offload_enabled()) {
+            ret = dpif_offload_dpdk_cleanup_offload(offload_, port);
+        }
+        netdev_close(port->netdev);
+        ovsrcu_postpone(free, port);
+    }
+    return ret;
+}
+
 static int
 dpif_offload_dpdk_open(const struct dpif_offload_class *offload_class,
                        struct dpif *dpif, struct dpif_offload **offload_)
@@ -55,20 +110,45 @@  dpif_offload_dpdk_open(const struct dpif_offload_class *offload_class,
     offload = xmalloc(sizeof(struct dpif_offload_dpdk));
 
     dpif_offload_init(&offload->offload, offload_class, dpif);
+    offload->port_mgr = dpif_offload_port_mgr_init();
     offload->once_enable = (struct ovsthread_once) OVSTHREAD_ONCE_INITIALIZER;
 
     *offload_ = &offload->offload;
     return 0;
 }
 
+static bool
+dpif_offload_dpdk_cleanup_port(struct dpif_offload_port_mgr_port *port,
+                               void *aux)
+{
+    struct dpif_offload *offload_ = aux;
+
+    dpif_offload_dpdk_port_del(offload_, port->port_no);
+    return false;
+}
+
 static void
 dpif_offload_dpdk_close(struct dpif_offload *offload_)
 {
     struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_);
 
+    dpif_offload_port_mgr_traverse_ports(offload->port_mgr,
+                                         dpif_offload_dpdk_cleanup_port,
+                                         offload_);
+
+    dpif_offload_port_mgr_uninit(offload->port_mgr);
     free(offload);
 }
 
+static bool dpif_offload_dpdk_late_enable(struct dpif_offload_port_mgr_port *p,
+                                          void *aux)
+{
+    struct dpif_offload *offload_ = aux;
+
+    dpif_offload_dpdk_enable_offload(offload_, p);
+    return false;
+}
+
 static void
 dpif_offload_dpdk_set_config(struct dpif_offload *offload_,
                              const struct smap *other_cfg)
@@ -97,6 +177,10 @@  dpif_offload_dpdk_set_config(struct dpif_offload *offload_,
                           offload_thread_nb > 1 ? "s" : "");
             }
 
+            dpif_offload_port_mgr_traverse_ports(offload->port_mgr,
+                                                 dpif_offload_dpdk_late_enable,
+                                                 offload);
+
             ovsthread_once_done(&offload->once_enable);
         }
     }
@@ -125,6 +209,8 @@  struct dpif_offload_class dpif_offload_dpdk_class = {
     .close = dpif_offload_dpdk_close,
     .set_config = dpif_offload_dpdk_set_config,
     .can_offload = dpif_offload_dpdk_can_offload,
+    .port_add = dpif_offload_dpdk_port_add,
+    .port_del = dpif_offload_dpdk_port_del,
 };
 
 /* XXX: Temporary functions below, which will be removed once fully