From patchwork Mon May 15 21:19:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alin Serdean X-Patchwork-Id: 762728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wRYPV1r29z9s75 for ; Tue, 16 May 2017 07:19:42 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E4945B5D; Mon, 15 May 2017 21:19:38 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0C957B1F for ; Mon, 15 May 2017 21:19:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.cloudbasesolutions.com (mail.cloudbasesolutions.com [91.232.152.5]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 06482213 for ; Mon, 15 May 2017 21:19:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id 24FF641B41; Tue, 16 May 2017 00:19:35 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from mail.cloudbasesolutions.com ([127.0.0.1]) by localhost (mail.cloudbasesolutions.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I7yoEriLOXgn; Tue, 16 May 2017 00:19:34 +0300 (EEST) Received: from mail.cloudbasesolutions.com (unknown [10.77.78.3]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id BC43F41B13; Tue, 16 May 2017 00:19:34 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0319.002; Mon, 15 May 2017 23:19:34 +0200 From: Alin Serdean To: Shashank Ram , "dev@openvswitch.org" Thread-Topic: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt Thread-Index: AQHSxfMt/g6cysc8uE+uqDIPbZOXIaH167Fw///jQoCAACRqEA== Date: Mon, 15 May 2017 21:19:33 +0000 Message-ID: <6FDA0CACF4BC624BBE12167875D71C9B40945674@CBSEX1.cloudbase.local> References: <20170505225743.10688-1-rams@vmware.com>, <6FDA0CACF4BC624BBE12167875D71C9B4094560D@CBSEX1.cloudbase.local> In-Reply-To: Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RP_MATCHES_RCVD,WEIRD_QUOTING autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Subject: Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Sorry I cut a bit to much. Like the following (also attached): --- datapath-windows/ovsext/ovsext.rc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) BEGIN VALUE "CompanyName", "The Linux Foundation (R)" VALUE "FileDescription", "Open vSwitch Extension" - VALUE "FileVersion", STR(Version) + VALUE "FileVersion", STR(VersionWithCommas) VALUE "InternalName", "OVSExt.SYS" VALUE "LegalCopyright", "Licensed under the Apache License, Version 2.0 (the ""License"")" VALUE "OriginalFilename", "OVSExt.SYS" VALUE "ProductName", "Open vSwitch" - VALUE "ProductVersion", STR(Version) + VALUE "ProductVersion", VER_TO_STR(VersionWithCommas) END END BLOCK "VarFileInfo" -- 2.10.2.windows.1 Versions should be comma separated. Thanks, Alin. diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc index a7cf0a7..20e54bf 100644 --- a/datapath-windows/ovsext/ovsext.rc +++ b/datapath-windows/ovsext/ovsext.rc @@ -9,6 +9,7 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US #pragma code_page(1252) #define STR(x) #x +#define VER_TO_STR(x) STR(x) ///////////////////////////////////////////////////////////////////////////// // // Version @@ -33,12 +34,12 @@ BEGIN