From patchwork Tue Sep 1 23:28:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Amaral X-Patchwork-Id: 513101 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id EC47114018C for ; Wed, 2 Sep 2015 09:28:21 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id EDAFD1097E; Tue, 1 Sep 2015 16:28:20 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 36DFF102F4 for ; Tue, 1 Sep 2015 16:28:19 -0700 (PDT) Received: from bar5.cudamail.com (localhost [127.0.0.1]) by mx1e3.cudamail.com (Postfix) with ESMTPS id 9AEEE420570 for ; Tue, 1 Sep 2015 17:28:18 -0600 (MDT) X-ASG-Debug-ID: 1441150095-09eadd133c9f6e0001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar5.cudamail.com with ESMTP id yEIre2TzRkejTAvX (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 01 Sep 2015 17:28:15 -0600 (MDT) X-Barracuda-Envelope-From: marcelo.amaral@bsc.es X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO opsmail01.bsc.es) (84.88.52.34) by mx1-pf2.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 1 Sep 2015 23:28:15 -0000 Received-SPF: pass (mx1-pf2.cudamail.com: SPF record at bsc.es designates 84.88.52.34 as permitted sender) X-Barracuda-Apparent-Source-IP: 84.88.52.34 X-Barracuda-RBL-IP: 84.88.52.34 Received: from localhost (localhost [127.0.0.1]) by opsmail01.bsc.es (Postfix) with ESMTP id 32DB831F52 for ; Wed, 2 Sep 2015 01:28:12 +0200 (CEST) Received: from opsmail01.bsc.es ([127.0.0.1]) by localhost (opswc01.bsc.es [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02227-03 for ; Wed, 2 Sep 2015 01:28:11 +0200 (CEST) Received: from opswc01.bsc.es (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by opsmail01.bsc.es (Postfix) with ESMTPS id 35C2FB0CB4 for ; Wed, 2 Sep 2015 01:28:11 +0200 (CEST) Received: (from filter@localhost) by opswc01.bsc.es (8.13.6/8.13.6/Submit) id t81NSBfv010994 for dev@openvswitch.org; Wed, 2 Sep 2015 01:28:11 +0200 Received: from [192.168.0.8] (unknown [201.6.193.99]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by opsmail01.bsc.es (Postfix) with ESMTPSA id 57FFBB0CE4 for ; Wed, 2 Sep 2015 01:28:09 +0200 (CEST) Message-ID: <55E63484.3000801@bsc.es> Date: Tue, 01 Sep 2015 20:28:04 -0300 X-CudaMail-Envelope-Sender: marcelo.amaral@bsc.es From: Marcelo Amaral User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: dev@openvswitch.org X-CudaMail-MID: CM-E2-831098087 X-CudaMail-DTE: 090115 X-CudaMail-Originating-IP: 84.88.52.34 X-ASG-Orig-Subj: [##CM-E2-831098087##][PATCH] lib: meta-flow.h Remove restriction on modifying ICMP packets. X-Copyrighted-Material: Please visit http://www.bsc.es/disclaimer.htm X-Virus-Scanned: amavisd-new at bsc.es X-GBUdb-Analysis: 0, 84.88.52.34, Ugly c=0 p=0 Source New X-MessageSniffer-Rules: 0-0-0-14921-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1441150095 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using per-user scores of TAG_LEVEL=3.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=3.0 tests=BSF_SC5_MJ1963, HTML_MESSAGE, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.22138 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 HTML_MESSAGE BODY: HTML included in message 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Subject: [ovs-dev] [PATCH] lib: meta-flow.h Remove restriction on modifying ICMP packets. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" Signed-off-by: Marcelo Amaral When OpenStack create a virtual router using OpenDaylight, the default gateway does not respond ping, since it does not implement the full network stack. The solution is the reply the gateway pings from OVS. However, currently OVS does not allow changing icmp message type and code, because the attributes are read only. The patch is simply changing those attributes to read/write. The changes were verified via make check. diff --git a/lib/meta-flow.h b/lib/meta-flow.h index cfc6263..51f6909 100644 --- a/lib/meta-flow.h +++ b/lib/meta-flow.h @@ -1466,7 +1466,7 @@ enum OVS_PACKED_ENUM mf_field_id { * Maskable: no. * Formatting: decimal. * Prerequisites: ICMPv4. - * Access: read-only. + * Access: read/write. * NXM: NXM_OF_ICMP_TYPE(13) since v1.1. * OXM: OXM_OF_ICMPV4_TYPE(19) since OF1.2 and v1.7. * OF1.0: exact match. @@ -1482,7 +1482,7 @@ enum OVS_PACKED_ENUM mf_field_id { * Maskable: no. * Formatting: decimal. * Prerequisites: ICMPv4. - * Access: read-only. + * Access: read/write. * NXM: NXM_OF_ICMP_CODE(14) since v1.1. * OXM: OXM_OF_ICMPV4_CODE(20) since OF1.2 and v1.7. * OF1.0: exact match.