diff mbox

[ovs-dev,v3] datapath-windows: cleanup after NdisRegisterDeviceEx()

Message ID 508339EC0242094682895ED3EC4EBA31502F20@CBSEX1.cloudbase.local
State Not Applicable
Headers show

Commit Message

Paul Boca April 12, 2016, 5:39 p.m. UTC 
Acked-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>


-----Original Message-----
From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Nithin Raju

Sent: Tuesday, April 12, 2016 8:12 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v3] datapath-windows: cleanup after NdisRegisterDeviceEx()

The error handling code seems to be wrong.

Signed-off-by: Nithin Raju <nithin@vmware.com>

---
 datapath-windows/ovsext/Datapath.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

-- 
2.6.2

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
diff mbox

Patch

diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
index 8c0c246..0a25af0 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -459,17 +459,11 @@  OvsCreateDeviceObject(NDIS_HANDLE ovsExtDriverHandle)
                                   &deviceAttributes,
                                   &gOvsDeviceObject,
                                   &gOvsDeviceHandle);
-    if (status != NDIS_STATUS_SUCCESS) {
-        POVS_DEVICE_EXTENSION ovsExt =
-            (POVS_DEVICE_EXTENSION)NdisGetDeviceReservedExtension(gOvsDeviceObject);
-        ASSERT(gOvsDeviceObject != NULL);
-        ASSERT(gOvsDeviceHandle != NULL);
-
-        if (ovsExt) {
-            ovsExt->numberOpenInstance = 0;
-        }
-    } else {
+    if (status == NDIS_STATUS_SUCCESS) {
         OvsRegisterSystemProvider((PVOID)gOvsDeviceObject);
+    } else {
+        OVS_LOG_ERROR("Failed to regiser pseudo device, error: 0x%08x",
+                      status);
     }
 
     OVS_LOG_TRACE("DeviceObject: %p", gOvsDeviceObject);