From patchwork Wed Aug 31 07:45:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Boca X-Patchwork-Id: 664411 X-Patchwork-Delegate: guru@ovn.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3sPHWQ0hPvz9sC3 for ; Wed, 31 Aug 2016 17:46:08 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 66A36108B9; Wed, 31 Aug 2016 00:46:07 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id A1520108B5 for ; Wed, 31 Aug 2016 00:46:06 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id C890616239F for ; Wed, 31 Aug 2016 01:46:05 -0600 (MDT) X-ASG-Debug-ID: 1472629561-0b3237762d77c30001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar6.cudamail.com with ESMTP id 9mtzFyVDf25H1LR2 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 31 Aug 2016 01:46:01 -0600 (MDT) X-Barracuda-Envelope-From: pboca@cloudbasesolutions.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO cbssmtp1.cloudbase.local) (91.232.152.5) by mx3-pf3.cudamail.com with SMTP; 31 Aug 2016 07:46:00 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at cloudbasesolutions.com designates 91.232.152.5 as permitted sender) X-Barracuda-Apparent-Source-IP: 91.232.152.5 X-Barracuda-RBL-IP: 91.232.152.5 Received: from localhost (localhost [127.0.0.1]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id C8774411E1; Wed, 31 Aug 2016 10:45:58 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from cbssmtp1.cloudbase.local ([127.0.0.1]) by localhost (cbssmtp1.cloudbase.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vaCiv41kakZW; Wed, 31 Aug 2016 10:45:38 +0300 (EEST) Received: from CBSEX1.cloudbase.local (unknown [10.77.78.3]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id 510194100B; Wed, 31 Aug 2016 10:45:38 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0301.000; Wed, 31 Aug 2016 09:45:38 +0200 X-CudaMail-Envelope-Sender: pboca@cloudbasesolutions.com From: Paul Boca To: Guru Shetty X-CudaMail-MID: CM-V3-830001136 X-CudaMail-DTE: 083116 X-CudaMail-Originating-IP: 91.232.152.5 Thread-Topic: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon X-ASG-Orig-Subj: [##CM-V3-830001136##]RE: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon Thread-Index: AQHSArYrTXLAJ4+mDUufNjyFMCB0i6BhfJKAgAE0+IA= Date: Wed, 31 Aug 2016 07:45:37 +0000 Message-ID: <508339EC0242094682895ED3EC4EBA312E57177A@CBSEX1.cloudbase.local> References: <1472558417-2016-1-git-send-email-pboca@cloudbasesolutions.com> <1472558417-2016-3-git-send-email-pboca@cloudbasesolutions.com> In-Reply-To: Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-GBUdb-Analysis: 0, 91.232.152.5, Ugly c=0.323114 p=-0.304348 Source Normal X-MessageSniffer-Rules: 0-0-0-14998-c X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1472629561 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC0_MISMATCH_TO, HTML_MESSAGE, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.32482 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.00 HTML_MESSAGE BODY: HTML included in message 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" Hi Guru, There are other tests that check if the daemon is running fine. In my opinion we could skip this test on Windows and let it on Linux to run. Paul From: Guru Shetty [mailto:guru@ovn.org] Sent: Tuesday, August 30, 2016 6:18 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon On 30 August 2016 at 05:00, Paul Boca > wrote: If the python script is killed with `kill` command, the atexit handler doesn't gets executed on Windows. The kill of the process is done using NtTerminateProcess which doesn't sends a signal to the process itself, if just terminates the process from kernel mode. Signed-off-by: Paul-Daniel Boca > Instead of skipping the test, why not just skip the line that tests for pid after the process is killed. I imagine that the test is still useful in other respects, like whether detach works fine? --- V2: Initial commit --- tests/daemon-py.at | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.2.windows.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev diff --git a/tests/daemon-py.at b/tests/daemon-py.at index 96dea07..11833c8 100644 --- a/tests/daemon-py.at +++ b/tests/daemon-py.at @@ -126,6 +126,8 @@ DAEMON_MONITOR_RESTART_PYN([Python3], [$HAVE_PYTHON3], [$PYTHON3]) m4_define([DAEMON_DETACH_PYN], [AT_SETUP([daemon --detach - $1]) AT_SKIP_IF([test $2 = no]) + # Skip this test for Windows, the pid file not removed if the daemon is killed + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) AT_CAPTURE_FILE([pid]) # Start the daemon and make sure that the pidfile exists immediately. # We don't wait for the pidfile to get created because the daemon is