diff mbox

[ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

Message ID 508339EC0242094682895ED3EC4EBA312E541FD0@CBSEX1.cloudbase.local
State Superseded
Headers show

Commit Message

Paul Boca June 21, 2016, 9:37 a.m. UTC 
Hi Lance!

One small change that should be added to your patch.


This only affects some Python tests.

Thanks,
Paul

> -----Original Message-----

> From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Lance

> Richardson

> Sent: Tuesday, June 14, 2016 8:56 PM

> To: Alin Serdean

> Cc: dev@openvswitch.org

> Subject: Re: [ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

> 

> ----- Original Message -----

> > From: "Alin Serdean" <aserdean@cloudbasesolutions.com>

> > To: "Lance Richardson" <lrichard@redhat.com>, dev@openvswitch.org

> > Sent: Tuesday, June 14, 2016 1:22:36 PM

> > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

> >

> > I'll take a look over it tomorrow :).

> >

> > I saw that you had troubles compiling/linking the project on Windows.

> What

> > Visual Studio version did you use to compile it?

> >

> > Thanks,

> > Alin.

> >

> 

> Hi Alin,

> 

> Thanks, I was going to ping you and paul_boca after the IRC meeting

> today about that patch, but missed you both. I'll be traveling

> tomorrow, so my responses might be somewhat delayed.

> 

> Initially I tried using 2015, but ran into multiple compilation issues

> (the first due to a type collision in pthread.h, easily fixed, I don't

> recall what I ran into next), then 2013, which compiled and built with

> no issues.  However, when I tried to run the tests I saw a series

> of "entry point not found" pop-ups.  Turns out OVS uses

> GetSystemTimePreciseAsFileTime(), which isn't supported on Windows 7

> (it's only available on Windows 8 and 10). Updating to Windows 10 on

> the laptop I was using isn't an option (as I found out the hard way)

> because the manufacturer hasn't released display drivers for Windows 10.

> 

> Anyway, thanks for asking but I'm unlikely to pursue it any further

> (mainly due to a lack of time and lack of the right equipment).

> 

> Regards,

> 

>    Lance

> 

> > > -----Mesaj original-----

> > > De la: dev [mailto:dev-bounces@openvswitch.org] În numele Lance

> > > Richardson

> > > Trimis: Friday, June 10, 2016 7:28 PM

> > > Către: dev@openvswitch.org

> > > Subiect: Re: [ovs-dev] [PATCH] tests: fix issue in use of

> > > OVS_APP_EXIT_AND_WAIT

> > >

> > > ----- Original Message -----

> > > > From: "Lance Richardson" <lrichard@redhat.com>

> > > > To: dev@openvswitch.org

> > > > Sent: Friday, June 10, 2016 12:17:57 PM

> > > > Subject: [ovs-dev] [PATCH] tests: fix issue in use of

> > > OVS_APP_EXIT_AND_WAIT

> > > >

> > >

> > > Apologies, I forgot to add the "v2" tag.

> > > _______________________________________________

> > > dev mailing list

> > > dev@openvswitch.org

> > > http://openvswitch.org/mailman/listinfo/dev

> >

> _______________________________________________

> dev mailing list

> dev@openvswitch.org

> http://openvswitch.org/mailman/listinfo/dev

Comments

Lance Richardson June 21, 2016, 5:47 p.m. UTC | #1 
----- Original Message -----
> From: "Paul Boca" <pboca@cloudbasesolutions.com>
> To: "Lance Richardson" <lrichard@redhat.com>, "Alin Serdean" <aserdean@cloudbasesolutions.com>
> Cc: dev@openvswitch.org
> Sent: Tuesday, June 21, 2016 5:37:59 AM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
> 
> Hi Lance!
> 
> One small change that should be added to your patch.
> 
> diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
> index ac8749a..5171786 100644
> --- a/tests/ovs-vsctl.at
> +++ b/tests/ovs-vsctl.at
> @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP],
>  dnl OVS_VSCTL_CLEANUP
>  dnl
>  dnl Kills off the database server.
> -m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])])
> +m4_define([OVS_VSCTL_CLEANUP],
> [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])])
>  
>  dnl RUN_OVS_VSCTL(COMMAND, ...)
>  dnl
> 
> This only affects some Python tests.
> 
> Thanks,
> Paul

Hi Paul,

That issue, which was introduced after v1 had been posted, was addressed in v2.
v2 was posted to the ovs-dev list on June 10 (hmm, hopefully v2 isn't getting
too stale...):

   http://openvswitch.org/pipermail/dev/2016-June/072679.html

Any other issues?

Thanks,

   Lance
Paul Boca June 21, 2016, 7:43 p.m. UTC | #2 
Hi Lance!

Seems like I made a mistake here...
When trying to run tests on Windows all tests that use OVSDB_CHECK_MONITOR (ovsdb-monitor.at)
raise an error at line 42 where OVS_APP_EXIT_AND_WAIT_BY_TARGET is called.
The problem is that ovs-appctl is dumping the target log on stderr and AT_CHECK fails because the
output is not expected.

You can see in the previous version (before you added this acros)
https://github.com/openvswitch/ovs/blob/6132b241efd21160db57d9908ee630a215cce8ea/tests/ovsdb-monitor.at#L42
that  the output is ignored for ovs-appctl call.
Besides this all works well.

Regards,
Paul

> -----Original Message-----

> From: Lance Richardson [mailto:lrichard@redhat.com]

> Sent: Tuesday, June 21, 2016 8:47 PM

> To: Paul Boca

> Cc: Alin Serdean; dev@openvswitch.org; Ben Pfaff

> Subject: Re: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

> 

> ----- Original Message -----

> > From: "Paul Boca" <pboca@cloudbasesolutions.com>

> > To: "Lance Richardson" <lrichard@redhat.com>, "Alin Serdean"

> <aserdean@cloudbasesolutions.com>

> > Cc: dev@openvswitch.org

> > Sent: Tuesday, June 21, 2016 5:37:59 AM

> > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

> >

> > Hi Lance!

> >

> > One small change that should be added to your patch.

> >

> > diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at

> > index ac8749a..5171786 100644

> > --- a/tests/ovs-vsctl.at

> > +++ b/tests/ovs-vsctl.at

> > @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP],

> >  dnl OVS_VSCTL_CLEANUP

> >  dnl

> >  dnl Kills off the database server.

> > -m4_define([OVS_VSCTL_CLEANUP],

> [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])])

> > +m4_define([OVS_VSCTL_CLEANUP],

> > [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])])

> >

> >  dnl RUN_OVS_VSCTL(COMMAND, ...)

> >  dnl

> >

> > This only affects some Python tests.

> >

> > Thanks,

> > Paul

> 

> Hi Paul,

> 

> That issue, which was introduced after v1 had been posted, was addressed

> in v2.

> v2 was posted to the ovs-dev list on June 10 (hmm, hopefully v2 isn't getting

> too stale...):

> 

>    http://openvswitch.org/pipermail/dev/2016-June/072679.html

> 

> Any other issues?

> 

> Thanks,

> 

>    Lance
Lance Richardson June 21, 2016, 9:12 p.m. UTC | #3 
----- Original Message -----
> From: "Paul Boca" <pboca@cloudbasesolutions.com>
> To: "Lance Richardson" <lrichard@redhat.com>
> Cc: "Alin Serdean" <aserdean@cloudbasesolutions.com>, dev@openvswitch.org, "Ben Pfaff" <blp@ovn.org>
> Sent: Tuesday, June 21, 2016 3:43:44 PM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
> 
> Hi Lance!
> 
> Seems like I made a mistake here...
> When trying to run tests on Windows all tests that use OVSDB_CHECK_MONITOR
> (ovsdb-monitor.at)
> raise an error at line 42 where OVS_APP_EXIT_AND_WAIT_BY_TARGET is called.
> The problem is that ovs-appctl is dumping the target log on stderr and
> AT_CHECK fails because the
> output is not expected.
> 
> You can see in the previous version (before you added this acros)
> https://github.com/openvswitch/ovs/blob/6132b241efd21160db57d9908ee630a215cce8ea/tests/ovsdb-monitor.at#L42
> that  the output is ignored for ovs-appctl call.
> Besides this all works well.
> 
> Regards,
> Paul
> 

Hi Paul,

I think that is the issue under discussion by Ben Pfaff and Alin Serdean in this
thread:

   http://openvswitch.org/pipermail/dev/2016-June/072671.html

This seems to me to be unrelated to this patch set, if I've misinterpreted,
please let me know.

Thanks for testing and reviewing!

    Lance
diff mbox

Patch

diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index ac8749a..5171786 100644
--- a/tests/ovs-vsctl.at
+++ b/tests/ovs-vsctl.at
@@ -9,7 +9,7 @@  m4_define([OVS_VSCTL_SETUP],
 dnl OVS_VSCTL_CLEANUP
 dnl
 dnl Kills off the database server.
-m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])])
+m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])])
 
 dnl RUN_OVS_VSCTL(COMMAND, ...)
 dnl