| Message ID | 4dbd0b3e9921c9c7c1249b1d16e7ec71e5462d61.1762950453.git.echaudro@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Architectural refactoring of hardware offload infrastructure | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
git sha: 4dbd0b3e9921c9c7c1249b1d16e7ec71e5462d61 Author: Eelco Chaudron <echaudro@redhat.com> Subject: tests: Fix NSH decap header test for real Ethernet devices. This commit modifies a test pattern to allow for optional padding bytes at the end of Ethernet frames to accommodate the minimum 64-byte frame requirement on real hardware. > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 58a46af0a..c7f082fb1 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -9893,7 +9893,7 @@ NS_CHECK_EXEC([at_ns0], [$PYTHON3 $srcdir/sendpkt.py p0 \ > > dnl Check the expected de-capsulated TCP packet on the egress interface > OVS_WAIT_UNTIL([ovs-pcap p1.pcap | grep -q \ > - "^$(ovs-ofctl compose-packet --bare 'TCP_SYN_PKT')\$"]) > + "^$(ovs-ofctl compose-packet --bare 'TCP_SYN_PKT')0*\$"]) Would this regex pattern correctly handle cases where no padding is present? The `0*` pattern allows zero or more zero characters, but does this account for both the absence of padding bytes and the presence of actual padding bytes that might be rendered differently by ovs-pcap? > > OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 58a46af0a..c7f082fb1 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -9893,7 +9893,7 @@ NS_CHECK_EXEC([at_ns0], [$PYTHON3 $srcdir/sendpkt.py p0 \ dnl Check the expected de-capsulated TCP packet on the egress interface OVS_WAIT_UNTIL([ovs-pcap p1.pcap | grep -q \ - "^$(ovs-ofctl compose-packet --bare 'TCP_SYN_PKT')\$"]) + "^$(ovs-ofctl compose-packet --bare 'TCP_SYN_PKT')0*\$"]) OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP
Real Ethernet devices require padding bytes to meet the minimum 64-byte frame size. This change allows the test to pass by allowing include zero or more padding bytes at the end of the packet. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)