| Message ID | 45f82a7a7626f5ed3624971abe8b549c9afb6e00.1575542452.git.lorenzo.bianconi@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,ovn] system-ovn.at: check HAVE_TCPDUMP in "2 LSs IGMP" test | expand |
On Thu, Dec 5, 2019 at 11:42 AM Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote: > > Do not run "2 LSs IGMP" unitest if tcpdump is not currently installed on > the machine > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> Thanks Lorenzo for the patch. It looks good to me. Acked-by: Dumitru Ceara <dceara@redhat.com> > --- > tests/system-ovn.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index dbff58f24..bf598aec5 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -3128,6 +3128,7 @@ OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > AT_CLEANUP > > AT_SETUP([ovn -- 2 LSs IGMP]) > +AT_SKIP_IF([test $HAVE_TCPDUMP = no]) > AT_KEYWORDS([ovnigmp]) > > ovn_start > -- > 2.21.0 >
On Thu, Dec 5, 2019 at 8:10 PM Dumitru Ceara <dceara@redhat.com> wrote: > > On Thu, Dec 5, 2019 at 11:42 AM Lorenzo Bianconi > <lorenzo.bianconi@redhat.com> wrote: > > > > Do not run "2 LSs IGMP" unitest if tcpdump is not currently installed on > > the machine > > > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > > Thanks Lorenzo for the patch. It looks good to me. > > Acked-by: Dumitru Ceara <dceara@redhat.com> Thanks Lorenzo and Dumitru, I applied this patch to master. Numan > > > --- > > tests/system-ovn.at | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > > index dbff58f24..bf598aec5 100644 > > --- a/tests/system-ovn.at > > +++ b/tests/system-ovn.at > > @@ -3128,6 +3128,7 @@ OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > > AT_CLEANUP > > > > AT_SETUP([ovn -- 2 LSs IGMP]) > > +AT_SKIP_IF([test $HAVE_TCPDUMP = no]) > > AT_KEYWORDS([ovnigmp]) > > > > ovn_start > > -- > > 2.21.0 > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index dbff58f24..bf598aec5 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -3128,6 +3128,7 @@ OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d AT_CLEANUP AT_SETUP([ovn -- 2 LSs IGMP]) +AT_SKIP_IF([test $HAVE_TCPDUMP = no]) AT_KEYWORDS([ovnigmp]) ovn_start
Do not run "2 LSs IGMP" unitest if tcpdump is not currently installed on the machine Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- tests/system-ovn.at | 1 + 1 file changed, 1 insertion(+)